1. 16 8月, 2016 1 次提交
    • C
      Eager autoload ActiveRecord::TableMetadata · bb488668
      claudiob 提交于
      Fixes a bug that can occur when ActiveJob tries to access ActiveRecord.
      
      Specifically, I had an Active Job process fail on Sidekiq with this error:
      
      ```
      ActiveJob::DeserializationError: Error while trying to deserialize arguments:
      uninitialized constant ActiveRecord::Core::ClassMethods::TableMetadata
      Did you mean? ActiveRecord::TableMetadata
      ```
      
      raised by these lines of code:
      
      ```
      [GEM_ROOT]/gems/activerecord-5.0.0.1/lib/active_record/core.rb:300 :in `table_metadata`
      298
      299       def table_metadata # :nodoc:
      300         TableMetadata.new(self, arel_table)
      301       end
      302     end
      [GEM_ROOT]/gems/activerecord-5.0.0.1/lib/active_record/core.rb:273 :in `predicate_builder`
      [GEM_ROOT]/gems/activerecord-5.0.0.1/lib/active_record/core.rb:290 :in `relation`
      ```
      
      The problem seems to be that, inside ActiveRecord::Core, the `TableMetadata`
      class has not been loaded and, therefore, Rails tries to access the constant
      `ActiveRecord::Core::ClassMethods::TableMetadata` which does not exist.
      
      Eager loading `ActiveRecord::TableMetadata` should fix the issue.
      
      @rafaelfranca -- see our Campfire discussion
      bb488668
  2. 15 8月, 2016 4 次提交
  3. 14 8月, 2016 1 次提交
  4. 13 8月, 2016 1 次提交
  5. 12 8月, 2016 1 次提交
  6. 11 8月, 2016 3 次提交
  7. 10 8月, 2016 3 次提交
    • G
      Fix a NoMethodError schema_statements.rb · 01fbdb31
      Genadi Samokovarov 提交于
      If you call `remove_index` with wrong options, say a type, like I did,
      you get:
      
      ```
      == 20160810072541 RemoveUniqueIndexOnGoals: migrating =========================
      -- remove_index(:goal, {:coulmn=>:kid_id, :unique=>true})
      rails aborted!
      StandardError: An error has occurred, this and all later migrations canceled:
      
      undefined method `ArgumentError' for #<ActiveRecord::ConnectionAdapters::PostgreSQLAdapter:0x007fb7dec91b28>
      ```
      
      What happened is that I mistyped column (coulmn) and got a
      `NoMethodError`, because of a missing comma during the raise. This made
      Ruby think we're calling the method `ArgumentError`.
      01fbdb31
    • V
      Pass over changelogs [ci skip] · 8b984161
      Vipul A M 提交于
      8b984161
    • R
      Fix broken alignments caused by auto-correct commit 411ccbda · f006de5d
      Ryuta Kamizono 提交于
      Hash syntax auto-correcting breaks alignments. 411ccbda
      f006de5d
  8. 09 8月, 2016 1 次提交
  9. 08 8月, 2016 3 次提交
  10. 07 8月, 2016 10 次提交
  11. 06 8月, 2016 2 次提交
  12. 05 8月, 2016 3 次提交
    • S
      Don't assume all hashes are from multiparameter assignment in `composed_of` · b63d532f
      Sean Griffin 提交于
      So this bug is kinda funky. The code path is basically "if we weren't passed an
      instance of the class we compose to, and we have a converter, call that".
      Ignoring the hash case for a moment, everything after that was roughly intended
      to be the "else" clause, meaning that we are expected to have an instance of
      the class we compose to. Really, we should be blowing up in that case, as we
      can give a much better error message than what they user will likely get (e.g.
      `NameError: No method first for String` or something). Still, Ruby is duck
      typed, so if the object you're assigning responds to the same methods as the
      type you compose to, knock yourself out.
      
      The hash case was added in 36e9be85 to remove a bunch of special cased code from
      multiparameter assignment. I wrongly assumed that the only time we'd get a hash
      there is in that case. Multiparameter assignment will construct a very specific
      hash though, where the keys are integers, and we will have a set of keys
      covering `1..part.size` exactly. I'm pretty sure this could actually be passed
      around as an array, but that's a different story. Really I should convert this
      to something like `class MultiParameterAssignment < Hash; end`, which I might
      do soon. However for a change that I'm willing to backport to 4-2-stable, this
      is what I want to go with for the time being.
      
      Fixes #25978
      b63d532f
    • D
      7443a332
    • D
  13. 04 8月, 2016 1 次提交
  14. 03 8月, 2016 2 次提交
  15. 02 8月, 2016 2 次提交
  16. 31 7月, 2016 1 次提交
  17. 29 7月, 2016 1 次提交