- 06 5月, 2016 20 次提交
-
-
由 Jon Moss 提交于
Fix link in 'Configuring Rails Applications' [ci skip]
-
由 Javier Vidal 提交于
-
由 Eileen M. Uchitelle 提交于
Fix link in 'Ruby on Rails 3.0 Release Notes' [ci skip]
-
由 Javier Vidal 提交于
-
由 Vipul A M 提交于
Fix markdown syntax in 'Ruby on Rails 2.2 Release Notes' [ci skip]
-
由 Javier Vidal 提交于
-
由 Kasper Timm Hansen 提交于
[ci skip] Release notes: Add PR #24866 to release notes
-
由 Prathamesh Sonpatki 提交于
-
由 Arthur Nogueira Neves 提交于
Implement helpers proxy in controller instance level
-
由 Rafael França 提交于
Active Model: Improve CHANGELOG and documentation for `validates_acceptance_of` [ci skip]
-
由 Rafael França 提交于
Expand on Action Mailer Fragment caching tests
-
由 Prathamesh Sonpatki 提交于
- Improve CHANGELOG entry for #18439. - The documentation is updated as per changes in PR #18439 to the `accept` option. - The explanation about the virtual attribute is moved at the end so that the arity of `accept` option is explained first. - Added a note that `message` can also be passed to `validates_acceptance_of`.
-
由 Rafael França 提交于
Followup of #18322
-
由 Rafael Mendonça França 提交于
It is a common pattern in the Rails community that when people want to :xa use any kind of helper that is defined inside app/helpers they includes the helper module inside the controller like: module UserHelper def my_user_helper # ... end end class UsersController < ApplicationController include UserHelper def index render inline: my_user_helper end end This has problem because the helper can't access anything that is defined in the view level context class. Also all public methods of the helper become available in the controller what can lead to undesirable methods being routed and behaving as actions. Also if you helper depends on other helpers or even Action View helpers you need to include each one of these dependencies in your controller otherwise your helper is not going to work. We already have a helpers proxy at controller class level but that proxy doesn't have access to the instance variables defined in the controller. With this new instance level helper proxy users can reuse helpers in the controller without having to include the modules and with access to instance variables defined in the controller. class UsersController < ApplicationController def index render inline: helpers.my_user_helper end end
-
由 Rafael França 提交于
Change to use a more realistic example [ci skip]
-
由 Rafael França 提交于
delegate encode_with instead of to_yaml, which is deprecated
-
由 Vipul A M 提交于
Change to use a more realistic example and not giving the impression that destroy_all is preferred way to destroy related records. This example just wants to demonstrate callback behaviour. [ci skip]
-
由 Vipul A M 提交于
-
由 Rafael França 提交于
Remove extra space [ci skip]
-
由 Rafael Mendonça França 提交于
There were a lot of protected instance variables in AbsctractController::Rendering that were related to Action Controller and Action View. Moving to ActionController::Base's protected instance list we make it closer to where they are really defined.
-
- 05 5月, 2016 13 次提交
-
-
由 Kasper Timm Hansen 提交于
After fb898e98, the `before_destroy` had some code that used SQL interpolation left over. Don't think we should promote that even if the values aren't directly from user input.
-
由 Jon Moss 提交于
-
由 Vipul A M 提交于
do not pass conditions to `#destroy_all` [ci skip]
-
由 yuuji.yaginuma 提交于
Passing conditions to `#destroy_all` was deprecated in c82c5f8f.
-
由 Andrew White 提交于
Run Active Support tests in both `to_time` modes
-
由 Andrew White 提交于
Add to the matrix of Travis tests an entry that runs the Active Support tests when `ActiveSupport.to_time_preserves_timezone = true`.
-
由 Andrew White 提交于
These two tests are explicitly testing that to_time is returning times with the sytem timezone's UTC offset, therefore they will fail when running them with `ActiveSupport.to_time_preserves_timezone = true`.
-
由 Andrew White 提交于
The to_yaml method is undefined when running the test as: $ ruby -I lib:test test/core_ext/string_ext_test.rb Doesn't fail when running rake test:isolated presumably because something else has required 'yaml' already.
-
由 Kasper Timm Hansen 提交于
Ensure compatibility between ActionDispatch::Request::Session and Rack
-
由 Jon Moss 提交于
Adding the `each` method is required for ensuring compatibility between Rails, and other Rack frameworks (like Sinatra, etc.), that are mounted within Rails, and wish to use its session tooling. Prior to this, there was an inconsistency between ActionDispatch::Request::Session and Rack::Session::Cookie, due to the absence of the `each` method. This should hopefully fix that error. :) For a full integration test with Sinatra and a standalone Rack application, you can check out the gist for that here: https://gist.github.com/maclover7/08cd95b0bfe259465314311941326470. Solves #15843.
-
由 Kasper Timm Hansen 提交于
Bump Ruby versions
-
由 Vipul A M 提交于
Fix some typos in comments [ci skip]
-
由 Joe Rafaniello 提交于
[ci skip]
-
- 04 5月, 2016 7 次提交
-
-
由 Jon Moss 提交于
2.2.4 --> 2.2.5 2.3.0 --> 2.3.1
-
由 Xavier Noria 提交于
This is an engine living in action_cable/engine.rb, convention is to call these things *::Engine. Looking at thi git history looks like the current *::Railtie was just an accident.
-
由 Rafael França 提交于
Fix actionpack typos [ci skip]
-
由 Tom Kadwill 提交于
-
由 Rafael França 提交于
Depend on bundler 1.11.2 on travis until bundle update discrepancy is solved on 1.12.x
-
由 Rafael Mendonça França 提交于
-
由 Vipul A M 提交于
Fix failing tests
-