- 15 7月, 2017 1 次提交
-
-
由 dixpac 提交于
Revert `exist? and url` to the original implementation. Since the new one doesn't provide any benefits and makes implementation harder to follow.
-
- 14 7月, 2017 4 次提交
-
-
由 Cristian Bica 提交于
-
由 Dino Maric 提交于
So tests are passing if the bucket name is rails-active storage. But developers specify their own s3 tests configuration (in my case was activestorage-test) then this regex fails. Also the first part is dynamic and based on bucket name and region
-
由 George Claghorn 提交于
Remove unnecessary variables from gcs_service implementation
-
由 dixpac 提交于
-
- 13 7月, 2017 2 次提交
-
-
由 George Claghorn 提交于
Update GCSService#url
-
由 Chris Smith 提交于
Update google-cloud-storage dependency to 1.3 Refactor arguments to Google::Cloud::Storage::File#signed_url
-
- 12 7月, 2017 3 次提交
-
-
由 David Heinemeier Hansson 提交于
This reverts commit 6d396246.
-
由 Jeremy Daer 提交于
* Use simple core API for duck-type compat with other clients * initialize: accept an existing client * initialize: accept arbitrary client args instead of a fixed, required set * download: use native get_object streaming, no need to implement range requests * exists?: use head_object (which returns immediately) rather than waiting for existence
-
由 George Claghorn 提交于
This reverts commit 53d5384a.
-
- 11 7月, 2017 2 次提交
-
-
由 George Claghorn 提交于
-
由 George Claghorn 提交于
-
- 10 7月, 2017 6 次提交
-
-
由 Dino Maric 提交于
Since we use new aws-sdk API, I've scoped aws-sdk version so someone doesn't accidentaly installs wrong version during the development.
-
由 Jeremy Daer 提交于
So tests pass when service configs aren't set up. References #28
-
由 Jeremy Daer 提交于
-
由 Dino Maric 提交于
-
由 David Heinemeier Hansson 提交于
-
由 David Heinemeier Hansson 提交于
-
- 09 7月, 2017 22 次提交
-
-
由 David Heinemeier Hansson 提交于
# Conflicts: # lib/active_storage/engine.rb # lib/active_storage/service.rb # lib/active_storage/service/disk_service.rb # lib/active_storage/service/s3_service.rb # test/service/s3_service_test.rb # test/test_helper.rb
-
由 David Heinemeier Hansson 提交于
-
由 David Heinemeier Hansson 提交于
-
由 David Heinemeier Hansson 提交于
-
由 David Heinemeier Hansson 提交于
Symbolize all keys inside configuration nested hash
-
由 David Heinemeier Hansson 提交于
-
由 David Heinemeier Hansson 提交于
-
由 dixpac 提交于
Since configuration is a nested hash we need to symbolize all keys of the hash. Othervise fetcing will fail on start
-
由 David Heinemeier Hansson 提交于
-
由 David Heinemeier Hansson 提交于
Clarify how a service can build other composed services
-
由 David Heinemeier Hansson 提交于
-
由 Jeremy Daer 提交于
* Service.build takes the literal YAML config hash for the service and a reference to the Configurator that's doing the building. * Services that compose additional services can use the Configurator to look them up and build them by name. See MirrorService for an example. References #23
-
由 Jeremy Daer 提交于
First arg is config for the service we're instantiating. Second arg is service configurations so we can look up and configure other services by name.
-
由 Jeremy Daer 提交于
-
由 Jeremy Daer 提交于
* Move service configuration from the Engine to Service * Delegate configuration mechanics to internal Service::Configurator * Delegate service building to the concrete Service classes, allowing them to configure composed services. * Implement for the Mirror service.
-
由 Jeremy Daer 提交于
Pass separate primary service and list of mirrors rather than treating the first of the services list as the primary. Nice fit for keyword args, and something we've long wanted in the equivalent Basecamp file repository. Upload returns the results of the underlying service uploads rather than the io.rewind result. Rewind before uploading rather than afterward, and demonstrate that behavior with a test. Test that more than one mirror works.
-
由 David Heinemeier Hansson 提交于
Disk service: use binary IO throughout, not UTF-8
-
由 David Heinemeier Hansson 提交于
Disk storage: ensure URLs end with the blob filename
-
由 Jeremy Daer 提交于
Disk storage: ensure URLs end with the blob filename since some user agents don't respect Content-Disposition filename
-
由 Jeremy Daer 提交于
-
由 Jeremy Daer 提交于
-
由 David Heinemeier Hansson 提交于
Add some documentation
-