提交 14e6386b 编写于 作者: D Dino Maric 提交者: David Heinemeier Hansson

Fix regular expression on s3 test URL generation test (#44)

So tests are passing if the bucket name is rails-active storage.
But developers specify their own s3 tests configuration (in my case was
activestorage-test) then this regex fails.

Also the first part is dynamic and based on bucket name and region
上级 50bec562
......@@ -16,7 +16,7 @@ class ActiveStorage::Service::S3ServiceTest < ActiveSupport::TestCase
key = SecureRandom.base58(24)
data = "Something else entirely!"
direct_upload_url = @service.url_for_direct_upload(key, expires_in: 5.minutes, content_type: "text/plain", content_length: data.size)
url = URI.parse(direct_upload_url).to_s.split("?").first
query = CGI::parse(URI.parse(direct_upload_url).query).collect { |(k, v)| [ k, v.first ] }.to_h
......@@ -30,16 +30,16 @@ class ActiveStorage::Service::S3ServiceTest < ActiveSupport::TestCase
},
debug_output: STDOUT
)
assert_equal data, @service.download(key)
ensure
@service.delete key
end
end
test "signed URL generation" do
assert_match /rails-activestorage\.s3\.amazonaws\.com.*response-content-disposition=inline.*avatar\.png/,
@service.url(FIXTURE_KEY, expires_in: 5.minutes, disposition: :inline, filename: "avatar.png")
assert_match /.+s3.+amazonaws.com.*response-content-disposition=inline.*avatar\.png/,
@service.url(FIXTURE_KEY, expires_in: 5.minutes, disposition: :inline, filename: "avatar.png")
end
end
else
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册