- 22 12月, 2017 1 次提交
-
-
由 Yoshiyuki Hirano 提交于
-
- 21 12月, 2017 2 次提交
-
-
由 Guillermo Iguaran 提交于
Removes OS specific directory separator
-
由 Daniel Lopez 提交于
-
- 20 12月, 2017 12 次提交
-
-
由 Ryuta Kamizono 提交于
Handle `FrozenError` if it is available
-
由 Ryuta Kamizono 提交于
Fix Illegal parameter data type bigint for operation 'get_lock' error
-
由 Yasuo Honda 提交于
This pull request handles `FrozenError` introduced by Ruby 2.5. Refer https://bugs.ruby-lang.org/projects/ruby-trunk/repository/revisions/61131 Since `FrozenError` is a subclass of `RuntimeError` minitest used by master branch can handle it, though it would be better to handle `FrozenError` explicitly if possible. `FrozenError` does not exist in Ruby 2.4 or lower, `frozen_error_class` handles which exception is expected to be raised. This pull request is intended to be merged to master, then backported to `5-1-stable` to address #31508
-
由 yuuji.yaginuma 提交于
Follow up of #31289.
-
由 Ivan Zinovyev 提交于
-
由 Ryuta Kamizono 提交于
Follow up of #31177.
-
由 Ryuta Kamizono 提交于
Like other query bang methods.
-
由 Ryuta Kamizono 提交于
Remove verbose_query_logs from new_framework_defaults_5_2.rb
-
由 Eugene Kenny 提交于
The `app:update` rake task will regenerate `development.rb` so that it contains this option; that means we're currently adding it to existing apps in two places, which is unnecessary and confusing. Also: - Remove inaccurate comment about which stack frames are ignored - Clarify that the feature uses `caller_locations`, not `caller` - Remove unused return value in `extract_callstack`
-
由 Matthew Draper 提交于
Remove default ENGINE=InnoDB for Mysql2 adapter
-
由 Ryuta Kamizono 提交于
Currently `count(:all)` with `distinct` doesn't work correctly because SELECT list is always replaced to `*` or primary key in that case even if having custom SELECT list. And also, PostgreSQL has a limitation that ORDER BY expressions must appear in select list for SELECT DISTINCT. Therefore, we should not replace custom SELECT list when using `count(:all)` with `distinct`. Closes #31277.
-
由 Ryuta Kamizono 提交于
Merge pull request #31483 from yhirano55/fix_validation_callbacks_on_multiple_context_in_active_model Bugfix: validation callbacks on multiple context
-
- 19 12月, 2017 18 次提交
-
-
由 Yoshiyuki Hirano 提交于
I found a bug that validation callbacks don't fire on multiple context. So I've fixed it. Example: ```ruby class Dog include ActiveModel::Validations include ActiveModel::Validations::Callbacks attr_accessor :history def initialize @history = [] end before_validation :set_before_validation_on_a, on: :a before_validation :set_before_validation_on_b, on: :b after_validation :set_after_validation_on_a, on: :a after_validation :set_after_validation_on_b, on: :b def set_before_validation_on_a; history << "before_validation on a"; end def set_before_validation_on_b; history << "before_validation on b"; end def set_after_validation_on_a; history << "after_validation on a" ; end def set_after_validation_on_b; history << "after_validation on b" ; end end ``` Before: ``` d = Dog.new d.valid?([:a, :b]) d.history # [] ``` After: ``` d = Dog.new d.valid?([:a, :b]) d.history # ["before_validation on a", "before_validation on b", "after_validation on a", "after_validation on b"] ```
-
由 Ryuta Kamizono 提交于
-
由 Eileen M. Uchitelle 提交于
assert_nothing_raised not required here, we can assert directly for the actual result
-
由 Ryuta Kamizono 提交于
Otherwise it will occur syntax error if primary key is a reserved word.
-
由 Ryuta Kamizono 提交于
Arel doesn't support subselect generation for DELETE unlike UPDATE yet, but we already have that generation in connection adapters. We can simply use the subselect generated by that one.
-
由 Ryuta Kamizono 提交于
Most RDBMS (except SQLite) requires subselect for UPDATE with OFFSET, but Arel doesn't support executable subselect generation for MySQL's UPDATE yet. We need to use the subselect generated by the connection adapter for now, it works well. Fixes #30148.
-
由 Prathamesh Sonpatki 提交于
-
由 Ryuta Kamizono 提交于
[ci skip] Added Object Relational Mapping wiki link
-
由 Dixit Patel 提交于
-
由 George Claghorn 提交于
-
由 Matthew Draper 提交于
Undefine attribute methods of descendants when resetting column information
-
由 yuuji.yaginuma 提交于
Specifying the `--dev` option is when want to change the codebase, as it is not necessary to cache it. Context: https://github.com/rails/rails/pull/31485#issuecomment-352452653
-
由 Kasper Timm Hansen 提交于
Raise an error only when `require_master_key` is specified
-
由 Kasper Timm Hansen 提交于
Update new_framework_defaults_5_2.rb.tt
-
由 George Claghorn 提交于
-
由 Anton Rieder 提交于
Be consistent in comments when mentioning AES.
-
由 Eileen M. Uchitelle 提交于
Add headless browser support in api docs [ci skip]
-
由 Pierre Hedkvist 提交于
-
- 18 12月, 2017 7 次提交
-
-
由 Eileen M. Uchitelle 提交于
Add `skip_bootsnap` option
-
由 Eileen M. Uchitelle 提交于
Clarify docs for delegate :allow_nil option
-
由 Eileen M. Uchitelle 提交于
Don't include ellipsis in truncated digest output
-
由 George Claghorn 提交于
-
由 yuuji.yaginuma 提交于
To prevent errors from being raise in environments where credentials is unnecessary. Context: https://github.com/rails/rails/issues/31283#issuecomment-348801489 Fixes #31283
-
由 Ryuta Kamizono 提交于
Looks like it is failed due to datetime rounding. Related #23521. https://travis-ci.org/rails/rails/jobs/317734560#L1980-L1984
-
由 Ryuta Kamizono 提交于
Previously table name qualified `*` is used in that case. If it is not qualified with a table name, an ambiguous column name error will occur when using JOINs.
-