Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
张重言
rails
提交
4aeeb6dc
R
rails
项目概览
张重言
/
rails
通知
1
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
R
rails
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
提交
Issue看板
体验新版 GitCode,发现更多精彩内容 >>
提交
4aeeb6dc
编写于
12月 20, 2017
作者:
R
Ryuta Kamizono
浏览文件
操作
浏览文件
下载
电子邮件补丁
差异文件
Remove passing needless empty string `options` in `create_table`
Follow up of #31177.
上级
0aa0de17
变更
3
隐藏空白更改
内联
并排
Showing
3 changed file
with
4 addition
and
7 deletion
+4
-7
activerecord/lib/active_record/connection_adapters/abstract/schema_creation.rb
...ve_record/connection_adapters/abstract/schema_creation.rb
+1
-0
activerecord/lib/active_record/connection_adapters/abstract_mysql_adapter.rb
...tive_record/connection_adapters/abstract_mysql_adapter.rb
+0
-4
activerecord/test/cases/adapters/mysql2/active_schema_test.rb
...verecord/test/cases/adapters/mysql2/active_schema_test.rb
+3
-3
未找到文件。
activerecord/lib/active_record/connection_adapters/abstract/schema_creation.rb
浏览文件 @
4aeeb6dc
...
...
@@ -95,6 +95,7 @@ def add_table_options!(create_sql, options)
if
options_sql
=
options
[
:options
]
create_sql
<<
"
#{
options_sql
}
"
end
create_sql
end
def
column_options
(
o
)
...
...
activerecord/lib/active_record/connection_adapters/abstract_mysql_adapter.rb
浏览文件 @
4aeeb6dc
...
...
@@ -292,10 +292,6 @@ def table_comment(table_name) # :nodoc:
SQL
end
def
create_table
(
table_name
,
**
options
)
#:nodoc:
super
(
table_name
,
options:
""
,
**
options
)
end
def
bulk_change_table
(
table_name
,
operations
)
#:nodoc:
sqls
=
operations
.
flat_map
do
|
command
,
args
|
table
,
arguments
=
args
.
shift
,
args
...
...
activerecord/test/cases/adapters/mysql2/active_schema_test.rb
浏览文件 @
4aeeb6dc
...
...
@@ -68,14 +68,14 @@ def test_index_in_create
def
(
ActiveRecord
::
Base
.
connection
)
.
data_source_exists?
(
*
);
false
;
end
%w(SPATIAL FULLTEXT UNIQUE)
.
each
do
|
type
|
expected
=
"CREATE TABLE `people` (
#{
type
}
INDEX `index_people_on_last_name` (`last_name`))
"
expected
=
"CREATE TABLE `people` (
#{
type
}
INDEX `index_people_on_last_name` (`last_name`))"
actual
=
ActiveRecord
::
Base
.
connection
.
create_table
(
:people
,
id:
false
)
do
|
t
|
t
.
index
:last_name
,
type:
type
end
assert_equal
expected
,
actual
end
expected
=
"CREATE TABLE `people` ( INDEX `index_people_on_last_name` USING btree (`last_name`(10)))
"
expected
=
"CREATE TABLE `people` ( INDEX `index_people_on_last_name` USING btree (`last_name`(10)))"
actual
=
ActiveRecord
::
Base
.
connection
.
create_table
(
:people
,
id:
false
)
do
|
t
|
t
.
index
:last_name
,
length:
10
,
using: :btree
end
...
...
@@ -160,7 +160,7 @@ def test_indexes_in_create
ActiveRecord
::
Base
.
connection
.
stubs
(
:data_source_exists?
).
with
(
:temp
).
returns
(
false
)
ActiveRecord
::
Base
.
connection
.
stubs
(
:index_name_exists?
).
with
(
:index_temp_on_zip
).
returns
(
false
)
expected
=
"CREATE TEMPORARY TABLE `temp` ( INDEX `index_temp_on_zip` (`zip`))
AS SELECT id, name, zip FROM a_really_complicated_query"
expected
=
"CREATE TEMPORARY TABLE `temp` ( INDEX `index_temp_on_zip` (`zip`)) AS SELECT id, name, zip FROM a_really_complicated_query"
actual
=
ActiveRecord
::
Base
.
connection
.
create_table
(
:temp
,
temporary:
true
,
as:
"SELECT id, name, zip FROM a_really_complicated_query"
)
do
|
t
|
t
.
index
:zip
end
...
...
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录