1. 08 7月, 2012 1 次提交
  2. 07 7月, 2012 1 次提交
  3. 03 7月, 2012 1 次提交
  4. 01 7月, 2012 1 次提交
  5. 15 6月, 2012 1 次提交
  6. 12 6月, 2012 1 次提交
  7. 01 6月, 2012 4 次提交
  8. 31 5月, 2012 1 次提交
    • S
      accept a block in button_to helper · ab7a80ea
      Sergey Nartimov 提交于
      Make possible to use a block in button_to helper if button text is hard
      to fit into the name parameter, e.g.:
      
          <%= button_to [:make_happy, @user] do %>
            Make happy <strong><%= @user.name %></strong>
          <% end %>
          # => "<form method="post" action="/users/1/make_happy" class="button_to">
          #      <div>
          #        <button type="submit">
          #          Make happy <strong>Name</strong>
          #        </button>
          #      </div>
          #    </form>"
      ab7a80ea
  9. 28 5月, 2012 1 次提交
    • P
      Fix sorting of helpers from different paths · e4aaac13
      Piotr Sarnacki 提交于
      When more than one directory for helpers is provided to a controller, it
      should preserver the order of directories. Given 2 paths:
      
          MyController.helpers_paths = ["dir1/helpers", "dir2/helpers"]
      
      helpers from dir1 should be loaded first. Before this commit, all
      helpers were mixed and then sorted alphabetically, which essentially
      would require to rename helpers to get desired order.
      
      This is a problem especially for engines, where you would like to be
      able to predict accurately which engine helpers will load first.
      
      (closes #6496)
      e4aaac13
  10. 27 5月, 2012 2 次提交
  11. 22 5月, 2012 2 次提交
  12. 21 5月, 2012 3 次提交
    • R
      Fix CHANGELOG order and add a brief description of the changes in the · a78ee05d
      Rafael Mendonça França 提交于
      Action Pack in the upgrading guide. [ci skip]
      a78ee05d
    • A
      Return 400 Bad Request for URL paths with invalid encoding. · 3fc561a1
      Andrew White 提交于
      Passing path parameters with invalid encoding is likely to trigger errors
      further on like `ArgumentError (invalid byte sequence in UTF-8)`. This will
      result in a 500 error whereas the better error to return is a 400 error which
      allows exception notification libraries to filter it out if they wish.
      
      Closes #4450
      3fc561a1
    • A
      Raise ActionController::BadRequest for malformed parameter hashes. · 66eb3f02
      Andrew White 提交于
      Currently Rack raises a TypeError when it encounters a malformed or
      ambiguous hash like `foo[]=bar&foo[4]=bar`. Rather than pass this
      through to the application this commit captures the exception and
      re-raises it using a new ActionController::BadRequest exception.
      
      The new ActionController::BadRequest exception returns a 400 error
      instead of the 500 error that would've been returned by the original
      TypeError. This allows exception notification libraries to ignore
      these errors if so desired.
      
      Closes #3051
      66eb3f02
  13. 20 5月, 2012 1 次提交
    • D
      Raise Assertion instead of RoutingError for routing assertion failures. · dcce0113
      David Chelimsky 提交于
      Before this change, assert_recognizes, assert_generates, and
      assert_routing raised ActionController::RoutingError when they failed to
      recognize the route.
      
      This commit changes them to raise Assertion instead. This aligns with
      convention for logical failures, and supports reporting tools that care
      about the difference between logical failures and errors e.g. the
      summary at the end of a test run.
      
      - Fixes #5899
      dcce0113
  14. 19 5月, 2012 1 次提交
    • C
      Clarify grouped_options_for_select method API, add changelog entry · 0e207a49
      Carlos Antonio da Silva 提交于
      Make the method API more clear by explicitly showing the expected
      arguments. This means that the options cannot be passed as second
      argument because we are not relying on extract_options! anymore,
      you are expected to give a selected key or `nil` if you want to pass
      options, as it is the last argument.
      
      Notice that this does not change the current method arguments contract
      available in 3.2, it just brings back the same functionality with the
      divider addition.
      0e207a49
  15. 18 5月, 2012 3 次提交
  16. 15 5月, 2012 3 次提交
  17. 14 5月, 2012 1 次提交
  18. 13 5月, 2012 2 次提交
  19. 12 5月, 2012 1 次提交
  20. 11 5月, 2012 1 次提交
  21. 06 5月, 2012 1 次提交
  22. 03 5月, 2012 2 次提交
  23. 30 4月, 2012 3 次提交
  24. 29 4月, 2012 2 次提交