1. 26 1月, 2018 4 次提交
  2. 15 12月, 2017 1 次提交
  3. 14 12月, 2017 1 次提交
  4. 13 12月, 2017 1 次提交
  5. 12 12月, 2017 1 次提交
  6. 10 12月, 2017 1 次提交
  7. 07 12月, 2017 1 次提交
  8. 06 12月, 2017 1 次提交
  9. 29 11月, 2017 1 次提交
  10. 09 11月, 2017 2 次提交
    • N
      Use `Dir.mktmpdir` · 2d5700b9
      Nobuyoshi Nakada 提交于
      As `@cache_path` is expected to be a directory name, use `Dir.mktmpdir`.
      And omit unnecessary `Dir.tmpdir`.
      2d5700b9
    • N
      Use `Tempfile.create` · 4022f334
      Nobuyoshi Nakada 提交于
      Instead of `Dir::Tmpname.make_tmpname`, an internal method which does not guarantee uniqueness, use `Tempfile.create`.
      4022f334
  11. 04 11月, 2017 1 次提交
  12. 28 10月, 2017 2 次提交
  13. 26 10月, 2017 1 次提交
  14. 10 10月, 2017 1 次提交
  15. 30 9月, 2017 1 次提交
  16. 25 9月, 2017 1 次提交
    • M
      Add key rotation cookies middleware · 8b0af54b
      Michael Coyne 提交于
      Using the action_dispatch.cookies_rotations interface, key rotation is
      now possible with cookies. Thus the secret_key_base as well as salts,
      ciphers, and digests, can be rotated without expiring sessions.
      8b0af54b
  17. 06 9月, 2017 1 次提交
  18. 02 9月, 2017 1 次提交
  19. 23 8月, 2017 2 次提交
    • P
      2b4c547e
    • P
      Normalize/process Cach-Control headers consistently · 8a7e91b0
      Patrick Toomey 提交于
      In the existing logic, the `Cache-Control` header may or may not get
      normalized by additional logic depending on whether `response.cache_conrol`
      has been modified. This leads to inconsistent behavior, since sometimes
      `Cache-Control` can contain whatever a user sets and sometimes it gets
      normalized, based on the logic inside of `set_conditional_cache_control!`. It
      seems like this normalization process should happen regardless to ensure
      consistent behavior.
      8a7e91b0
  20. 16 8月, 2017 1 次提交
    • K
      Fix RuboCop offenses · 7c260ae2
      Koichi ITO 提交于
      And enable `context_dependent` of Style/BracesAroundHashParameters cop.
      7c260ae2
  21. 02 8月, 2017 1 次提交
    • E
      Path parameters should default to UTF8 · 92209356
      eileencodes 提交于
      This commit changes the behavior such the path_params now default to
      UTF8 just like regular parameters. This also changes the behavior such
      that if a path parameter contains invalid UTF8 it returns a 400 bad
      request. Previously the behavior was to encode the path params as binary
      but that's not the same as query params.
      
      So this commit makes path params behave the same as query params.
      
      It's important to test with a path that's encoded as binary because
      that's how paths are encoded from the socket. The test that was altered
      was changed to make the behavior for bad encoding the same as query
      params. We want to treat path params the same as query params. The params
      in the test are invalid UTF8 so they should return a bad request.
      
      Fixes #29669
      
      *Eileen M. Uchitelle, Aaron Patterson, & Tsukuru Tanimichi*
      92209356
  22. 29 7月, 2017 1 次提交
  23. 25 7月, 2017 1 次提交
  24. 11 7月, 2017 2 次提交
  25. 07 7月, 2017 1 次提交
  26. 02 7月, 2017 1 次提交
  27. 01 7月, 2017 1 次提交
  28. 30 6月, 2017 1 次提交
  29. 27 6月, 2017 1 次提交
    • E
      Calling `follow_redirect!` does not reset the `html_document`: · 2508c7de
      Edouard CHIN 提交于
      - When making a request to a controller that redirects, `follow_redirect!` would not reset the `html_document` ivar, it only resets the `html_document` ivar from the session (not the runner)
      - If one was doing something like this;
        ```ruby
          get '/redirect'
          assert_select 'you are being redirected'
          follow_redirect!
          # html_document is memoized and doesn't get reset
        ```
      - To fix the issue we can do the same for any other methods (`get`, `post`...) and define a method in the runner that delegates to the session but clears the html_document_first
      - Fixes #29367
      2508c7de
  30. 25 6月, 2017 1 次提交
    • E
      Don't wrap parameters if query parameter exists · ab491134
      Eugene Kenny 提交于
      We want to avoid overwriting a query parameter with the wrapped
      parameters hash. Previously this was implemented by merging the wrapped
      parameters at the root level if the key already existed, which was
      effectively a no-op. The query parameter was still overwritten in the
      filtered parameters hash, however.
      
      We can fix that discrepancy with a simpler implementation and less
      unnecessary work by skipping parameter wrapping entirely if the key was
      sent as a query parameter.
      ab491134
  31. 24 6月, 2017 1 次提交
    • E
      Don't wrap parameters if key already exists · b3966080
      Eugene Kenny 提交于
      We shouldn't perform parameter wrapping if it would overwrite one of the
      parameters sent with the request, as that would interfere with reading
      the parameter directly from the top level `params` hash.
      
      The current implementation has logic for this case, but it doesn't
      handle `nil`/`false` values, which means these parameters:
      
          { "user" => nil }
      
      are transformed into this `params` hash:
      
          { "user" => { "user" => nil } }
      
      and `params["user"]` no longer returns the original parameter value.
      b3966080
  32. 20 6月, 2017 1 次提交
  33. 23 5月, 2017 1 次提交