1. 01 2月, 2018 1 次提交
  2. 30 1月, 2018 1 次提交
    • D
      Allow @ in X-Request-Id header · eea28f41
      Daniel Colson 提交于
      It makes sense to be as strict as possible
      with headers from the outside world,
      but allowing @ to support Apache's mod_unique_id
      (see #31644) seems OK to me
      eea28f41
  3. 26 1月, 2018 4 次提交
  4. 16 1月, 2018 1 次提交
  5. 09 1月, 2018 1 次提交
  6. 30 12月, 2017 1 次提交
  7. 29 12月, 2017 1 次提交
  8. 15 12月, 2017 2 次提交
  9. 14 12月, 2017 1 次提交
  10. 13 12月, 2017 1 次提交
  11. 12 12月, 2017 1 次提交
  12. 10 12月, 2017 2 次提交
  13. 08 12月, 2017 1 次提交
  14. 07 12月, 2017 1 次提交
  15. 06 12月, 2017 1 次提交
  16. 05 12月, 2017 1 次提交
  17. 04 12月, 2017 1 次提交
  18. 29 11月, 2017 4 次提交
  19. 28 11月, 2017 2 次提交
  20. 27 11月, 2017 1 次提交
  21. 20 11月, 2017 1 次提交
  22. 09 11月, 2017 2 次提交
    • N
      Use `Dir.mktmpdir` · 2d5700b9
      Nobuyoshi Nakada 提交于
      As `@cache_path` is expected to be a directory name, use `Dir.mktmpdir`.
      And omit unnecessary `Dir.tmpdir`.
      2d5700b9
    • N
      Use `Tempfile.create` · 4022f334
      Nobuyoshi Nakada 提交于
      Instead of `Dir::Tmpname.make_tmpname`, an internal method which does not guarantee uniqueness, use `Tempfile.create`.
      4022f334
  23. 07 11月, 2017 1 次提交
  24. 04 11月, 2017 1 次提交
  25. 29 10月, 2017 1 次提交
    • N
      Deprecate ActiveSupport::Inflector#acronym_regex · b2545e41
      Nick LaMuro 提交于
      To be removed in Rails 6.0 (default for the deprecate helper).  Code
      moved around as well for the ActiveSupport::Deprecation modules, since
      it was dependent on ActiveSupport::Inflector being loaded for it to
      work.  By "lazy loading" the Inflector code from within the Deprecation
      code, we can require ActiveSupport::Deprecation from
      ActiveSupport::Inflector and not get a circular dependency issue.
      b2545e41
  26. 28 10月, 2017 2 次提交
  27. 26 10月, 2017 1 次提交
  28. 24 10月, 2017 1 次提交
    • N
      Cache regexps generated from acronym_regex · a822fc51
      Nick LaMuro 提交于
      The Problem
      -----------
      
      The following line from `String#camelize`:
      
        string = string.sub(/^(?:#{inflections.acronym_regex}(?=\b|[A-Z_])|\w)/) { |match| match.downcase }
      
      and the following line from `String#camelize`:
      
        word.gsub!(/(?:(?<=([A-Za-z\d]))|\b)(#{inflections.acronym_regex})(?=\b|[^a-z])/) { "#{$1 && '_'.freeze }#{$2.downcase}" }#{$2.downcase}" }
      
      Both generate the same regexep in the first part of the `.sub`/`.gsub`
      method calls every time the function is called, creating an extra object
      allocation each time.  The value of `acronym_regex` only changes if the
      user decides add an acronym to the current set of inflections and apends
      another string on the the regexp generated here, but beyond that it
      remains relatively static.
      
      This has been around since acronym support was introduced back in 2011
      in PR#1648.
      
      Proposed Solution
      -----------------
      To avoid re-generating these strings every time these methods are
      called, cache the values of these regular expressions in the
      `ActiveSupport::Inflector::Inflections` instance, making it so these
      regular expressions are only generated once, or when the acronym's are
      added to.
      
      Other notable changes is the attr_readers are nodoc'd, as they shouldn't
      really be public APIs for users.  Also, the new method,
      define_acronym_regex_patterns, is the only method in charge of
      manipulating @acronym_regex, and initialize_dup also makes use of that
      new change.
      
      ** Note about fix for non-deterministic actionpack test **
      
      With the introduction of `@acronym_underscore_regex` and
      `@acronym_camelize_regex`, tests that manipulated these for a short
      time, then reset them could caused test failures to happen.  This
      happened because the previous way we reset the `@acronyms` and
      `@acronym_regex` was the set them using #instance_variable_set, which
      wouldn't run the #define_acronym_regex_patterns method.
      
      This has now been introduced into the actionpack tests to avoid this
      failure.
      a822fc51
  29. 17 10月, 2017 1 次提交