- 16 9月, 2018 9 次提交
-
-
由 bogdanvlviv 提交于
Also this commit removes `:wait` from payload of `retry_stopped.active_job`. Related to https://github.com/rails/rails/pull/33751#discussion_r214140008 Follow up #33751 /cc @kaspth, @rafaelfranca
-
由 bogdanvlviv 提交于
Add mention about it to the "Active Support Instrumentation" guide Related to https://github.com/rails/rails/pull/33751#discussion_r214745153 Follow up #33751
-
由 Ryuta Kamizono 提交于
ActiveRecord::Associations::Preloader should preload all instances of the same record
-
由 Nikita Sokolov 提交于
-
由 Yuji Yaginuma 提交于
Fix av-ujs build
-
由 yuuji.yaginuma 提交于
The bin shim provides by `chromedriver-helper` gem has renamed to `chromedriver-helper` since 2.0. https://github.com/flavorjones/chromedriver-helper/pull/58 Since bin of new name is set to driver path in `lib/chromedriver-helper.rb`, need to load it.
-
由 yuuji.yaginuma 提交于
-
由 Ryuta Kamizono 提交于
MySQL supports JOINs to UPDATE, so if column name isn't qualified by table name, it would cause an ambiguous error: ``` Mysql2::Error: Column 'integer' in field list is ambiguous: UPDATE `pets` INNER JOIN `toys` ON `toys`.`pet_id` = `pets`.`pet_id` SET `integer` = COALESCE(`integer`, 0) + 1 WHERE `toys`.`name` = ? ```
-
由 Ryuta Kamizono 提交于
`persistence_test.rb` and `relations_test.rb` have too many lines, so I'd like to extract relation around tests to dedicated files before newly test added.
-
- 15 9月, 2018 8 次提交
-
-
由 yuuji.yaginuma 提交于
Get a warning about `async_exec`, but it seems that build has passed through the fix of https://bitbucket.org/ged/ruby-pg/commits/be48d118eeedbf6b6a1f0aa14749ab97fc22065c.
-
由 George Claghorn 提交于
-
由 Ryuta Kamizono 提交于
Fallback to unprepared statement only when bind params limit is exceeded
-
由 yuuji.yaginuma 提交于
Follow up #33883.
-
由 George Claghorn 提交于
Configure Active Storage route prefix
-
由 Lucas Brandt 提交于
* Update association_basics.md [ci skip] Addresses issue #33599 * Update associations.rb API documentation [ci skip] Additional detail for documentation of `belongs_to` `association=(associate)` * Update association_basics.md [ci skip] Reverts misplaced documentation comment
-
由 Ryuta Kamizono 提交于
[ci skip] Fix documentation for Response#content_type
-
由 printercu 提交于
-
- 14 9月, 2018 21 次提交
-
-
由 Chris Bisnett 提交于
Applications can configure the route prefix prepended to the Active Storage routes. By default this maintains the previous prefix `/rails/active_storage` but supports custom prefixes. Before this change the route for serving blobs is fixed to `/rails/active_storage/blobs/:signed_id/*filename`. After this change it's possible to configure the route to something like `/files/blobs/:signed_id/*filename`.
-
由 yuuji.yaginuma 提交于
-
由 Ryuta Kamizono 提交于
Remove mysql2 gem version requirement "< 0.6.0"
-
由 Ryuta Kamizono 提交于
Follow up #33874. Related #23393.
-
由 Yasuo Honda 提交于
Suggested at https://github.com/rails/rails/pull/33876#issuecomment-421176221
-
由 Rafael Mendonça França 提交于
-
由 yuuji.yaginuma 提交于
Currently, PostgreSQL + Ruby 2.5.1 build has failed. https://travis-ci.org/rails/rails/jobs/427502723#L2940-L2942 https://travis-ci.org/rails/rails/jobs/427496382#L2921-L2923 https://travis-ci.org/rails/rails/jobs/427470858#L2921-L2923 This is because PostgreSQL server abnormally terminates when ramfs becomes full. Ref: https://travis-ci.org/rails/rails/jobs/427960998#L7614 This occurs since d54d0c95. In d54d0c95, `sudo` is used in preprocessing for setting MySQL. In Travis, even if specified `sudo: false`, when using `sudo` in build, sudo-enabled infrastructure is used. https://docs.travis-ci.com/user/reference/overview/#virtualisation-environment-vs-operating-system As container-based infrastructure was changed to sudo-enabled infrastructure, the disk settings etc were also changed, it seems that this phenomenon occurred. This can also be handled by extending ramfs(https://github.com/travis-ci/travis-ci/issues/9036#issuecomment-357189213). However, using sudo-enabled in all builds affects the execution time of build, so I think that it is good to use sudo-enabled only in the necessary builds.
-
由 Rafael França 提交于
SQLite3 adapter supports expression indexes
-
由 Ryuta Kamizono 提交于
This is a follow up and/or an alternative of #33844. Unlike #33844, this would attempt to construct unprepared statement only when bind params limit (mysql2 65535, pg 65535, sqlite3 249999) is exceeded. I only defined 65535 as the limit, not defined 249999 for sqlite3, since it is an edge case, I'm not excited to add less worth extra code.
-
由 Ryuta Kamizono 提交于
Bump MySQL version requirement to 5.5.8 in the template files [ci skip]
-
由 Xavier Noria 提交于
Improve API document on Object#blank?
-
由 Yasuo Honda 提交于
Follow-up #33853
-
由 Rafael França 提交于
Conditionally use `helper_method` in Flash concern
-
由 gkemmey 提交于
-
由 Eileen M. Uchitelle 提交于
add `any?` to DatabaseConfigurations
-
由 Rafael Mendonça França 提交于
Allow subclasses to redefine autosave callbacks for associated records
-
由 Greg Molnar 提交于
-
由 Takumasa Ochi 提交于
-
由 Jeremy Daer 提交于
Validate if `utf8mb4` character set and longer index key prefix is supported
-
由 Rafael França 提交于
Update arguments.rb [ci skip]
-
由 Sharang Dashputre 提交于
Fix typo `Instrinsic` -> `Intrinsic`
-
- 13 9月, 2018 2 次提交
-
-
由 Ryuta Kamizono 提交于
Add changelog entries for #33849 [ci skip]
-
由 bogdanvlviv 提交于
Since these changes related to the public API, I think we should add changelog entries. Related to #33838, #33849
-