1. 31 1月, 2015 7 次提交
    • Y
      unify CHANGELOG format. [ci skip] · afe402da
      Yves Senn 提交于
      afe402da
    • G
      Fixed a few things from ee9e4c34 · 33030ea7
      Godfrey Chan 提交于
      Mostly cosmetics, except that `isolate_namespace` should be applied to the last
      module in the chain.
      33030ea7
    • G
      Merge pull request #13601 from robinboening/allow_dashes_in_gem_names · 3bfdad91
      Godfrey Chan 提交于
      Allow hyphenated names for `rails plugin new` generator
      3bfdad91
    • S
      Allow keyword arguments to work with ActiveJob · 31085a5c
      Sean Griffin 提交于
      Unfortunately, the HashWithIndifferent access approach is insufficient
      for our needs. It's perfectly reasonable to want to use keyword
      arguments with Active Job, which we will see as a symbol keyed hash. For
      Ruby to convert this back to keyword arguments, it must deserialize to a
      symbol keyed hash.
      
      There are two primary changes to the serialization behavior. We first
      treat a HWIA separately, and mark it as such so we can convert it back
      into a HWIA during deserialization.
      
      For normal hashes, we keep a list of all symbol keys, and convert them
      back to symbol keys after deserialization.
      
      Fixes #18741.
      31085a5c
    • S
      Remove most type related predicates from `Column` · b93b39ef
      Sean Griffin 提交于
      Remaining are `limit`, `precision`, `scale`, and `type` (the symbol
      version). These will remain on the column, since they mirror the options
      to the `column` method in the schema definition DSL
      b93b39ef
    • S
      Remove most uses of `Column#cast_type` · 155b1b7f
      Sean Griffin 提交于
      The goal is to remove the type object from the column, and remove
      columns from the type casting process entirely. The primary motivation
      for this is clarity. The connection adapter does not have sufficient
      type information, since the type we want to work with might have been
      overriden at the class level. By taking this object from the column,
      it is easy to mistakenly think that the column object which exists on
      the connection adapter is sufficient. It isn't.
      
      A concrete example of this is `serialize`. In 4.2 and earlier, `where`
      worked in a very inconsistent and confusing manner. If you passed a
      single value to `where`, it would serialize it before querying, and do
      the right thing. However, passing it as part of an array, hash, or range
      would cause it to not work. This is because it would stop using prepared
      statements, so the type casting would come from arel. Arel would have no
      choice but to get the column from the connection adapter, which would
      treat it as any other string column, and query for the wrong value.
      
      There are a handful of cases where using the column object to find the
      cast type is appropriate. These are cases where there is not actually a
      class involved, such as the migration DSL, or fixtures. For all other
      cases, the API should be designed as such that the type is provided
      before we get to the connection adapter. (For an example of this, see
      the work done to decorate the arel table object with a type caster, or
      the introduction of `QueryAttribute` to `Relation`).
      
      There are times that it is appropriate to use information from the
      column to change behavior in the connection adapter. These cases are
      when the primitive used to represent that type before it goes to the
      database does not sufficiently express what needs to happen. An example
      of this that affects every adapter is binary vs varchar, where the
      primitive used for both is a string. In this case it is appropriate to
      look at the column object to determine which quoting method to use, as
      this is something schema dependent.
      
      An example of something which would not be appropriate is to look at the
      type and see that it is a datetime, and performing string parsing when
      given a string instead of a date.  This is the type of logic that should
      live entirely on the type. The value which comes out of the type should
      be a sufficiently generic primitive that the adapter can be expected to
      know how to work with it.
      
      The one place that is still using the column for type information which
      should not be necessary is the connection adapter type caster which is
      sometimes given to the arel table when we can't find the associated
      table. This will hopefully go away in the near future.
      155b1b7f
    • S
      Fix a state leak in `autosave_association_test` · dedb946b
      Sean Griffin 提交于
      The test added in 85465ed3 was passing
      when the file was run on its own, but failing when the entire suite was
      run since this test modifies the class and doesn't clean up.
      dedb946b
  2. 30 1月, 2015 20 次提交
  3. 29 1月, 2015 13 次提交