with dynamic conditions.

Fixes #16128

This bug was introduced in https://github.com/rails/rails/commit/c35e438620f2d56562251571377995359546393d
so it's present from 4.1.2-rc1 and after.

https://github.com/rails/rails/commit/c35e438620f2d56562251571377995359546393d
merges any relation scopes passed as proc objects to the relation,
but does *not* take into account the arity of the lambda.

To reproduce: https://gist.github.com/Agis-/5f1f0d664d2cd08dfb9b

`strip_heredoc` method is defined on active_support/core_ext/string

[ci skip] config.active_record.errors_in_transactional_callbacks -> config.active_record.raise_in_transactional_callbacks

Make sure :checkout_timeout and :dead_connection_timeout are numbers
Conflicts:
	activerecord/lib/active_record/connection_adapters/abstract/connection_pool.rb

The instance var is already saved as a string in the initialization
method of AssociationReflection.

See https://github.com/rails/rails/blob/master/activerecord/lib/active_record/reflection.rb#L273

Fixes #15821.

Currently, Active Record will rescue any errors raised within
after_rollback/after_create callbacks and print them to the
logs. Next versions of rails will not rescue those errors anymore,
and just bubble them up, as the other callbacks.

This adds a opt-in flag to enable that behaviour, of not rescuing
the errors.
    Example:
      # For not swallow errors in after_commit/after_rollback
      config.active_record.errors_in_transactional_callbacks = true

[fixes #13460]

If the request parameters are passed to create_with and where they can
be used to do mass assignment when used in combination with
Relation#create.

Fixes CVE-2014-3514

Conflicts:
	activerecord/lib/active_record/relation/query_methods.rb

  Post.where(id: [[]]).to_a

Used to fail with a SQL syntax error (until 4.1):

  SELECT ... WHERE id in ();

It now properly generate:

  SELECT ... WHERE 1=0;

WARNING: don't use them! They might change or go away between future beta/RC/
patch releases!

Also added a CHANGELOG entry for this.

after_commit should not run in nested transactions, however they should
run once the outermost transaction gets committed. This patch fixes the
problem copying the records from the Savepoint to its parent. So the
RealTransaction will have all records that needs to run callbacks on it.

[fixes #16425]

Use `commit_transaction`/`rollback_transaction` on
`within_new_transaction` method, so they make sure they `pop` the
transaction from the stack before calling the methods `commit`/`rollback`.

This was a small self contained piece of the refactoring that I am
working on, which required these objects to be comparable.

Follow up to the discussion on #16505.

I've been trying to reduce the number of places that care about
`attributes`, and its existence. We have a method for this check, let's
use it instead.

Looks like #first wasn't warm enough...

Example:

  Author.where(posts: { author_id: Author.where(country_id: 1) }).joins(:posts)

Or some tests fail when run in random order