- 21 8月, 2020 1 次提交
-
-
由 Chirag 提交于
-
- 19 8月, 2020 1 次提交
-
-
由 Petrik 提交于
-
- 04 8月, 2020 2 次提交
-
-
由 Eugene Kenny 提交于
These formats were added in c329d323 and bcf370d6, respectively.
-
由 fatkodima 提交于
-
- 02 8月, 2020 1 次提交
-
-
由 Jonathan Hefner 提交于
Mentioning the baseline default for a config option can be confusing when that default is overridden by `config.load_defaults`. To avoid that confusion, this commit relocates such baseline defaults from their explanatory paragraphs to a "Baseline defaults" section that flows with the other `config.load_defaults` sections. Ideally, when we override other baseline defaults in the future, we will relocate mention of them as done here. Closes #39387.
-
- 13 7月, 2020 1 次提交
-
-
由 Eugene Kenny 提交于
-
- 08 7月, 2020 1 次提交
-
-
由 Jared Beck 提交于
-
- 06 7月, 2020 1 次提交
-
-
由 Guo Xiang Tan 提交于
308 status code introduced in https://tools.ietf.org/html/rfc7538 preserves the request method unlike 301 status code which would convert POST requests to GET.
-
- 15 6月, 2020 1 次提交
-
-
由 Gannon McGibbon 提交于
-
- 12 6月, 2020 1 次提交
-
-
由 Vipul A M 提交于
Fix broken references to classic mode guide where possible and use new guide where appropriate (#39603) [ci skip]
-
- 11 6月, 2020 1 次提交
-
-
由 Étienne Barrié 提交于
This allows applications to safely upgrade to Rails 6.1 without breaking tokens while the deploy is still being rolled out.
-
- 01 6月, 2020 2 次提交
-
-
由 Eugene Kenny 提交于
-
由 bogdanvlviv 提交于
Add `ActiveRecord::Base.strict_loading_by_default` and `ActiveRecord::Base.strict_loading_by_default=`. This will allow to enable/disable strict_loading mode by default for a model. The configuration's value is inheritable by subclasses, but they can override that value and it will not impact parent class: ```ruby class Developer < ApplicationRecord self.strict_loading_by_default = true has_many :projects end dev = Developer.first dev.projects.first \# => ActiveRecord::StrictLoadingViolationError Exception: Developer is marked as strict_loading and Project cannot be lazily loaded. ``` What is great about this feature that it could help users to nip N+1 queries in the bud, especially for fresh applications, by setting `ActiveRecord::Base.strict_loading_by_default = true` / `config.active_record.strict_loading_by_default = true`. That is also a great way to prevent new N+1 queries in the existing applications after all the N+1 queries are eliminated. (See https://guides.rubyonrails.org/v6.0/active_record_querying.html#eager-loading-associations, https://github.com/seejohnrun/prelude for details on how to fight against N+1 queries). Related to https://github.com/rails/rails/pull/37400, https://github.com/rails/rails/pull/38541
-
- 28 5月, 2020 1 次提交
-
-
由 Eugene Kenny 提交于
The point of new framework defaults is that they're opt-in for upgraded applications, but the default for this option applied the new behaviour.
-
- 20 5月, 2020 1 次提交
-
-
由 fatkodima 提交于
-
- 19 5月, 2020 1 次提交
-
-
由 Prathamesh Sonpatki 提交于
- Add the configuration option for annotating templates with file names to the generated app. - Add `annotate_rendered_view_with_filenames` option to configuring guide.
-
- 13 5月, 2020 1 次提交
-
-
由 eileencodes 提交于
Revert "Remove deprecated `ActionMailer::DeliveryJob` and `ActionMailer::Parameterized::DeliveryJob`" This reverts commit 0f9249c9. Reverted because this wasn't warning in custom jobs and therefore applications may have not seen the deprecation. We'll need to fix the deprecation to warn for custom jobs so that applications can migrate.
-
- 12 5月, 2020 1 次提交
-
-
由 Jonathan Fleckenstein 提交于
-
- 08 5月, 2020 1 次提交
-
-
由 jean-francois labbe 提交于
Co-authored-by: NJonathan Hefner <jonathan@hefner.pro>
-
- 05 5月, 2020 2 次提交
-
-
由 Ryuta Kamizono 提交于
-
由 Rafael Mendonça França 提交于
-
- 01 5月, 2020 1 次提交
-
-
由 Alberto Almagro 提交于
37913 added the possibility to deeply merge configurations by grouping them within a shared section. This powerful alternative was not reflected in any documentation, which made my team think it was not possible until I found out this feature after looking at the source code. This patch reflects this change in the documentation so that it is easier for other developers to know about this behavior.
-
- 22 4月, 2020 1 次提交
-
-
由 JvH 提交于
Add `config.active_storage.web_image_content_types` to allow applications to add content types (like `image/webp`) in which variants can be processed, instead of letting those images be converted to the fallback PNG format.
-
- 17 4月, 2020 1 次提交
-
-
由 Nick Burns 提交于
Co-Authored-By: NEileen M. Uchitelle <eileencodes@users.noreply.github.com>
-
- 12 4月, 2020 1 次提交
-
-
由 Haroon Ahmed 提交于
-
- 06 4月, 2020 2 次提交
-
-
由 Abhay Nikam 提交于
-
由 Jonathan Hefner 提交于
`url_for` will now use "https://" as the default protocol when `Rails.application.config.force_ssl` is set to true. Action Mailer already behaves this way, effectively. This commit extends that behavior application-wide. Closes #23543.
-
- 04 4月, 2020 1 次提交
-
-
由 Nick Burns 提交于
- adds the option `metadata_table` to a database connection
-
- 30 3月, 2020 1 次提交
-
-
由 David Heinemeier Hansson 提交于
* require, require_relative, load by double quotes We're getting rid of all single quote usage, unless it serves a specific purpose, as per the general style guide.
-
- 11 3月, 2020 1 次提交
-
-
由 Dino Maric 提交于
This PR adds `image/webp` to the default array of variable content types. Without this commit if we want to "handle" webp images overwriting `config.active_storage.variable_content_types` was necessary.
-
- 16 1月, 2020 1 次提交
-
-
由 Cliff Pruitt 提交于
This allows deprecation messages to be matched by substring, symbol (treated as substring), or regular expression. If a warning is matched, the behaviors configured for disallowed deprecations will be used. The default behavior for disallowed deprecation warnings is `:raise`. Also adds `ActiveSupport::Deprecation.allow` for thread-local, block level ignoring of deprecation warnings which would otherwise be disallowed by ActiveSupport::Deprecation.disallowed_warnings.
-
- 08 1月, 2020 1 次提交
-
-
由 Genadi Samokovarov 提交于
While trying to fix #16433, we made the middleware deletions always happen at the end. While this works for the case of deleting the Rack::Runtime middleware, it makes operations like the following misbehave. ```ruby gem "bundler", "< 1.16" begin require "bundler/inline" rescue LoadError => e $stderr.puts "Bundler version 1.10 or later is required. Please update your Bundler" raise e end gemfile(true) do source "https://rubygems.org" git_source(:github) { |repo| "https://github.com/#{repo}.git" } gem "rails", github: "rails/rails" end require "action_controller/railtie" class TestApp < Rails::Application config.root = __dir__ secrets.secret_key_base = "secret_key_base" config.logger = Logger.new($stdout) Rails.logger = config.logger middleware.insert_after ActionDispatch::Session::CookieStore, ::Rails::Rack::Logger, config.log_tags middleware.delete ::Rails::Rack::Logger end require "minitest/autorun" require "rack/test" class BugTest < Minitest::Test include Rack::Test::Methods def test_returns_success get "/" assert last_response.ok? end private def app Rails.application end end ``` In the case
☝ ️ the ::Rails::Rack::Logger would be deleted instead of moved, because the order of middleware stack building execution will be: ```ruby [:insert, ActionDispatch::Session::CookieStore, [::Rails::Rack::Logger]] [:delete, ::Rails::Rack::Logger, [config.log_tags]] ``` This is pretty surprising and hard to reason about behaviour, unless you go spelunking into the Rails configuration code. I have a few solutions in mind and all of them have their drawbacks. 1. Introduce a `Rails::Configuration::MiddlewareStackProxy#delete!` that delays the deleted operations. This will make `#delete` to be executed in order. The drawback here is backwards incompatible behavior and a new public method. 2. Just revert to the old operations. This won't allow people to delete the `Rack::Runtime` middleware. 3. Legitimize the middleware moving with the new `#move_after` and `#move_before` methods. This does not breaks any backwards compatibility, but includes 2 new methods to the middleware stack. I have implemented `3.` in this pull request. Happy holidays!🎄
-
- 02 1月, 2020 1 次提交
-
-
由 bogdanvlviv 提交于
This commit copies info from https://github.com/rails/rails/pull/33145 ([an excellent changelog](https://github.com/rails/rails/blob/6-0-stable/railties/CHANGELOG.md)) to our guides. Closes https://github.com/rails/rails/issues/36959 Not sure whether there is a need mentioning `config.hosts` in the "Upgrading to Rails 6.0" guide since it is configured to work in the development environment by default and we guide how to deal with "blocked host" issue, see: https://github.com/rails/rails/blob/6-0-stable/actionpack/lib/action_dispatch/middleware/templates/rescues/blocked_host.html.erb I would like to backport this to `6-0-stable` so users will be able to find info about `ActionDispatch::HostAuthorization` middleware and how to configure it. Give credit to @gsamokovarov since I copied the info from the changelog. <3 [bogdanvlviv, Genadi Samokovarov]
-
- 28 12月, 2019 1 次提交
-
-
由 Haroon Ahmed 提交于
-
- 23 12月, 2019 1 次提交
-
-
由 Petrik 提交于
According to the guide guidelines, all words except for prepositions, conjunctions, internal articles, and forms of the verb "to be" should be capitalized. This commit fixes some titles.
-
- 18 12月, 2019 1 次提交
-
-
由 Petrik 提交于
Some code examples were missing the language used for code highlighting.
-
- 13 12月, 2019 1 次提交
-
-
由 Kasper Timm Hansen 提交于
-
- 11 12月, 2019 1 次提交
-
-
由 Cliff Pruitt 提交于
-
- 07 12月, 2019 1 次提交
-
-
由 George Claghorn 提交于
-
- 03 12月, 2019 1 次提交
-
-
由 Peter Zhu 提交于
-