1. 23 12月, 2015 1 次提交
  2. 17 12月, 2015 3 次提交
  3. 30 11月, 2015 1 次提交
  4. 29 11月, 2015 1 次提交
  5. 27 11月, 2015 1 次提交
  6. 26 11月, 2015 1 次提交
  7. 24 11月, 2015 1 次提交
  8. 20 11月, 2015 2 次提交
    • S
      Revert "Allow specifying the default table options for mysql adapters" · 6b7861e8
      Sean Griffin 提交于
      This reverts commit 8246b593.
      
      There was concern about this modifying the behavior of past migrations.
      We're going to add an way to modify the migration generator instead.
      6b7861e8
    • S
      Allow specifying the default table options for mysql adapters · 8246b593
      Sean Griffin 提交于
      It's often the case that you want to have an option that you cannot
      specify at the database level, but want applied to *all* tables that you
      create. For example, you might want to specify `ROW_FORMAT=DYNAMIC` to
      not have to limit text columns to length 171 for indexing when using
      utf8mb4. This allows an easy way to specify this in your database
      configuration.
      
      While this change affects both MySQL and MySQL2, the test only covers
      MySQL2, as the legacy mysql adapter appears to always return ASCII
      strings, and is tangential to what we're actually doing.
      8246b593
  9. 18 11月, 2015 1 次提交
    • S
      Rename 'key' to 'lock_id' or 'lock_name' for advisory locking · 5ce21d4f
      Sam Davies 提交于
      - key was a poor choice of name. A key implies something that will
        unlock a lock. The concept is actually more like a 'lock identifier'
      - mysql documentation calls this a 'lock name'
      - postgres documentation calls it a 'lock_id'
      - Updated variable names to reflect the preferred terminology for the database in
        question
      5ce21d4f
  10. 16 11月, 2015 1 次提交
  11. 09 11月, 2015 1 次提交
    • Y
      Deprecate `#table_exists?`, `#tables` and passing arguments to `#talbes` · 7429633b
      yui-knk 提交于
      Reported on #21509, how views is treated by `#tables` are differ
      by each adapters. To fix this different behavior, after Rails 5.0
      is released, deprecate `#tables`.
      
      And `#table_exists?` would check both tables and views.
      To make their behavior consistent with `#tables`, after Rails 5.0
      is released, deprecate `#table_exists?`.
      7429633b
  12. 08 11月, 2015 1 次提交
  13. 03 11月, 2015 1 次提交
  14. 31 10月, 2015 1 次提交
    • S
      Use advisory locks to prevent concurrent migrations · 2c2a8755
      Sam Davies 提交于
      - Addresses issue #22092
      - Works on Postgres and MySQL
      - Uses advisory locks because of two important properties:
        1. The can be obtained outside of the context of a transaction
        2. They are automatically released when the session ends, so if a
        migration process crashed for whatever reason the lock is not left
        open perpetually
      - Adds get_advisory_lock and release_advisory_lock methods to database
        adapters
      - Attempting to run a migration while another one is in process will
        raise a ConcurrentMigrationError instead of attempting to run in
        parallel with undefined behavior. This could be rescued and
        the migration could exit cleanly instead. Perhaps as a configuration
        option?
      
      Technical Notes
      ==============
      
      The Migrator uses generate_migrator_advisory_lock_key to build the key
      for the lock. In order to be compatible across multiple adapters there
      are some constraints on this key.
      - Postgres limits us to 64 bit signed integers
      - MySQL advisory locks are server-wide so we have to scope to the
        database
      - To fulfil these requirements we use a Migrator salt (a randomly
        chosen signed integer with max length of 31 bits) that identifies
        the Rails migration process as the owner of the lock. We multiply
        this salt with a CRC32 unsigned integer hash of the database name to
        get a signed 64 bit integer that can also be converted to a string
        to act as a lock key in MySQL databases.
      - It is important for subsequent versions of the Migrator to use the
        same salt, otherwise different versions of the Migrator will not see
        each other's locks.
      2c2a8755
  15. 22 10月, 2015 1 次提交
    • R
      Remove `#tables` extra args again · edfb738b
      Ryuta Kamizono 提交于
      This issue was resolved by #21687 already. But re-add args by #18856.
      `#tables` extra args was only using by `#table_exists?`. This is for
      internal API. This commit will remove these extra args again.
      edfb738b
  16. 21 10月, 2015 1 次提交
    • S
      Do not cache prepared statements that are unlikely to have cache hits · cbcdecd2
      Sean Griffin 提交于
      Prior to this commit, Rails makes no differentiation between whether a
      query uses bind parameters, and whether or not we cache that query as a
      prepared statement. This leads to the cache populating extremely fast in
      some cases, with the statements never being reused.
      
      In particular, the two problematic cases are `where(foo: [1, 2, 3])` and
      `where("foo = ?", 1)`. In both cases we'll end up quoting the values
      rather than using a bind param, causing a cache entry for every value
      ever used in that query.
      
      It was noted that we can probably eventually change `where("foo = ?",
      1)` to use a bind param, which would resolve that case. Additionally, on
      PG we can change our generated query to be `WHERE foo = ANY($1)`, and
      pass an array for the bind param. I hope to accomplish both in the
      future.
      
      For SQLite and MySQL, we still end up preparing the statements anyway,
      we just don't cache it. The statement will be cleaned up after it is
      executed. On postgres, we skip the prepare step entirely, as an API is
      provided to execute with bind params without preparing the statement.
      
      I'm not 100% happy on the way this ended up being structured. I was
      hoping to use a decorator on the visitor, rather than mixing a module
      into the object, but the way Arel has it's visitor pattern set up makes
      it very difficult to extend without inheritance. I'd like to remove the
      duplication from the various places that are extending it, but that'll
      require a larger restructuring of that initialization logic. I'm going
      to take another look at the structure of it soon.
      
      This changes the signature of one of the adapter's internals, and will
      require downstream changes from third party adapters. I'm not too
      worried about this, as worst case they can simply add the parameter and
      always ignore it, and just keep their previous behavior.
      
      Fixes #21992.
      cbcdecd2
  17. 15 10月, 2015 2 次提交
  18. 13 10月, 2015 1 次提交
  19. 11 10月, 2015 2 次提交
  20. 08 10月, 2015 1 次提交
  21. 04 10月, 2015 1 次提交
  22. 23 9月, 2015 1 次提交
    • Y
      introduce `conn.data_source_exists?` and `conn.data_sources`. · 152b85f0
      Yves Senn 提交于
      These new methods are used from the Active Record model layer to
      determine which relations are viable to back a model. These new methods
      allow us to change `conn.tables` in the future to only return tables and
      no views. Same for `conn.table_exists?`.
      
      The goal is to provide the following introspection methods on the
      connection:
      
      * `tables`
      * `table_exists?`
      * `views`
      * `view_exists?`
      * `data_sources` (views + tables)
      * `data_source_exists?` (views + tables)
      152b85f0
  23. 20 9月, 2015 2 次提交
  24. 18 9月, 2015 3 次提交
    • R
      Reduce the calling `create_table_info` query · b8bedfa2
      Ryuta Kamizono 提交于
      Currently in schema dumping, `create_table_info` query is called twice
      for each tables. It means if 100 tables exists, the query is called 200
      times. This change is that the query is called once for each tables in
      schema dumping.
      b8bedfa2
    • R
      Add `unsigned` types for numeric data types in MySQL · dfeb3ee7
      Ryuta Kamizono 提交于
      In the case of using `unsigned` as the type:
      
          create_table :foos do |t|
            t.unsigned_integer :unsigned_integer
            t.unsigned_bigint  :unsigned_bigint
            t.unsigned_float   :unsigned_float
            t.unsigned_decimal :unsigned_decimal, precision: 10, scale: 2
          end
      dfeb3ee7
    • R
      Add `unsigned` support for numeric data types in MySQL · f3772f72
      Ryuta Kamizono 提交于
      Example:
      
          create_table :foos do |t|
            t.integer :unsigned_integer, unsigned: true
            t.bigint  :unsigned_bigint,  unsigned: true
            t.float   :unsigned_float,   unsigned: true
            t.decimal :unsigned_decimal, unsigned: true, precision: 10, scale: 2
          end
      f3772f72
  25. 16 9月, 2015 2 次提交
  26. 13 9月, 2015 1 次提交
  27. 11 9月, 2015 1 次提交
  28. 10 9月, 2015 1 次提交
  29. 01 9月, 2015 1 次提交
  30. 22 8月, 2015 1 次提交
    • S
      JSON is still an adapter specific type. · ffc4710c
      Sean Griffin 提交于
      Several changes were made in #21110 which I am strongly opposed to.
      (this is what I get for going on vacation. :trollface:) No type should
      be introduced into the generic `ActiveRecord::Type` namespace, and
      *certainly* should not be registered into the registry unconstrained
      unless it is supported by *all* adapters (which basically means that it
      was specified in the ANSI SQL standard).
      
      I do not think `# :nodoc:` ing the type is sufficient, as it still makes
      the code of Rails itself very unclear as to what the role of that class
      is. While I would argue that this shouldn't even be a super class, and
      that MySql and PG's JSON types are only superficially duplicated (they
      might look the same but will change for different reasons in the
      future).
      
      However, I don't feel strongly enough about it as a point of contention
      (and the biggest cost of harming the blameability has already occured),
      so I simply moved the superclass into a namespace where its role is
      absolutely clear.
      
      After this change, `attribute :foo, :json` will once again work with
      MySQL and PG, but not with Sqlite3 or any third party adapters.
      
      Unresolved questions
      --------------------
      
      The types that and adapter publishes (at least those are unique to that
      adapter, and not adding additional behavior like `MysqlString` should
      probably be part of the adapter's public API. Should we standardize the
      namespace for these, and document them?
      ffc4710c
  31. 21 8月, 2015 1 次提交