- 23 12月, 2015 1 次提交
-
-
由 Ryuta Kamizono 提交于
Follow up to #19359 and avoid #22241.
-
- 19 12月, 2015 29 次提交
-
-
由 Ryuta Kamizono 提交于
Fix `test_find_with_order_on_included_associations_with_construct_finder_sql_for_association_limiting_and_is_distinct` to NULL-agnostic way The sort order of NULL depends on the RDBS implementation. This commit is to fix the test to NULL-agnostic way. Example: ``` activerecord_unittest=# SELECT DISTINCT "posts"."id", author_addresses_authors.id AS alias_0 FROM "posts" LEFT OUTER JOIN "authors" ON "authors"."id" = "posts"."author_id" LEFT OUTER JOIN "author_addresses" ON "author_addresses"."id" = "authors"."author_address_id" LEFT OUTER JOIN "categorizations" ON "categorizations"."category_id" = "posts"."id" LEFT OUTER JOIN "authors" "authors_posts" ON "authors_posts"."id" = "categorizations"."author_id" LEFT OUTER JOIN "author_addresses" "author_addresses_authors" ON "author_addresses_authors"."id" = "authors_posts"."author_address_id" ORDER BY author_addresses_authors.id DESC; id | alias_0 ----+--------- 1 | 2 | 3 | 4 | 5 | 6 | 7 | 8 | 9 | 10 | 11 | 1 | 1 (12 rows) ``` ``` root@localhost [activerecord_unittest] > SELECT DISTINCT `posts`.`id`, author_addresses_authors.id AS alias_0 FROM `posts` LEFT OUTER JOIN `authors` ON `authors`.`id` = `posts`.`author_id` LEFT OUTER JOIN `author_addresses` ON `author_addresses`.`id` = `authors`.`author_address_id` LEFT OUTER JOIN `categorizations` ON `categorizations`.`category_id` = `posts`.`id` LEFT OUTER JOIN `authors` `authors_posts` ON `authors_posts`.`id` = `categorizations`.`author_id` LEFT OUTER JOIN `author_addresses` `author_addresses_authors` ON `author_addresses_authors`.`id` = `authors_posts`.`author_address_id` ORDER BY author_addresses_authors.id DESC; +----+---------+ | id | alias_0 | +----+---------+ | 1 | 1 | | 3 | NULL | | 1 | NULL | | 2 | NULL | | 4 | NULL | | 5 | NULL | | 6 | NULL | | 7 | NULL | | 8 | NULL | | 9 | NULL | | 10 | NULL | | 11 | NULL | +----+---------+ 12 rows in set (0.00 sec) ```
-
由 Akira Matsuda 提交于
Also, added a test case to make sure that the default deprecation horizon is always bigger than the current Rails version.
-
由 Guillermo Iguaran 提交于
Remove .DS_Store
-
由 Satoshi Ohmori 提交于
-
由 Kasper Timm Hansen 提交于
Fix cache fetch miss notification order
-
由 Richard Schneeman 提交于
Add No Doc
-
由 Richard Schneeman 提交于
Remove blank line generated in config.ru
-
由 Guillermo Iguaran 提交于
[ActionCable] declare asset_logged private
-
由 Guillermo Iguaran 提交于
Explain what initializer/config_serializer does
-
由 claudiob 提交于
Follow the lines of the other `.tt` files ([example](https://github.com/rails/rails/blob/1611ab4db173a7596a7a94c58dabf1483f070304/railties/lib/rails/generators/rails/app/templates/config/environments/development.rb.tt#L26)) that have the space after the condition to avoid too many white lines in the resulted file.
-
由 Cory Gwin 提交于
In reference to rails/rail#22403 add a :nodoc:
-
由 claudiob 提交于
In line with the other initializers, add a short comment that explains what happens when you change the value of the initializer. [ci skip]
-
由 Claudio B 提交于
initializers/cookies_serializer is not new to 5.0
-
由 claudiob 提交于
[ci skip] The initializer has existed since 4.1, for instance see: https://github.com/rails/rails/blob/v4.1.0/railties/lib/rails/generators/rails/app/templates/config/initializers/cookies_serializer.rb
-
由 Aaron Patterson 提交于
Merge pull request #19423 from yuroyoro/fix_performance_regression_of_preloading_has_many_through_relation Fix #12537 performance regression when preloading has_many_through association
-
由 Sean Griffin 提交于
fix typo in config value [ci skip]
-
由 yuuji.yaginuma 提交于
-
由 Akshay Vishnoi 提交于
-
由 Rafael França 提交于
Fix typo in CHANGELOG
-
由 Jan 提交于
-
由 eileencodes 提交于
-
由 Rafael França 提交于
wrapping i18n missing keys made optional
-
由 Sameer Rahmani 提交于
`I18n.translate` helper will wrap the missing translation keys in a <span> tag only if `debug_missing_translation` configuration has a truthy value. Default value is `true`. For example in `application.rb`: # in order to turn off missing key wrapping config.action_view.debug_missing_translation = false
-
由 eileencodes 提交于
🎉 🍻 -
由 Rafael Mendonça França 提交于
-
由 Kasper Timm Hansen 提交于
Fix `receive` spelling
-
由 Matthew Draper 提交于
Handle specified schemas when removing a Postgres index
-
由 Ryo Hashimoto 提交于
-
由 Rafael França 提交于
[ActionCable] Test invalid action on channel
-
- 18 12月, 2015 10 次提交
-
-
由 Kasper Timm Hansen 提交于
Found `recieve` next to the correctly spelled method name, fixed it. Also we prefer a one space padding within hashes, add that.
-
由 Akshay Vishnoi 提交于
-
由 Rafael França 提交于
[ActionCable] test perform action with default action
-
由 eileencodes 提交于
This test needs to have a require for the Listen gem or else it returns an error when run by itself or with a certain order in the Active Support tests. We use `silence_warnings` because Listen has some warnings about private methods. It's already silenced when it's required in Active Support EventedFileUpdateChecker. ``` 1) Error: EventedFileUpdateCheckerTest#test_should_not_execute_the_block_if_no_paths_are_given: NameError: uninitialized constant EventedFileUpdateCheckerTest::Listen test/evented_file_update_checker_test.rb:21:in `teardown' ```
-
由 eileencodes 提交于
The test was was in here twice so we were seeing this error: ``` activesupport/test/caching_test.rb:658: warning: method redefined; discarding old test_local_cache_of_read_nil activesupport/test/caching_test.rb:634: warning: previous definition of test_local_cache_of_read_nil was here ```
-
由 Rafael Mendonça França 提交于
-
由 Akshay Vishnoi 提交于
-
由 Rafael França 提交于
Fix "instance variable not initialized" in tests
-
由 Rafael França 提交于
Prevent ActionController::Parameters in url_for
-
由 Rafael França 提交于
add line break between method of generated channel js
-