- 03 11月, 2014 5 次提交
-
-
由 Sean Griffin 提交于
-
由 Sean Griffin 提交于
We should not behave differently just because a class has a default scope.
-
由 Sean Griffin 提交于
This method is still used by `update_all`
-
由 Sean Griffin 提交于
These appear to be implementation relics of times past. They duplicate the logic in Relation, and are no longer used internally.
-
由 Sean Griffin 提交于
Arel specifically handles `SelectManager`, with the same logic we're currently performing. The AST is `Enumerable`, which Arel looks for separately now.
-
- 02 11月, 2014 20 次提交
-
-
由 Robin Dupret 提交于
-
由 Zachary Scott 提交于
added punctuations, and role of queue_adapter module [ci skip]
-
由 Sean Griffin 提交于
Call gsub with a Regexp instead of a String for better performance
-
由 Sean Griffin 提交于
-
由 Sean Griffin 提交于
We support this behavior, but have no tests which assert that type casting actually occurs.
-
由 Sean Griffin 提交于
We need to re-order the bind parameters since the AST returned by the relation will have the where statement as the first bp, which breaks on PG.
-
由 Pablo Herrero 提交于
-
由 Sean Griffin 提交于
MySQL reports the column name as `"MAX(developer_id)"`. PG will report it as `"max"`
-
由 Zachary Scott 提交于
Add link to API Documentation Guidelines [ci skip]
-
由 Dave Powers 提交于
Link to the "English" section to specify American English be used for the Guides [ci skip]
-
由 Sean Griffin 提交于
-
由 Sean Griffin 提交于
It was transitively relying on the vertex model being loaded
-
由 Sean Griffin 提交于
In practical terms, this allows serialized columns and tz aware columns to be used in wheres that go through joins, where they previously would not behave correctly. Internally, this removes 1/3 of the cases where we rely on Arel to perform type casting for us. There were two non-obvious changes required for this. `update_all` on relation was merging its bind values with arel's in the wrong order. Additionally, through associations were assuming there would be no bind parameters in the preloader (presumably because the where would always be part of a join) [Melanie Gilman & Sean Griffin]
-
由 Sean Griffin 提交于
Remove redundant substitute index when constructing bind values
-
由 Richard Schneeman 提交于
Remove redundant require of file
-
由 Sean Griffin 提交于
This slightly simplifies the code, and reduces the number of times we need to iterate over the attributes by one.
-
由 Adam89 提交于
This file was required inside 'test/validators/namespace/email_validator.rb' that's already required here. Therefore I removed the redundant required.
-
由 Robin Dupret 提交于
[ci skip]
-
由 Rafael Mendonça França 提交于
add missing space.[ci skip]
-
由 Kuldeep Aggarwal 提交于
-
- 01 11月, 2014 15 次提交
-
-
由 Rishi Jain 提交于
-
由 Zachary Scott 提交于
[ci skip] Fix line break on asset pipeline guide
-
由 Cakey | Buddy Magsipoc 提交于
fixes this : ![http://i.imgur.com/86scI3a.png](http://i.imgur.com/86scI3a.png))
-
由 Aaron Patterson 提交于
-
由 Aaron Patterson 提交于
-
由 Joe Rafaniello 提交于
Skip setting sequence on a table create if the value is 0 since it will start the first value at 1 anyway. This fixes the PG error 'setval: value 0 is out of bounds for sequence vms_id_seq...' encountered when migrating a new DB. BugzID: 15452,9772,13475,16850
-
由 Melanie Gilman 提交于
We end up re-ordering them either way when we construct the Arel AST (in order to deal with rewhere, etc), so we shouldn't bother giving it a number in the first place beforehand.
-
由 Rishi Jain 提交于
-
由 Sean Griffin 提交于
-
由 Sean Griffin 提交于
Nothing is directly using the columns for the default values anymore. This step helps us get closer not not mutating the columns hash.
-
由 Sean Griffin 提交于
Fixes #17170
-
由 Rafael Mendonça França 提交于
Explicit route test class
-
由 Rafael Mendonça França 提交于
Merge pull request #17305 from ziggythehamster/activerecord-connectionhandling-RAILS_ENV-without-rails If Rails is not defined, check ENV["RAILS_ENV"] and ENV["RACK_ENV"] in ActiveRecord::ConnectionHandling
-
由 Rafael Mendonça França 提交于
AM README fixes [ci skip]
-
由 Vipul A M 提交于
- Wrapped text in setting defaults section. Also added break, to a sentence. [ci skip]
-