1. 26 1月, 2018 5 次提交
  2. 25 1月, 2018 4 次提交
  3. 24 1月, 2018 3 次提交
  4. 23 1月, 2018 3 次提交
    • R
      Fix building has_one through record · 7ca3ab41
      Ryuta Kamizono 提交于
      Fixes #31762.
      7ca3ab41
    • F
      Support for PostgreSQL foreign tables · 3ad2f992
      fatkodima 提交于
      3ad2f992
    • E
      Build a multi-statement query when inserting fixtures: · 22a26d24
      Edouard CHIN 提交于
      - The `insert_fixtures` method can be optimized by making a single multi statement query for all fixtures having the same connection instead of doing a single query per table
        - The previous code was bulk inserting fixtures for a single table, making X query for X fixture files
        - This patch builds a single **multi statement query** for every tables. Given a set of 3 fixtures (authors, dogs, computers):
        ```ruby
          # before
          %w(authors dogs computers).each do |table|
            sql = build_sql(table)
            connection.query(sql)
          end
      
          # after
      
          sql = build_sql(authors, dogs, computers)
          connection.query(sql)
        ```
      - `insert_fixtures` is now deprecated, `insert_fixtures_set` is the new way to go with performance improvement
      - My tests were done with an app having more than 700 fixtures, the time it takes to insert all of them was around 15s. Using a single multi statement query, it took on average of 8 seconds
      - In order for a multi statement to be executed, mysql needs to be connected with the `MULTI_STATEMENTS` [flag](https://dev.mysql.com/doc/refman/5.7/en/c-api-multiple-queries.html), which is done before inserting the fixtures by reconnecting to da the database with the flag declared. Reconnecting to the database creates some caveats:
        1. We loose all open transactions; Inside the original code, when inserting fixtures, a transaction is open. Multple delete statements are [executed](https://github.com/rails/rails/blob/a681eaf22955734c142609961a6d71746cfa0583/activerecord/lib/active_record/fixtures.rb#L566) and finally the fixtures are inserted. The problem with this patch is that we need to open the transaction only after we reconnect to the DB otherwise reconnecting drops the open transaction which doesn't commit all delete statements and inserting fixtures doesn't work since we duplicated them (Primary key duplicate exception)...
          - In order to fix this problem, the transaction is now open directly inside the `insert_fixtures` method, right after we reconnect to the db
          - As an effect, since the transaction is open inside the `insert_fixtures` method, the DELETE statements need to be executed here since the transaction is open later
        2. The same problem happens for the `disable_referential_integrity` since we reconnect, the `FOREIGN_KEY_CHECKS` is reset to the original value
          - Same solution as 1. , the disable_referential_integrity can be called after we reconnect to the transaction
        3. When the multi statement query is executed, no other queries can be performed until we paginate over the set of results, otherwise mysql throws a "Commands out of sync" [Ref](https://dev.mysql.com/doc/refman/5.7/en/commands-out-of-sync.html)
          - Iterating over the set of results until `mysql_client.next_result` is false. [Ref](https://github.com/brianmario/mysql2#multiple-result-sets)
      - Removed the `active_record.sql "Fixture delete"` notification, the delete statements are now inside the INSERT's one
      - On mysql the `max_allowed_packet` is looked up:
        1. Before executing the multi-statements query, we check the packet length of each statements, if the packet is bigger than the max_allowed_packet config, an `ActiveRecordError` is raised
        2. Otherwise we concatenate the current sql statement into the previous and so on until the packet is `< max_allowed_packet`
      22a26d24
  5. 22 1月, 2018 1 次提交
    • L
      Ignores a default subclass when `becomes(Parent)` · 35623316
      Leonel Galan 提交于
      Fixes issue described in #30399: A default value on the
      inheritance column prevented `child.becomes(Parent)` to return
      an instance of `Parent` as expected, instead it returns an instance
      of the default subclass.
      
      The change was introduced by #17169 and it was meant to affect
      initialization, alone. Where `Parent.new` is expected to return
      an instance of the default subclass.
      35623316
  6. 19 1月, 2018 1 次提交
  7. 18 1月, 2018 2 次提交
    • E
      Refactor migration to move migrations paths to connection · a2827ec9
      eileencodes 提交于
      Rails has some support for multiple databases but it can be hard to
      handle migrations with those. The easiest way to implement multiple
      databases is to contain migrations into their own folder ("db/migrate"
      for the primary db and "db/seconddb_migrate" for the second db). Without
      this you would need to write code that allowed you to switch connections
      in migrations. I can tell you from experience that is not a fun way to
      implement multiple databases.
      
      This refactoring is a pre-requisite for implementing other features
      related to parallel testing and improved handling for multiple
      databases.
      
      The refactoring here moves the class methods from the `Migrator` class
      into it's own new class `MigrationContext`. The goal was to move the
      `migrations_paths` method off of the `Migrator` class and onto the
      connection. This allows users to do the following in their
      `database.yml`:
      
      ```
      development:
        adapter: mysql2
        username: root
        password:
      
      development_seconddb:
        adapter: mysql2
        username: root
        password:
        migrations_paths: "db/second_db_migrate"
      ```
      
      Migrations for the `seconddb` can now be store in the
      `db/second_db_migrate` directory. Migrations for the primary database
      are stored in `db/migrate`".
      
      The refactoring here drastically reduces the internal API for migrations
      since we don't need to pass `migrations_paths` around to every single
      method. Additionally this change does not require any Rails applications
      to make changes unless they want to use the new public API. All of the
      class methods from the `Migrator` class were `nodoc`'d except for the
      `migrations_paths` and `migrations_path` getter/setters respectively.
      a2827ec9
    • E
      Added a test around `NO_AUTO_VALUE_ON_ZERO`: · 84206ad3
      Edouard CHIN 提交于
      - The mysql `NO_AUTO_VALUE_ON_ZERO` mode should be disabled when inserting fixtures in bulk, this PR adds a test to make sure we don't remove it by mistake
      - If we live this mode enabled, a statement like this wouldn't work and a `Duplicate entry '0' for key 'PRIMARY'` error will be raised. That's because `DEFAULT` on auto_increment will return 0
      
      ```sql
      INSERT INTO `aircraft` (`id`, `name`, `wheels_count`) VALUES (DEFAULT, 'first', 2), (DEFAULT, 'second', 3)
      ```
      84206ad3
  8. 15 1月, 2018 4 次提交
  9. 11 1月, 2018 1 次提交
  10. 10 1月, 2018 2 次提交
  11. 07 1月, 2018 4 次提交
  12. 04 1月, 2018 4 次提交
  13. 01 1月, 2018 2 次提交
  14. 31 12月, 2017 1 次提交
  15. 30 12月, 2017 1 次提交
    • R
      Fix `cache_key` with a relation having distinct and order · 7fae88f7
      Ryuta Kamizono 提交于
      We can't replace existing SELECT list as long as having DISTINCT, it
      will cause incorrect result.
      
      And also, PostgreSQL has a limitation that ORDER BY expressions must
      appear in select list for SELECT DISTINCT.
      
      Therefore, we should not replace existing SELECT list when using
      DISTINCT.
      
      Fixes #29779.
      7fae88f7
  16. 29 12月, 2017 1 次提交
  17. 27 12月, 2017 1 次提交