- 02 12月, 2012 5 次提交
-
-
由 Vijay Dev 提交于
Validations guide
-
由 Steve Klabnik 提交于
plus: * 80 column formats * replacing the explanation of the dynamic_form gem with the example HTML/CSS that Rails scaffolds generate.
-
由 Vijay Dev 提交于
Conflicts: guides/source/active_record_validations.md
-
由 Vijay Dev 提交于
-
由 Florent Guilleux 提交于
-
- 01 12月, 2012 9 次提交
-
-
由 Carlos Antonio da Silva 提交于
-
由 Xavier Noria 提交于
-
由 Xavier Noria 提交于
Fix #8167 - adding autoloading support for caching
-
由 Uriel Katz 提交于
Patched Marshal#load to work with constant autoloading (active_support/dependecies.rb) (issue #8167)
-
由 Andrew White 提交于
Chrome, Safari and Firefox serialize Date objects to strings such as 'Mon May 28 2012 00:00:00 GMT-0700 (PDT)'. When these strings are parsed the zone is interpreted as 'GMT-0700' which doesn't exist in the TzInfo list of timezones. By taking advantage of the improved date/time handling in 1.9.3 we can use `Date._parse` and the `:offset` value which is parsed correctly. Three tests were amended to make them pass: 1. test_parse_with_old_date This needed changing to a different value because the original value was before EST was adopted so was being changed to a LMT (Local Mean Time) value after the change. It didn't before because `DateTime` just has offsets from UTC not timezones. 2. test_parse_should_not_black_out_system_timezone_dst_jump Changed the implementation of this test as the stubs were dependent on internal implementation details of the test. Confirmed that the modified test still failed when the implementation of `parse` was restored to pre-#5571. 3. test_parse_should_black_out_app_timezone_dst_jump Ditto. Closes #5770.
-
由 Santiago Pastorino 提交于
Remove references to AR::Observer from docs
-
由 claudiob 提交于
ActiveRecord::Observer was extracted into a separate gem so it should not be referenced anymore (see https://github.com/rails/rails/commit/ccecab3)
-
由 Rafael Mendonça França 提交于
hash filters should be accessed with symbols or strings
-
由 Francesco Rodriguez 提交于
-
- 30 11月, 2012 14 次提交
-
-
由 Jon Leighton 提交于
At present, ActiveRecord::Delegation compiles delegation methods on a global basis. The compiled methods apply to all subsequent Relation instances. This creates several problems: 1) After Post.all.recent has been called, User.all.respond_to?(:recent) will be true, even if User.all.recent will actually raise an error due to no User.recent method existing. (See #8080.) 2) Depending on the AR class, the delegation should do different things. For example, if a Post.zip method exists, then Post.all.zip should call it. But this will then result in User.zip being called by a subsequent User.all.zip, even if User.zip does not exist, when in fact User.all.zip should call User.all.to_a.zip. (There are various variants of this problem.) We are creating these compiled delegations in order to avoid method missing and to avoid repeating logic on each invocation. One way of handling these issues is to add additional checks in various places to ensure we're doing the "right thing". However, this makes the compiled methods signficantly slower. In which case, there's almost no point in avoiding method_missing at all. (See #8127 for a proposed solution which takes this approach.) This is an alternative approach which involves creating a subclass of ActiveRecord::Relation for each AR class represented. So, with this patch, Post.all.class != User.all.class. This means that the delegations are compiled for and only apply to a single AR class. A compiled method for Post.all will not be invoked from User.all. This solves the above issues without incurring significant performance penalties. It's designed to be relatively seamless, however the downside is a bit of complexity and potentially confusion for a user who thinks that Post.all and User.all should be instances of the same class. Benchmark --------- require 'active_record' require 'benchmark/ips' class Post < ActiveRecord::Base establish_connection adapter: 'sqlite3', database: ':memory:' connection.create_table :posts def self.omg :omg end end relation = Post.all Benchmark.ips do |r| r.report('delegation') { relation.omg } r.report('constructing') { Post.all } end Before ------ Calculating ------------------------------------- delegation 4392 i/100ms constructing 4780 i/100ms ------------------------------------------------- delegation 144235.9 (±27.7%) i/s - 663192 in 5.038075s constructing 182015.5 (±21.2%) i/s - 850840 in 5.005364s After ----- Calculating ------------------------------------- delegation 6677 i/100ms constructing 6260 i/100ms ------------------------------------------------- delegation 166828.2 (±34.2%) i/s - 754501 in 5.001430s constructing 116575.5 (±18.6%) i/s - 563400 in 5.036690s Comments -------- Bear in mind that the standard deviations in the above are huge, so we can't compare the numbers too directly. However, we can conclude that Relation construction has become a little slower (as we'd expect), but not by a huge huge amount, and we can still construct a large number of Relations quite quickly.
-
由 Carlos Antonio da Silva 提交于
-
由 Jon Leighton 提交于
Keying these hashes by klass causes reloadable classes to never get freed. Thanks to @thedarkone for pointing this out in the comments on 221571be. This doesn't seem to make a massive difference to performance. Benchmark --------- require 'active_record' require 'benchmark/ips' class Post < ActiveRecord::Base establish_connection adapter: 'sqlite3', database: ':memory:' end GC.disable Benchmark.ips(20) do |r| r.report { Post.connection } end Before ------ Calculating ------------------------------------- 5632 i/100ms ------------------------------------------------- 218671.0 (±1.9%) i/s - 4364800 in 19.969401s After ----- Calculating ------------------------------------- 8743 i/100ms ------------------------------------------------- 206525.9 (±17.8%) i/s - 4039266 in 19.992590s
-
由 Jon Leighton 提交于
These are for internal use only and cannot be relied on as part of the public API. See discussion on 8c2c6051.
-
由 Carlos Antonio da Silva 提交于
Remove outdated monkey patch in mysql tests
-
由 Andrey Deryabin 提交于
This reverts commit a3024f81. REASON: Since warning doesn't exist
-
由 Rafael Mendonça França 提交于
Split Validations and Callbacks into separate guides.
-
由 Steve Klabnik 提交于
Two big features that are only barely related in the same guide. Seems bad. I did not check references to these guides yet, so some links may need to be updated.
-
由 Steve Klabnik 提交于
We have three or four different introduction sentences to the guides. After this commit, we use the same one everywhere.
-
由 Francesco Rodriguez 提交于
-
由 Francesco Rodriguez 提交于
-
由 Francesco Rodriguez 提交于
-
由 Rafael Mendonça França 提交于
Gemfile source url for plugins updated
-
由 Amparo Luna 提交于
-
- 29 11月, 2012 12 次提交
-
-
由 Jeremy Kemper 提交于
Move instantiation responsibilities from Inheritance to Persistence. Have Inheritance#discriminate_class_for_record handle STI lookup duties.
-
由 Steve Klabnik 提交于
Some guides work without 'the'. For instance, 'Migrations' or 'Form Helpers.' But when we talk about the asset pipeline, we... always say 'the asset pipeline.' The guide title should reflect this.
-
由 Steve Klabnik 提交于
It's obvious that this is a guide.
-
由 Steve Klabnik 提交于
Other guides that talk about Active Record specific features include the name of the library in the title, this one should too for consistency.
-
由 Steve Klabnik 提交于
They're Rails Guides, so obviously we're talking about Rails Form Helpers. Also, 'helpers' should be capitalized.
-
由 Steve Klabnik 提交于
It's obvious that this is a guide, and none of the other guides say 'A Guide to'.
-
由 Steve Klabnik 提交于
It's obvious that the guide is based on this version of Rails, and may not be backwards compatible.
-
由 Steve Klabnik 提交于
Talked with @fxn about this. Bullet points should have periods at the ends.
-
由 Steve Klabnik 提交于
The wording of these was a bit off, so I fixed them.
-
由 Steve Klabnik 提交于
The proper name has a space.
-
由 Steve Klabnik 提交于
The proper name has a space.
-
由 Steve Klabnik 提交于
The proper name has a space.
-