- 07 3月, 2010 1 次提交
-
-
由 wycats 提交于
add lazy_load_hooks.rb, which allows us to declare code that should be run at some later time. For instance, this allows us to defer requiring ActiveRecord::Base at boot time purely to apply configuration. Instead, we register a hook that should apply configuration once ActiveRecord::Base is loaded. With these changes, brings down total boot time of a new app to 300ms in production and 400ms in dev. TODO: rename base_hook
-
- 04 3月, 2010 1 次提交
-
-
由 Carl Lerche 提交于
-
- 03 3月, 2010 1 次提交
-
-
由 Carl Lerche 提交于
-
- 01 3月, 2010 1 次提交
-
-
由 Joshua Peek 提交于
-
- 28 2月, 2010 1 次提交
-
-
由 José Valim 提交于
-
- 26 2月, 2010 2 次提交
-
-
由 Tobias Bielohlawek 提交于
fixed a 'RecordNotFound' bug when calling 'reload' on a object which doesn't met the default_scope conditions, added test [#3166 status:resolved] The reload method didn't made use of 'with_exclusive_scope' when reloading the object. This lead to a RecordNotFound exception, in case the object doesn't met the default_scope condition (anymore) - which is obviously a bug. This quick fix makes use of with_exclusive_scope in the reload method as well. See test for full example. Signed-off-by: NJosé Valim <jose.valim@gmail.com>
-
由 Henry Hsu 提交于
Fix a bug where default_scope was overriding attributes given on model initialization [#3218 status:resolved] Signed-off-by: NJosé Valim <jose.valim@gmail.com>
-
- 24 2月, 2010 1 次提交
-
- 21 2月, 2010 2 次提交
-
-
由 José Valim 提交于
Require persisted? in ActiveModel::Lint and remove new_record? and destroyed? methods. ActionPack does not care if the resource is new or if it was destroyed, it cares only if it's persisted somewhere or not.
-
由 snusnu 提交于
Obviously #key is a too common name to be included in the AMo interface, #to_key fits better and also relates nicely to #to_param. Thx wycats, koz and josevalim for the suggestion. AR's #to_key implementation now takes customized primary keys into account and there's a testcase for that too. The #to_param AMo lint makes no assumptions on how the method behaves in the presence of composite primary keys. It leaves the decision wether to provide a default, or to raise and thus signal to the user that implementing this method will need his special attention, up to the implementers. All AMo cares about is that #to_param is implemented and returns nil in case of a new_record?. The default CompliantObject used in lint_test provides a naive default implementation that just joins all key attributes with '-'. The #to_key default implementation in lint_test's CompliantObject now returns [id] instead of [1]. This was previously causing the (wrong) tests I added for AR's #to_key implementation to pass. The #to_key tests added with this patch should be better. The CI failure was caused by my lack of knowledge about the test:isolated task. The tests for the record_identifier code in action_controller are using fake non AR models and I forgot to stub the #to_key method over there. This issue didn't come up when running the test task, only test:isolated revealed it. This patch fixes that. All tests pass isolated or not, well, apart from one previously unpended test in action_controller that is unrelated to my patch.
-
- 20 2月, 2010 1 次提交
-
-
由 snusnu 提交于
This commit introduces two new methods that every AMo compliant object must implement. Below are the default implementations along with the implied interface contract. # Returns an Enumerable of all (primary) key # attributes or nil if new_record? is true def key new_record? ? nil : [1] end # Returns a string representing the object's key # suitable for use in URLs, or nil if new_record? # is true def to_param key ? key.first.to_s : nil end 1) The #key method Previously rails' record_identifier code, which is used in the #dom_id helper, relied on calling #id on the record to provide a reasonable DOM id. Now with rails3 being all ORM agnostic, it's not safe anymore to assume that every record ever will have an #id as its primary key attribute. Having a #key method available on every AMo object means that #dom_id can be implemented using record.to_model.key # instead of record.id Using this we're able to take composite primary keys into account (e.g. available in datamapper) by implementing #dom_id using a newly added record_key_for_dom_id(record) method. The user can overwrite this method to provide customized versions of the object's key used in #dom_id. Also, dealing with more complex keys that can contain arbitrary strings, means that we need to make sure that we only provide DOM ids that are valid according to the spec. For this reason, this patch sends the key provided through a newly added sanitize_dom_id(candidate_id) method, that makes sure we only produce valid HTML The reason to not just add #dom_id to the AMo interface was that it feels like providing a DOM id should not be a model concern. Adding #dom_id to the AMo interface would force these concern on the model, while it's better left to be implemented in a helper. Now one could say the same is true for #to_param, and actually I think that it doesn't really fit into the model either, but it's used in AR and it's a main part of integrating into the rails router. This is different from #dom_id which is only used in view helpers and can be implemented on top of a semantically more meaningful method like #key. 2) The #to_param method Since the rails router relies on #to_param to be present, AR::Base implements it and returns the id by default, allowing the user to overwrite the method if desired. Now with different ORMs integrating into rails, every ORM railtie needs to implement it's own #to_param implementation while already providing code to be AMo compliant. Since the whole point of AMo compliance seems to be to integrate any ORM seamlessly into rails, it seems fair that all we really need to do as another ORM, is to be AMo compliant. By including #to_param into the official interface, we can make sure that this code can be centralized in the various AMo compliance layers, and not be added separately by every ORM railtie. 3) All specs pass
-
- 17 2月, 2010 1 次提交
-
-
由 Prem Sichanugrist 提交于
-
- 16 2月, 2010 1 次提交
-
-
由 Joshua Peek 提交于
-
- 06 2月, 2010 1 次提交
-
-
由 Santiago Pastorino 提交于
[#3826 state:committed] Signed-off-by: NJeremy Kemper <jeremy@bitsweat.net>
-
- 02 2月, 2010 1 次提交
-
-
由 Prem Sichanugrist 提交于
Signed-off-by: NJosé Valim <jose.valim@gmail.com>
-
- 01 2月, 2010 1 次提交
-
-
由 Carl Lerche 提交于
-
- 31 1月, 2010 1 次提交
-
-
由 Joshua Peek 提交于
We're going do it eventually, get it done before 3.0 is final.
-
- 30 1月, 2010 1 次提交
-
-
由 José Valim 提交于
-
- 27 1月, 2010 1 次提交
-
-
由 Aaron Patterson 提交于
Signed-off-by: NYehuda Katz <wycats@Yehuda-Katz.local>
-
- 26 1月, 2010 1 次提交
-
-
由 Jack Christensen 提交于
PostgreSQLAdapter: set time_zone to UTC when Base.default_timezone == :utc so that Postgres doesn't incorrectly offset-adjust values inserted into TIMESTAMP WITH TIME ZONE columns [#3777 state:resolved]
-
- 23 1月, 2010 1 次提交
-
-
由 Pratik Naik 提交于
-
- 22 1月, 2010 3 次提交
-
-
由 Pratik Naik 提交于
-
由 Pratik Naik 提交于
-
由 Pratik Naik 提交于
This reverts commit f936a1f1. Conflicts: activerecord/lib/active_record.rb activerecord/lib/active_record/base.rb Revert "Fixed: #without_typecast should only disable typecasting on the duplicated attributes" [#3387 state:open] This reverts commit 28319964. Reason : It's not generating attribute methods properly, making object.column 5x slower.
-
- 21 1月, 2010 1 次提交
-
-
由 José Valim 提交于
-
- 20 1月, 2010 3 次提交
-
-
由 Pratik Naik 提交于
Remove find_with_associations and related code from associations now that Relation handles that stuff
-
由 Pratik Naik 提交于
-
由 Pratik Naik 提交于
-
- 19 1月, 2010 2 次提交
-
-
由 Pratik Naik 提交于
-
由 Pratik Naik 提交于
Simplify calculation scope building. Remove :order from associations as it is troublesome w/ calculation methods using postgresql.
-
- 18 1月, 2010 9 次提交
-
-
由 Pratik Naik 提交于
-
由 Pratik Naik 提交于
-
由 José Valim 提交于
-
由 Pratik Naik 提交于
-
由 Pratik Naik 提交于
-
由 Pratik Naik 提交于
-
由 Pratik Naik 提交于
-
由 Pratik Naik 提交于
-
由 Pratik Naik 提交于
-
- 17 1月, 2010 1 次提交
-
-
由 José Valim 提交于
-