- 13 2月, 2018 10 次提交
-
-
由 Yuji Yaginuma 提交于
Don't overwrite config/master.key even on --force
-
由 claudiob 提交于
See https://github.com/rails/rails/pull/31957#issuecomment-364817423 The purpose of `--force` is not to have any prompt whether a file should be kept or overwritten. In general, all existing files should be overwritten. However, `config/master.key` is special because it is git-ignored, and overwriting it will cause the app not to run (since there won't be a way to decrypt the credentials). As a result, it's probably better to keep the existing config/master.key.
-
由 Rafael França 提交于
Add ActiveStorage::Blob.unattached scope
-
由 Yuji Yaginuma 提交于
Incompatible settings are included in the settings set by `load_defaults`. So, I think that target version should be updated by a user when becomes available, and should not be updated with `app:update`.
-
由 Joseph Page 提交于
[ci skip] Closes #31967
-
由 Rafael França 提交于
Change structure in the AS core extensions guide [ci skip]
-
由 Yauheni Dakuka 提交于
-
由 Rafael Mendonça França 提交于
-
由 fatkodima 提交于
-
由 Rafael França 提交于
ActiveStorage: use full class names when including concerns to avoid collisions
-
- 12 2月, 2018 7 次提交
-
-
由 Wojtek Wrona 提交于
-
由 Eileen M. Uchitelle 提交于
Improve wording in getting started guide
-
由 Ryuta Kamizono 提交于
Missing parentheses [ci skip]
-
由 Yauheni Dakuka 提交于
-
由 George Claghorn 提交于
-
由 Yuji Yaginuma 提交于
Respect --force option for config/master.key
-
由 claudiob 提交于
This is similar to #30700 which ensures the `--quiet` option of `rails new` is respected by the `MasterKeyGenerator` (missing from #30067). Before this commit, running `rails new app --force` would still prompt the user what to do with the conflict in `config/master.key`: ``` … identical config/locales/en.yml conflict config/master.key Overwrite /Users/claudiob/Desktop/pizza/config/master.key? (enter "h" for help) [Ynaqdh] ``` After this commit, `config/master.key` is overwritten: ``` … identical config/locales/en.yml force config/master.key append .gitignore ``` The newly added test generates an app and then generates it again with `--force`. Without this commit, the test would just wait forever for user input.
-
- 11 2月, 2018 2 次提交
-
-
由 Matthew Draper 提交于
sanitize empty and nil parameters to select #31059
-
由 Akira Matsuda 提交于
-
- 10 2月, 2018 6 次提交
-
-
由 James Lovejoy 提交于
[ci skip]
-
由 Claudio B 提交于
Remove warning from 4 years ago [ci skip]
-
由 yuuji.yaginuma 提交于
-
由 Rafael Mendonça França 提交于
Before, if the application defined after an engine this method would not recognize the route since it was not defined insdie the engine.
-
由 David Heinemeier Hansson 提交于
* Add Relation#pick as short-hand for single-value plucks
-
- 09 2月, 2018 6 次提交
-
-
由 Eileen M. Uchitelle 提交于
Document :combine_options
-
由 Yuji Yaginuma 提交于
Use heredoc with credentials template
-
由 Yoshiyuki Hirano 提交于
* Use heredoc with credentials template. * Fix indentation for aws config
-
由 Ryuta Kamizono 提交于
Fix marshaling of models with `has_many :through` associations
-
由 Ryuta Kamizono 提交于
Fix `test_counter_cache_with_touch_and_lock_version` failure
-
由 Robert Glaser 提交于
Turns out this is still undocumented functionality.
-
- 08 2月, 2018 9 次提交
-
-
由 fatkodima 提交于
-
由 Eileen M. Uchitelle 提交于
Fix grammar bug in security guide [ci skip]
-
由 claudiob 提交于
[ci skip]
-
由 yuuji.yaginuma 提交于
Without this require, an error occurs when executing only `duration_test.rb`. Ref: https://travis-ci.org/rails/rails/jobs/338817558#L2205-L2210
-
由 Yuji Yaginuma 提交于
Fixes #31917
-
由 George Claghorn 提交于
Fix `blob.service_url` for supports string type `:filename` option
-
由 Jason Lee 提交于
- Make sure `blob.service_url` present a `ActiveStorage::Filename` type to `serivce.url`. - Add `ActiveStorage::Filename.wrap` method. before: ```rb blob.service_url(filename: ActiveStorage::Filename.new("new.txt")) blob.service_url(filename: "new.txt") => NoMethodError: undefined method `parameters' for "new.txt":String params = {} blob.service_url(filename: params[:filename]) => NoMethodError: undefined method `parameters' for nil:NilClass ``` after: ```rb blob.service_url(filename: "new.txt") blob.service_url(filename: nil) ```
-
由 Daniel Colson 提交于
-
由 bogdanvlviv 提交于
https://travis-ci.org/rails/rails/jobs/338338927#L1043 Related to daf15f58
-