- 17 6月, 2019 1 次提交
-
-
由 Ryuta Kamizono 提交于
This is also resolved in `arel_column`.
-
- 14 6月, 2019 5 次提交
-
-
由 Ryuta Kamizono 提交于
Fix sqlite3 collation parsing when using decimal columns.
-
由 Gannon McGibbon 提交于
Fix programmatic clicks with data-remote
-
由 Rafael França 提交于
[ci skip] Use default path in button_to documentation
-
由 jeffdoering 提交于
* Make ActiveRecord `ConnectionPool.connections` thread-safe. ConnectionPool documentation is clear on the need to synchronize access to @connections but also states that public methods do not require synchronization. Existing code exposed @connections directly via attr_reader. The fix uses synchronize() to lock @connections then returns a copy to the caller using Array.dup(). Includes comments on the connections method that thread-safe access to the connections array does not imply thread-safety of accessing methods on the actual connections. Adds a test-case that modifies the pool using a supported method in one thread while a second thread accesses pool.connections. The test fails without this patch. Fixes #36465. * Update activerecord/test/cases/connection_pool_test.rb [jeffdoering + Rafael Mendonça França]
-
由 Rafael França 提交于
images/getting_started: Update screenshot for missing action
-
- 13 6月, 2019 1 次提交
-
-
由 Rafael França 提交于
Add missing file to require digest/uuid on active_support core ext
-
- 05 6月, 2019 1 次提交
-
-
由 Marco Costa 提交于
When generating a new rails application (rails new) using a custom template that includes gems from an authenticated source, the user has to provide credentials to bundler. One way to do this is by exporting environment variables, for example: export BUNDLE_GITHUB__COM=user:pass: provides credentials for bundler to fetch gems from github.com. The problem this PR addresses is that we are currently scrubs all /BUNDLE_.*/ environment variables by wrapping our system calls in Bundler.with_clean_env. We do this because we don't want our commands executed against the generated project to use the generator's bundler environment (e.g. our gems): the generated project should use it's own configuration. The problem with Bundler.with_clean_env is that, on top of restoring environment variables to their original state, it also scrubs any /BUNDLE_.*/ variables, which is harmful for authenticated gem sources. This PR replaces Bundler.with_clean_env with Bundler.with_original_env, which only restores environment variables to their initial state, without additional scrubbing.
-
- 15 5月, 2019 1 次提交
-
-
由 Ryuta Kamizono 提交于
Fix eager loading associations with string joins not to raise NoMethodError
-
- 08 5月, 2019 4 次提交
-
-
由 Ryuta Kamizono 提交于
This fixes a bug that the `foreign_key` and the `foreign_type` are separated as different table conditions if a polymorphic association has a scope that joins another tables.
-
由 Ryuta Kamizono 提交于
Fix `count(:all)` with eager loading and explicit select and order
-
由 Gannon McGibbon 提交于
[#35782] Allow loading seeds without ActiveJob (~> 5.2.3)
-
- 18 4月, 2019 1 次提交
-
-
由 Kasper Timm Hansen 提交于
If executing either `bin/test` in railties or `yarn build` in actioncable, some build artifacts are left over. The master branch git ignores those correctly. However, checking out 5-2-stable means I'll suddenly have to deal with them. Let's just ignore those artifacts here too. Proof: ``` kaspth@kaspth-imac:~/code/rails (5-2-stable)$ git status On branch 5-2-stable Your branch is up to date with 'origin/5-2-stable'. Untracked files: (use "git add <file>..." to include in what will be committed) actioncable/app/javascript/ railties/test/isolation/assets/ tmp/ ```
-
- 16 4月, 2019 1 次提交
-
-
由 Rafael França 提交于
mounted routes with non-word characters
-
- 10 4月, 2019 1 次提交
-
-
由 Rafael França 提交于
Only override async adapter when seeding
-
- 09 4月, 2019 1 次提交
-
-
由 Matthew Draper 提交于
-
- 31 3月, 2019 3 次提交
-
-
由 Yuji Yaginuma 提交于
Use `googleauth` gem 0.8.0 if Ruby version is 2.2
-
由 Yasuo Honda 提交于
`googleauth` 0.8.1 requires Ruby 2.3 to support indented here document `<<~` https://travis-ci.org/rails/rails/jobs/512320216#L1788 ```ruby /home/travis/build/rails/rails/activesupport/lib/active_support/dependencies.rb:291:in `require': /home/travis/.rvm/gems/ruby-2.2.10/gems/googleauth-0.8.1/lib/googleauth/application_default.rb:37: syntax error, unexpected << (SyntaxError) NOT_FOUND_ERROR = <<~ERROR_MESSAGE.freeze ``` If Ruby version is 2.3+, we do not have to specify the `googleauth` gem version because `google-cloud-storage` and `google-api-client` gem will find the required `googleauth` gem version by itself.
-
由 Ryuta Kamizono 提交于
Fix callbacks on has_many :through associations
-
- 30 3月, 2019 1 次提交
-
-
由 Ryuta Kamizono 提交于
Type cast falsy boolean symbols on boolean attribute as false
-
- 29 3月, 2019 1 次提交
-
-
由 Rafael França 提交于
Update CHANGELOG entry for the Cache-Control header change [ci skip]
-
- 28 3月, 2019 3 次提交
-
-
由 Sharang Dashputre 提交于
-
由 Rafael Mendonça França 提交于
-
由 Rafael Mendonça França 提交于
-
- 27 3月, 2019 3 次提交
-
-
由 Prem Sichanugrist 提交于
[ci skip] Fixed changelog typo for fixed controller params
-
由 Abhay Nikam 提交于
-
由 Ken Greeff 提交于
-
- 26 3月, 2019 1 次提交
-
-
由 Ryuta Kamizono 提交于
Bugfix: Fix false autosave for has_one :through association
-
- 23 3月, 2019 6 次提交
-
-
由 Prem Sichanugrist 提交于
[ci skip] Fixed typo in 5.2.2.1 release CHANGELOG
-
由 Shailesh Kalamkar 提交于
-
由 John Hawthorn 提交于
Update CHANGELOGs for 5.2.2.1 release
-
由 John Hawthorn 提交于
-
由 Rafael França 提交于
Revert 5-2-stable backport of #35549
-
由 John Hawthorn 提交于
This reverts commit 4185881d.
-
- 22 3月, 2019 4 次提交
-
-
由 Rafael Mendonça França 提交于
-
由 Rafael Mendonça França 提交于
-
由 Rafael Mendonça França 提交于
-
由 Yuji Yaginuma 提交于
Since https://github.com/puma/puma/pull/1700, the default host is correctly used. So `localhost` is used instead of `0.0.0.0`. As a result, the log output on restart is changed, and the restart test fails on Puma 3.12.1. https://travis-ci.org/rails/rails/jobs/509239592#L2303-L2305 Specify binding explicitly to avoid being affected by Puma changes.
-
- 14 3月, 2019 1 次提交
-
-
由 Yuji Yaginuma 提交于
Make application work without tmp directory
-