未验证 提交 1b211bec 编写于 作者: Y Yuji Yaginuma 提交者: GitHub

Fix server restart test on Puma 3.12.1 (#35696)

Since https://github.com/puma/puma/pull/1700, the default host is
correctly used. So `localhost` is used instead of `0.0.0.0`.

As a result, the log output on restart is changed, and the restart test
fails on Puma 3.12.1.
https://travis-ci.org/rails/rails/jobs/509239592#L2303-L2305

Specify binding explicitly to avoid being affected by Puma changes.
上级 b4079b17
......@@ -347,8 +347,8 @@ GEM
powerpack (0.1.1)
psych (2.2.4)
public_suffix (3.0.2)
puma (3.11.4)
puma (3.11.4-java)
puma (3.12.1)
puma (3.12.1-java)
que (0.14.3)
qunit-selenium (0.0.4)
selenium-webdriver
......
......@@ -44,13 +44,13 @@ def teardown
pid = nil
begin
pid = Process.spawn("#{app_path}/bin/rails server -P tmp/dummy.pid", in: slave, out: slave, err: slave)
pid = Process.spawn("#{app_path}/bin/rails server -b localhost -P tmp/dummy.pid", in: slave, out: slave, err: slave)
assert_output("Listening", master)
rails("restart")
assert_output("Restarting", master)
assert_output("Inherited", master)
assert_output("tcp://localhost:3000", master)
ensure
kill(pid) if pid
end
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册