- 23 4月, 2020 8 次提交
-
-
由 Ryuta Kamizono 提交于
Get rid of redundant direction argument in execute_migration_in_transaction
-
由 Andrey Koleshko 提交于
-
由 Ryuta Kamizono 提交于
Fix typos [ci skip]
-
由 Eugene Kenny 提交于
Reload schema after ignored_columns reassignment
-
由 Flavio Wuensche 提交于
reload column_names after ignored_columns assignment code review: remove unnecessary setup and move up reload_schema_from_cache
-
由 Godfrey Chan 提交于
I wrote this shell script to find words from the Rails repo, so I can paste them into https://www.horsepaste.com/ for the [codenames game](https://en.m.wikipedia.org/wiki/Codenames_(board_game)). ```bash git grep -Il '' | \ grep -v -E "CHANGELOG|Gemfile|gemspec|package\.json|yarn\.lock" | \ xargs cat | \ sed '/[^ ]\{10,\}/d' | \ sed 's/\([A-Z]\)/ \1/g' | \ tr 'A-Z' 'a-z' | \ tr -c -s 'a-z' '\n' | \ sed '/^.\{0,3\}$/d' | \ sort | \ uniq | \ tr '\n' ',' | \ pbcopy ``` You can see the result in https://www.horsepaste.com/rails-fixed. Click "Next game" to cycle the words. Found some typos in the codebase from this
😂 This is how I generated the list of possible typos: ```bash git grep -Il '' | \ grep -v -E "CHANGELOG|Gemfile|gemspec|package\.json|yarn\.lock" | \ xargs cat | \ sed '/[^ ]\{10,\}/d' | \ sed 's/\([A-Z]\)/ \1/g' | \ tr 'A-Z' 'a-z' | \ tr -c -s 'a-z' '\n' | \ sed '/^.\{0,3\}$/d' | \ sort | \ uniq | \ aspell --ignore-case list ``` I manually reviewed the list and made the corrections in this commit. The rest on the list are either: * Bugs in my script: it split things like "doesn't" into "doesn" and "t", if find things like `#ffffff` and extracts "ffffff" as a word, etc * British spelling: honour, optimised * Foreign words: bonjour, espanol * Names: nginx, hanekawa * Technical words: mutex, xhtml * Portmanteau words: autosave, nodelist * Invented words: camelize, coachee * Shortened words: attrs, repo * Deliberate typos: hllo, hillo (used in code examples, etc) * Lorem ipsum words: arcu, euismod This is the [output](https://gist.github.com/chancancode/eb0b573d667dc31906f33f1fb0b22313) of the script *after* fixing the typos included in this commit. In theory, someone can run that command again in the future and compare the output to catch new typos (i.e. using my list to filter out known typos). Limitations: the aspell dictionary could be wrong, I could have miss things, and my script ignores words that are less than 3 characters or longer than 10 characters. -
由 Rafael França 提交于
Reference updated errors attribute names method in deprecation warning
-
由 Adam Hess 提交于
-
- 22 4月, 2020 6 次提交
-
-
由 Eugene Kenny 提交于
Reject hexadecimal numbers with signs while validating numericality
-
由 nimish 提交于
-
由 Ryuta Kamizono 提交于
Realign cache key diagram in method doc [ci skip]
-
由 Jonathan Hefner 提交于
Follow-up to #37669.
-
由 David Heinemeier Hansson 提交于
-
由 JvH 提交于
Add `config.active_storage.web_image_content_types` to allow applications to add content types (like `image/webp`) in which variants can be processed, instead of letting those images be converted to the fallback PNG format.
-
- 21 4月, 2020 7 次提交
-
-
由 Eugene Kenny 提交于
Update Gemfile.lock minimum Rack version to 2.0.9
-
由 Jonathan Hefner 提交于
Follow-up to #38991.
-
由 Eugene Kenny 提交于
Add retry_jitter to 6.1 new framework defaults
-
由 Eugene Kenny 提交于
Enable Rails/IndexBy and Rails/IndexWith cops
-
由 Eugene Kenny 提交于
Update minimum Rack version to 2.0.9
-
由 Eugene Kenny 提交于
Use __id__ to dedup records for transactional callbacks
-
由 Marla Brizel Zeschin 提交于
Co-authored-by: NRyuta Kamizono <kamipo@gmail.com>
-
- 20 4月, 2020 6 次提交
-
-
由 Eugene Kenny 提交于
Preserve column comment on renaming column
-
由 Islam Taha 提交于
Update activerecord changelog Specify DB name in changelog and fix typo
-
由 Eugene Kenny 提交于
This was added to the defaults for new applications in e2cdffce, but we also need an entry in the new framework defaults initializer for upgrading applications.
-
由 Eugene Kenny 提交于
Followup to d3599d8a, which applied this style to the existing codebase.
-
由 Eugene Kenny 提交于
Since 28f81c05, if the `same_site:` option is set to `:none` when creating a cookie, it will be passed through to Rack. Support for `:none` was added in Rack 2.0.9, so we should bump the minimum required version to ensure it's available.
-
由 Eugene Kenny 提交于
While not a particularly good idea, it's possible to use `object_id` as an attribute name, typically by defining a polymorphic association named `object`. Since 718a32ca, transactional callbacks deduplicate records by their `object_id`, but this causes incorrect behaviour when the record has an attribute with that name. Using `__id__` instead makes a naming collision much less likely.
-
- 19 4月, 2020 4 次提交
-
-
由 Eugene Kenny 提交于
Update scope documentation [ci skip]
-
由 Eugene Kenny 提交于
Fix random CI fail due to cross-second time delay
-
由 Eugene Kenny 提交于
Add missing backticks [ci skip]
-
由 Arslan Javed 提交于
-
- 18 4月, 2020 2 次提交
-
-
由 Nimish 提交于
-
由 Tejas Bubane 提交于
* Bump rubocop to 0.82 The `Layout/Tab` cop has been renamed to `Layout/IndentationStyle` ref: https://github.com/rubocop-hq/rubocop/releases/tag/v0.82.0 No other code changes required. * Bump rubocop-rails to 2.5.2 No code-changes required. [Tejas Bubane + Rafael Mendonça França]
-
- 17 4月, 2020 6 次提交
-
-
由 Kasper Timm Hansen 提交于
Convert CoffeeScript to ES6 syntax
-
由 Liroy Leshed 提交于
-
由 Ryuta Kamizono 提交于
Follow up to 404e1a0a.
-
由 Eugene Kenny 提交于
Don't gitignore tmp/pids/.keep
-
由 Eugene Kenny 提交于
Since 04cfbc80, a keepfile is generated in `tmp/pids/` to ensure that the directory always exists. However, the gitignore pattern for `/tmp/*` meant it wasn't tracked in git. To override that pattern we have to allow the `tmp/pids/` directory, ignore everything inside it, then finally allow `tmp/pids/.keep` again.
-
由 Eileen M. Uchitelle 提交于
Add `if_exists` option to `remove_index`
-
- 16 4月, 2020 1 次提交
-
-
由 eileencodes 提交于
This PR allows for passing `if_exists` options to the `remove_index` method so that we can ignore already removed indexes. This work follows column `if/if_not_exists` from #38352 and `:if_not_exists` on `add_index` from #38555. We've found this useful at GitHub, there are migrations where we don't want to raise if an index was already removed. This will allow us to remove a monkey patch on `remove_index`. I considered raising after the `index_name_for_remove` method is called but that method will raise if the index doesn't exist before we get to execute. I have a commit that refactors this but after much consideration this change is cleaner and more straightforward than other ways of implementing this. This change also adds a little extra validation to the `add_index` test. Fix `nodoc` on edited methods.
-