Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
张重言
rails
提交
a6c27d59
R
rails
项目概览
张重言
/
rails
通知
1
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
R
rails
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
提交
Issue看板
体验新版 GitCode,发现更多精彩内容 >>
未验证
提交
a6c27d59
编写于
4月 20, 2020
作者:
E
Eugene Kenny
提交者:
GitHub
4月 20, 2020
浏览文件
操作
浏览文件
下载
差异文件
Merge pull request #38990 from eugeneius/transaction_callbacks_object_id
Use __id__ to dedup records for transactional callbacks
上级
0fac4559
8d3ca970
变更
2
隐藏空白更改
内联
并排
Showing
2 changed file
with
39 addition
and
2 deletion
+39
-2
activerecord/lib/active_record/connection_adapters/abstract/transaction.rb
...active_record/connection_adapters/abstract/transaction.rb
+2
-2
activerecord/test/cases/transaction_callbacks_test.rb
activerecord/test/cases/transaction_callbacks_test.rb
+37
-0
未找到文件。
activerecord/lib/active_record/connection_adapters/abstract/transaction.rb
浏览文件 @
a6c27d59
...
...
@@ -101,7 +101,7 @@ def materialized?
def
rollback_records
return
unless
records
ite
=
records
.
uniq
(
&
:
object_id
)
ite
=
records
.
uniq
(
&
:
__id__
)
already_run_callbacks
=
{}
while
record
=
ite
.
shift
trigger_callbacks
=
record
.
trigger_transactional_callbacks?
...
...
@@ -121,7 +121,7 @@ def before_commit_records
def
commit_records
return
unless
records
ite
=
records
.
uniq
(
&
:
object_id
)
ite
=
records
.
uniq
(
&
:
__id__
)
already_run_callbacks
=
{}
while
record
=
ite
.
shift
if
@run_commit_callbacks
...
...
activerecord/test/cases/transaction_callbacks_test.rb
浏览文件 @
a6c27d59
...
...
@@ -501,6 +501,43 @@ def test_saving_a_record_with_a_belongs_to_that_specifies_touching_the_parent_sh
assert
flag
end
def
test_saving_two_records_that_override_object_id_should_run_after_commit_callbacks_for_both
klass
=
Class
.
new
(
TopicWithCallbacks
)
do
define_method
(
:object_id
)
{
42
}
end
records
=
[
klass
.
new
,
klass
.
new
]
klass
.
transaction
do
records
.
each
do
|
record
|
record
.
after_commit_block
{
|
r
|
r
.
history
<<
:after_commit
}
record
.
save!
end
end
assert_equal
[
:after_commit
],
records
.
first
.
history
assert_equal
[
:after_commit
],
records
.
second
.
history
end
def
test_saving_two_records_that_override_object_id_should_run_after_rollback_callbacks_for_both
klass
=
Class
.
new
(
TopicWithCallbacks
)
do
define_method
(
:object_id
)
{
42
}
end
records
=
[
klass
.
new
,
klass
.
new
]
klass
.
transaction
do
records
.
each
do
|
record
|
record
.
after_rollback_block
{
|
r
|
r
.
history
<<
:after_rollback
}
record
.
save!
end
raise
ActiveRecord
::
Rollback
end
assert_equal
[
:after_rollback
],
records
.
first
.
history
assert_equal
[
:after_rollback
],
records
.
second
.
history
end
private
def
add_transaction_execution_blocks
(
record
)
record
.
after_commit_block
(
:create
)
{
|
r
|
r
.
history
<<
:commit_on_create
}
...
...
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录