- 17 7月, 2018 4 次提交
-
-
由 utilum 提交于
Missed these in preparing #33337
-
由 utilum 提交于
Should have been removed in #33309.
-
由 George Claghorn 提交于
-
由 George Claghorn 提交于
-
- 16 7月, 2018 10 次提交
-
-
由 George Claghorn 提交于
-
由 Ryuta Kamizono 提交于
Clarify test cases
-
由 Ryuta Kamizono 提交于
Modify the expression's issue for `errors.add` document. [ci skip]
-
由 lanzhiheng 提交于
-
由 George Claghorn 提交于
-
由 George Claghorn 提交于
Closes #32193.
-
由 bogdanvlviv 提交于
Remove extra stub of `ActiveRecord::Base::connection` in `activerecord/test/cases/tasks/mysql_rake_test.rb`. Remove extra stub of `File::exist?` in `activerecord/test/cases/tasks/sqlite_rake_test.rb`. `ActiveRecord::Base::establish_connection` shouldn't return `true` in test cases. Related to https://github.com/rails/rails/pull/33337.
-
由 Ryuta Kamizono 提交于
Stub with minitest not mocha
-
由 Ryuta Kamizono 提交于
fix test_should_impose_childless_html_tags_in_html failure with JRuby
-
由 Ryuta Kamizono 提交于
Merge pull request #33365 from lanzhiheng/fix-document-issue-about-active-record-callbacks-after_touch Fix document issue in active record callback about `after_touch` hook. [ci skip]
-
- 15 7月, 2018 6 次提交
-
-
由 pavel 提交于
-
由 lanzhiheng 提交于
-
由 utilum 提交于
Step 4 in #33162
-
由 Eileen M. Uchitelle 提交于
Fix regression in use of string attribute in the added? method
-
由 Jeremy Baker 提交于
-
由 Eileen M. Uchitelle 提交于
Update documentation for #pluck method [ci skip]
-
- 14 7月, 2018 4 次提交
-
-
由 Jędrek Domański 提交于
-
由 George Claghorn 提交于
-
由 George Claghorn 提交于
-
由 George Claghorn 提交于
-
- 13 7月, 2018 5 次提交
-
-
由 George Claghorn 提交于
-
由 Rafael França 提交于
[ci skip] `sanitizer_vendor` will be removed in Rails 6
-
由 Rafael França 提交于
e4e1b620 broke `to_param` handling:
-
由 Rafael França 提交于
Enable `Layout/EmptyLinesAroundBlockBody` to reduce review cost in the future
-
由 Edouard CHIN 提交于
- There was an issue inside controller tests where order params were not respected, the reason was because we were calling `Hash#to_query` which sorts the results lexicographically. 1e4e1b62 fixed that issue by not using `to_query` but instead a utility function provided by rack. - However with the fix came another issue where it's now no longer possible to do this ``` post :foo, params: { user: User.first } # Prior to the patch the controller will receive { "user" => "1" } # Whereas now you get { "user": "#<User: ...>" } ``` The fix in this PR is to modify `Hash#to_query` to sort only when it doesn't contain an array structure that looks something like "bar[]" Ref https://github.com/rails/rails/pull/33341#issuecomment-404039396
-
- 12 7月, 2018 4 次提交
-
-
由 Ryuta Kamizono 提交于
We sometimes ask "
✂ ️ extra blank lines" to a contributor in reviews like https://github.com/rails/rails/pull/33337#discussion_r201509738. It is preferable to deal automatically without depending on manpower. -
由 George Claghorn 提交于
-
由 George Claghorn 提交于
We've never intentionally tripped this retry in production. Add retries for specific errors as needed.
-
由 Rafael França 提交于
Add missing env & config dependency to `rake db:seed`
-
- 11 7月, 2018 3 次提交
-
-
-
由 Rafael França 提交于
Fix stubbed methods in test cases
-
由 bogdanvlviv 提交于
Remove returning of `false` value for stubbed `lock_thread=` methods since there aren't any needs in it. Remove unnecessary returning of `true` for stubbed `drop_database` method. Follow up #33309. Related to #33162, #33326.
-
- 10 7月, 2018 4 次提交
-
-
由 Ryuta Kamizono 提交于
Replace shallow mocks with Ruby classes
-
由 Tobias Bielohlawek 提交于
-
由 utilum 提交于
While preparing this I realised that some stubbed returns values serve no purpose, so this patch drops those as well. Step 3 in #33162
-
由 Ryuta Kamizono 提交于
-