- 08 12月, 2012 6 次提交
-
-
由 Francesco Rodriguez 提交于
AS::BasicObject is used for proxy classes. Let's give it a less concerning name. Also, it avoids the confusion with Ruby's Basic Object.
-
由 David Heinemeier Hansson 提交于
-
由 David Heinemeier Hansson 提交于
-
由 Carlos Antonio da Silva 提交于
Document the types of arguments accepted by AR#not
-
由 claudiob 提交于
This commit stems from https://github.com/rails/rails/pull/8332#issuecomment-11127957 Since the formats in which conditions can be passed to `not` differ from the formats in which conditions can be passed to `like` and `not_like`, then I think it's worth adding rdoc and tests to show this behavior
-
由 Xavier Noria 提交于
The force flag suggests the original was probably copied from some db/schema.rb. Thanks to Josh Susser for spotting and reporting this.
-
- 07 12月, 2012 21 次提交
-
-
由 Xavier Noria 提交于
Shelling out was there for authors convenience, but we are rather going to have the tag or SHA1 always in RAILS_VERSION and if the environment variable is blank, then just use "local" as a reminder that you are just working locally. The docs server has been updated to set the long SHA1 in RAILS_VERSION when generating edge guides.
-
由 Carlos Antonio da Silva 提交于
Arel::Nodes::In inherits from Arel::Nodes::Equality, so the case statement was always using the Equality operator for both scenarios, resulting in a not equal query instead.
-
由 Carlos Antonio da Silva 提交于
Update #where rdoc to match 6ba0f975 [ci skip]
-
由 claudiob 提交于
This commit updates the rdoc of AR#where to match the changes applied in https://github.com/rails/rails/commit/6ba0f97 that is: * `where(nil)` has the same effect of `where('')`: a no op * `where` (no args) has the same effect of `where(:chain)`: to create a WhereChain
-
由 Andrew White 提交于
This reverts commit c59734f7.
-
由 Carlos Antonio da Silva 提交于
This test does not belong to has many associations test.
-
由 Carlos Antonio da Silva 提交于
Consider this scenario: if params[:foo] conditions = { foo: true } end foos = Foo.where(conditions).order(:id) When params[:foo] is nil, this would call: foos = Foo.where(nil).order(:id) In this scenario, we want Foo.where(conditions) to be the same as calling Foo.all, otherwise we'd get a "NoMethodError order for WhereChain". Related to #8332.
-
由 Carlos Antonio da Silva 提交于
Relation.where with no args can be chained with not, like, and not_like Conflicts: activerecord/CHANGELOG.md activerecord/lib/active_record/relation/query_methods.rb
-
由 Carlos Antonio da Silva 提交于
-
由 Carlos Antonio da Silva 提交于
When applying default_scope to a class with a where clause, using update_column(s) could generate a query that would not properly update the record due to the where clause from the default_scope being applied to the update query. class User < ActiveRecord::Base default_scope where(active: true) end user = User.first user.active = false user.save! user.update_column(:active, true) # => false In this situation we want to skip the default_scope clause and just update the record based on the primary key. With this change: user.update_column(:active, true) # => true Fixes #8436.
-
由 Carlos Antonio da Silva 提交于
-
由 Carlos Antonio da Silva 提交于
-
由 Carlos Antonio da Silva 提交于
LOCALTIMESTAMP is not support by sqlite3, and travis was giving us these errors: https://travis-ci.org/rails/rails/jobs/3535241/#L570
-
由 Carlos Antonio da Silva 提交于
Before: Finished tests in 56.245787s, 0.2133 tests/s, 0.0000 assertions/s. 12 tests, 0 assertions, 0 failures, 0 errors, 0 skips After: Finished tests in 42.401416s, 0.2830 tests/s, 0.0000 assertions/s. 12 tests, 0 assertions, 0 failures, 0 errors, 0 skips
-
由 Rafael Mendonça França 提交于
CHANGELOG for 78d5d6f8 [ci skip]
-
由 Steve Klabnik 提交于
It was pointed out by @giner that the CHANGELOG entry for https://github.com/rails/rails/commit/78d5d6f8688bb7c45ba9a3ef893682231130da3f wasn't included. Here it is.
-
由 Carlos Antonio da Silva 提交于
Fixes issues in test_mysql2
-
由 Rafael Mendonça França 提交于
-
由 Josh Susser 提交于
-
由 Andrew White 提交于
This commit inverts the precedence in ActionDispatch::Static so that dynamic content will be served before static content. This is so that precompiled assets do not inadvertently get included when running in development mode - it should have no effect in production where static files are usually handled by the web server. Closes #6421
-
由 Josh Susser 提交于
why is this a Time to start with?
-
- 06 12月, 2012 13 次提交
-
-
由 Carlos Antonio da Silva 提交于
This cleanup aims to fix a build failure: https://travis-ci.org/rails/rails/jobs/3515951/#L482 Since travis always have both ENV vars set to "test", a test is failing where it's expected to output the default env "development", but "test" is the result due to RACK_ENV being set when we expect it to not be. By cleaning this duplication we ensure that changing any of these env variables will pick the right expected value.
-
由 Andrew White 提交于
To prevent future pull requests like #8435 add a comment about the implementation of class_attribute using class_eval for performance. [ci skip]
-
由 Xavier Noria 提交于
-
由 Aaron Patterson 提交于
dump schema.rb without :version option
-
由 Josh Susser 提交于
-
由 Aaron Patterson 提交于
* joshsusser-master: style cleanup Add migration history to schema.rb dump Add metadata to schema_migrations Conflicts: activerecord/CHANGELOG.md activerecord/lib/active_record/schema.rb
-
由 Carlos Antonio da Silva 提交于
Revert turbolinks load order requirement
-
由 Nick Reed 提交于
-
由 Carlos Antonio da Silva 提交于
[ci skip]
-
由 Rafael Mendonça França 提交于
Add ENV['RACK_ENV'] support to rake runner/console/server.
-
由 kennyj 提交于
-
由 Xavier Noria 提交于
fix warning: possibly useless use of a constant in void context
-
由 kennyj 提交于
-