- 21 11月, 2016 2 次提交
-
-
由 Kasper Timm Hansen 提交于
-
由 Kasper Timm Hansen 提交于
Refactor ActiveSupport::XMLMini test suite
-
- 20 11月, 2016 21 次提交
-
-
由 Jon Moss 提交于
This fixes an error where the test runner would try and run XMLMiniEngineTest like a normal test class, except it's abstract. Now, to circumvent this, we don't include any of the actual tests in XMLMiniEngineTest; they are wrapped in a module that is included in subclass when they inherit from XMLMiniEngineTest. Pretty neat, huh?
-
由 Jon Moss 提交于
-
由 Jon Moss 提交于
-
由 Jon Moss 提交于
Created a new module (a la Action Cable subscription adapter's test suite) to be included in all sub class test to ensure compatability and reduce duplicated code.
-
由 Kasper Timm Hansen 提交于
When making the new command insfrastructure I had missed that `bin/rails runner some_file.rb some args` would pass the extra args onto the file in `ARGV`. Now fixed by allowing the command to take extra args again, and make sure to remove the file name from `ARGV`.
-
由 Kasper Timm Hansen 提交于
Fix prepared statements disabled test again
-
由 Prathamesh Sonpatki 提交于
- Due to `assert_nothing_raised` this test was not really testing anything. - So updated it to assert that the query gives expected result. - Also in general we can use `connection.unprepared_statement` for testing queries w/o prepared statements but it can't be used in this case. This test cases was added because when prepared_statements config is set to false, then DetermineIfPreparableVisitor module does not extended by Arel visitor resulting into an error. Ref: https://github.com/rails/rails/pull/22748. - Because DetermineIfPreparableVisitor module does not get added to the visitor chain only if prepared_statements is false while **setting up connection**, not when `unprepared_statement` is used. - I have also added an assertion for making sure that prepared_config is set to false from the start, so that nobody accidentally removes the connection setup using `arunit_without_prepared_statements` and replaces it with stubs or unprepared_statement.
-
由 Guillermo Iguaran 提交于
Do not rely on Ruby implementation in AM test
-
由 Guillermo Iguaran 提交于
Use existing --skip-turbolinks option for conditionals instead of checking if turbolinks is present in gemfile list
-
由 Kir Shatrov 提交于
Now a few tests in ActiveModel rely on Ruby implementation and the fact that in MRI `97.18` as a float is greater than `97.18` as a BigDecimal. This is only relevant for MRI. On JRuby, comparing float to BigDecimal would be conversion of them to the same type and they will be equal. I'd like the ActiveModel test suite to be Ruby implementation-agnostic. Here we test ActiveModel, not the Ruby internals. This PR fixes a couple more JRuby tests.
-
由 Jon Moss 提交于
Change html-scanner to rails-html-sanitizer
-
由 Jon Moss 提交于
[ci skip]
-
由 Jon Moss 提交于
Revert "fix typo in `match` doc [ci skip]"
-
由 Jon Moss 提交于
-
由 Guillermo Iguaran 提交于
fix typo in `match` doc [ci skip]
-
由 yuuji.yaginuma 提交于
s/Constrains/Constraints
-
由 Kasper Timm Hansen 提交于
Fix typo s/with/without/
-
由 Ryuta Kamizono 提交于
Follow up to #27109.
-
由 Eileen M. Uchitelle 提交于
Add missing test for singular resource output in rake routes
-
由 Kasper Timm Hansen 提交于
Fix tests for prepared_statements: false and queries hitting `#select_all`
-
由 Prathamesh Sonpatki 提交于
- The query needs to be executed for hitting `select_all` so made sure that query gets executed. - Also instead of changing instance variable, just add new configuration for prepared_statements: false and use it for this test. - This way we don't have to touch the internals of AR code and still disable prepared statements config for this test.
-
- 19 11月, 2016 11 次提交
-
-
由 Jon Moss 提交于
-
由 Jon Moss 提交于
Will help get rid of errors like the following: ``` 1) Error: JDOMEngineTest#test_order=: ArgumentError: wrong number of arguments (0 for 1) /Users/jon/code/rails/rails/activesupport/lib/active_support/core_ext/module/attribute_accessors.rb:106:in `test_order=' ```
-
由 Eileen M. Uchitelle 提交于
move CHANGELOG entry to the appropriate file [ci skip]
-
由 Prathamesh Sonpatki 提交于
- This test was present in https://github.com/rails/rails/pull/27089 but not present on master, may be removed in merge commit? - There was discussion about moving this to `application/rake_test` so may be this happened in merge commit. - https://github.com/rails/rails/pull/27089#discussion_r88731157
-
由 Matthew Draper 提交于
Fix the race condition caused by `with_new_connections_blocked`
-
由 yuuji.yaginuma 提交于
Follow up to #27098
-
由 Rafael Mendonça França 提交于
Fix incorrect output from rails routes when using singular resources …
-
由 Rafael França 提交于
Use secure source for gems referencing "github" in the generated apps
-
由 Erick Reyna 提交于
Rails routes (even rake routes in previous versions) output showed incorrect routes when an application use resource :controller, implying that edit_controller_path match with controller#show. The order of the output has changed to correct this. View #26606 for more information. Added a test case, change unit test in rake to expect the new output. Since the output of resource :controller is changing, the string spected of the railties/test/application/rake_test.rb test_rails_routes_with_controller_environment had to be modified.
-
由 Rafael Mendonça França 提交于
Fix unexpected session sharing
-
由 Tawan Sierek 提交于
Reset a new session directly after its creation in `ActionDispatch::IntegrationTest#open_session`. Reset the session to a clean state before making it available to the client's test code. Issue #22742 reports unexpected behavior of integration tests that run multiple sessions. For example an `ActionDispatch::Flash` instance is shared across multiple sessions, though a client code will rightfully assume that each new session has its own flash hash. The following test failed due to this behavior: class Issue22742Test < ActionDispatch::IntegrationTest test 'issue #22742' do integration_session # initialize first session a = open_session b = open_session refute_same(a.integration_session, b.integration_session) end end Instead of creating a new `ActionDispatch::Integration::Session` instance, the same instance is shared across all newly opened test sessions. This is due to the way how new test sessions are created in `ActionDispatch::IntegrationTest#open_session`. The already existing `ActionDispatch::IntegrationTest` instance is duplicated with `Object#dup`, This approach was introduced in commit 15c31c76. `Object#dup` copies the instance variables, but not the objects they reference. Therefore this issue only occurred when the current test instance had been tapped in such a way that the instance variable `@integration_session` was initialized before creating the new test session. Close #22742 [Tawan Sierek + Sina Sadeghian]
-
- 18 11月, 2016 6 次提交
-
-
由 Kasper Timm Hansen 提交于
remove Ruby warning from Active Job test helper methods
-
由 yuuji.yaginuma 提交于
This removes the following warnings. ``` /home/travis/build/rails/rails/activejob/lib/active_job/test_helper.rb:241: warning: shadowing outer local variable - job /home/travis/build/rails/rails/activejob/lib/active_job/test_helper.rb:265: warning: shadowing outer local variable - job ```
-
由 Prathamesh Sonpatki 提交于
- New apps generated on master and latest bundler give warning about "github" source being insecure. - Use the same solution used for Rails master in the generated app's Gemfile to fix this issue.
-
由 Ryuta Kamizono 提交于
`with_new_connections_blocked` was introduced at #14938. But the method sometimes causes `@new_cons_enabled = false` then never toggled to true.
-
由 Rafael França 提交于
Fixed CONTENT_LENGTH header in ActionController::TestRequest
-
由 Rafael França 提交于
Should except `:distinct` rather than `:order` for `exists?`
-