- 26 2月, 2019 16 次提交
-
-
由 Rafael Mendonça França 提交于
-
由 John Hawthorn 提交于
* Don't call inspect from identifier_method_name * Add locals Template#inspect Handler, formats, and variant are usually obvious from looking at the identifier. However it's not uncommon to have different locals for the same template so we should make that obvious in inspect. * Add tests for short_identifier and inspect [John Hawthorn + Rafael Mendonça França]
-
由 Aaron Patterson 提交于
Templates have one format
-
由 Aaron Patterson 提交于
Allow custom cache-control header in AC::Live
-
由 Aaron Patterson 提交于
Templates only have one format. Before this commit, templates would be constructed with a single element array that contained the format. This commit eliminates the single element array and just implements a `format` method. This saves one array allocation per template.
-
由 Aaron Patterson 提交于
No nil format on templates
-
由 Ryuta Kamizono 提交于
Co-Authored-By: Ntenderlove <tenderlove@github.com>
-
由 Aaron Patterson 提交于
-
由 Aaron Patterson 提交于
The format should always be exactly one symbol. Now we don't need to check whether or not the format is a `Type` in the constructor.
-
由 Aaron Patterson 提交于
This means we can eliminate nil checks and remove some mutations from the `decorate` method.
-
由 Rafael Mendonça França 提交于
-
由 Aaron Patterson 提交于
Support read queries with leading characters while preventing writes
-
由 Rafael Mendonça França 提交于
This is needed to fix #35278.
-
-
由 Ryuta Kamizono 提交于
Also, improving an argument error message for `limit`, extracting around `type_to_sql` code into schema statements, and more exercise tests.
-
由 Ryuta Kamizono 提交于
Fix prepared statements caching to be enabled even when query caching is enabled
-
- 25 2月, 2019 8 次提交
-
-
由 Ryuta Kamizono 提交于
Related cbcdecd2, 2a56b2d9. This is a regression caused by cbcdecd2. If query caching is enabled, prepared statement handles are never re-used, since we missed that a query is preprocessed when query caching is enabled, but doesn't keep the `preparable` flag. We should care about that case.
-
由 Ali Ibrahim 提交于
* The READ_QUERY regex would consider reads to be writes if they started with spaces or parens. For example, a UNION query might have parens around each SELECT - (SELECT ...) UNION (SELECT ...). * It will now correctly treat these queries as reads.
-
由 Ryuta Kamizono 提交于
activemodel typo fixes.
-
由 Ryuta Kamizono 提交于
Ensure `update_all` series doesn't care optimistic locking
-
由 alkesh26 提交于
-
由 Ryuta Kamizono 提交于
Incrementing the lock version invalidates any other process's optimistic lock, which is the desired outcome: the record no longer looks the same as it did when they loaded it.
-
由 Ryuta Kamizono 提交于
[ci skip] activejob typo fix.
-
由 alkesh26 提交于
-
- 24 2月, 2019 15 次提交
-
-
由 Ryuta Kamizono 提交于
Use "support/stubs/strong_parameters" instead.
-
由 Ryuta Kamizono 提交于
-
由 Ryuta Kamizono 提交于
-
由 Ryuta Kamizono 提交于
How to use `select` is updated [ci skip]
-
由 yuuji.yaginuma 提交于
Without this change, `store_translations` silently fails when available locales already initialized. Ref: https://travis-ci.org/rails/rails/jobs/497615616#L6846 https://travis-ci.org/rails/rails/jobs/497605027#L6856
-
由 soartec-lab 提交于
-
由 George Claghorn 提交于
Restore ActionDispatch::Http::UploadedFile compatibility with IO.copy_stream
-
由 Xavier Noria 提交于
We test the inflections for both autoloaders, but we can also autoload the constant as a sort of integration test.
-
由 Ryuta Kamizono 提交于
-
由 Ryuta Kamizono 提交于
-
由 Xavier Noria 提交于
[Harry Brundage & Xavier Noria]
-
由 Janko Marohnić 提交于
In https://github.com/rails/rails/pull/28676 the `#to_path` method was added to `ActionDispatch::Http::UploadedFile`. This broke usage with `IO.copy_stream`: source = ActionDispatch::Http::UploadedFile.new(...) IO.copy_stream(source, destination) # ~> TypeError: can't convert ActionDispatch::Http::UploadedFile to IO (ActionDispatch::Http::UploadedFile#to_io gives Tempfile) Normally `IO.copy_stream` just calls `#read` on the source object. However, when `#to_path` is defined, `IO.copy_stream` calls `#to_io` in order to retrieve the raw `File` object. In that case it trips up, because `ActionDispatch::Http::UploadedFile#to_io` returned a `Tempfile` object, which is not an `IO` subclass. We fix this by having `#to_io` return an actual `File` object.
-
由 Janko Marohnić 提交于
-
由 Ryuta Kamizono 提交于
minor grammar fix [ci skip]
-
由 Shivam Jain 提交于
-
- 23 2月, 2019 1 次提交
-
-
由 Xavier Noria 提交于
-