- 31 1月, 2014 1 次提交
-
-
由 Arthur Neves 提交于
This was a common pattern: ``` query = author.posts.select(:title) connection.select_one(query) ``` However `.select` returns a ActiveRecord::AssociationRelation, which has the bind information, so we can use that to get the right sql query. Also fix select_rows on postgress and sqlite3 that were not using the binds [fixes #7538] [fixes #12017] [related #13731] [related #12056]
-
- 14 1月, 2014 1 次提交
-
-
由 Cody Cutrer 提交于
-
- 24 12月, 2013 1 次提交
-
-
由 schneems 提交于
Building on the work of #13427 this PR adds a helpful error message to the adapters: mysql, mysql2, and sqlite3
-
- 12 12月, 2013 1 次提交
-
-
由 Josef Stribny 提交于
-
- 12 11月, 2013 2 次提交
-
-
由 Ben Woosley 提交于
This has returned true since 3cc9b5f1, and is not used internally.
-
由 Ben Woosley 提交于
Drop some comments that document the implementation rather than the interface.
-
- 10 11月, 2013 1 次提交
-
-
由 Rafael Mendonça França 提交于
-
- 09 11月, 2013 1 次提交
-
-
由 Yves Senn 提交于
The log output used to be confusing in situation where type casting has "unexpected" effects. For example when finding records with a `String`. BEFORE: irb(main):002:0> Event.find("im-no-integer") D, [2013-11-09T11:10:28.998857 #1706] DEBUG -- : Event Load (4.5ms) SELECT "events".* FROM "events" WHERE "events"."id" = $1 LIMIT 1 [["id", "im-no-integer"]] AFTER: irb(main):002:0> Event.find("im-no-integer") D, [2013-11-09T11:10:28.998857 #1706] DEBUG -- : Event Load (4.5ms) SELECT "events".* FROM "events" WHERE "events"."id" = $1 LIMIT 1 [["id", 0]]
-
- 14 10月, 2013 1 次提交
-
-
由 Vipul A M 提交于
Remove `default_primary_key_type` and extract contains of `native_database_types` to a constant since they aren't conditional now in SQLite3Adapter. Makes it more like other adapters.
-
- 30 9月, 2013 2 次提交
- 12 9月, 2013 1 次提交
-
-
由 Rafael Mendonça França 提交于
When the adapter is with prepared statement disabled and the binds array is not empty the connection adapter will try to set the binds values and will fail. Now we are checking if the adapter has the prepared statement disabled. Fixes #12023
-
- 11 8月, 2013 1 次提交
-
-
由 Vipul A M 提交于
-
- 09 8月, 2013 1 次提交
-
-
由 Vipul A M 提交于
-
- 06 8月, 2013 2 次提交
-
-
由 Rafael Mendonça França 提交于
This change was breaking the Railties tests. See https://travis-ci.org/rails/rails/jobs/9865969
-
由 schneems 提交于
If the `db/` directory is not present on a remote machine it will blow up in unexpected ways with error messages that do not indicate there is a missing directory: ``` SQLite3::CantOpenException: unable to open database file ``` This PR checks to see if a directory exists for the sqlite3 file and if not creates it for you. This PR is an alternative to #11692 as suggested by @josevalim
-
- 29 3月, 2013 1 次提交
-
-
由 Ranjay Krishna 提交于
added comments to test_invalid_type in sqlite3 adapter test and added valid_type? method to abstract_adapter.rb and removed unnecessary method from sqlite3 adapter
-
- 26 3月, 2013 1 次提交
-
-
由 Ranjay Krishna 提交于
Created a layer of abstraction for the valid type checking in schema dumper. Now, connection handles the check for valid types so that each database can handle the changes individually.
-
- 23 3月, 2013 1 次提交
-
-
由 Aaron Patterson 提交于
-
- 16 3月, 2013 1 次提交
-
-
由 Francesco Rodriguez 提交于
-
- 12 3月, 2013 1 次提交
-
-
由 Matthew M. Boedicker 提交于
To make quote escape binary data correctly it needs the column passed in.
-
- 08 3月, 2013 1 次提交
-
-
由 Cédric FABIANSKI 提交于
-
- 25 2月, 2013 1 次提交
-
-
由 Rafael Mendonça França 提交于
We should only type cast when we need to use. Related to 4b005fb3
-
- 21 2月, 2013 3 次提交
-
-
由 Yves Senn 提交于
When a table or a column is renamed related indexes kept their name. This will lead to confusing names. This patch renames related indexes when a column or a table is renamed. Only indexes with names generated by rails will be renamed. Indexes with custom names will not be renamed.
-
由 Yves Senn 提交于
-
由 Yves Senn 提交于
Some adapter (SQLite3) need to perform renaming operations to support the rails DDL. These rename prefixes operate with prefixes. When an index name already uses up the full space provieded by `index_name_length` these internal operations will fail. This patch introduces `allowed_index_name_length` which respects the amount of characters used for internal operations. It will always be <= `index_name_length` and every adapter can define how many characters need to be reserved.
-
- 16 2月, 2013 2 次提交
-
-
由 Jon Leighton 提交于
It was supposed to be removed by the preceding two reversions but I did them in the wrong order.
-
由 Jon Leighton 提交于
This reverts commit 5d528f83. Relates to f8c8ad56 which is also getting reverted due to failing test.
-
- 14 2月, 2013 1 次提交
-
-
由 Sam Ruby 提交于
-
- 12 2月, 2013 1 次提交
-
-
由 Ranjay Krishna 提交于
-
- 27 1月, 2013 1 次提交
-
-
由 Derek Kraan 提交于
because of an ambiguous column name. This happened if the association model had a default scope that referenced a third table, and the third table also referenced the original table (with an identical foreign_key). Mysql requires that ambiguous columns are deambiguated by using the full table.column syntax. Postgresql and Sqlite use a different syntax for updates altogether (and don't tolerate table.name syntax), so the fix requires always including the full table.column and discarding it later for Sqlite and Postgresql.
-
- 22 12月, 2012 1 次提交
-
-
由 Marc-Andre Lafortune 提交于
[#8267]
-
- 19 12月, 2012 1 次提交
-
-
由 Yves Senn 提交于
-
- 29 10月, 2012 2 次提交
-
-
由 Stefan Rusterholz 提交于
-
由 Yves Senn 提交于
-
- 29 9月, 2012 1 次提交
-
-
由 Jon Leighton 提交于
When inserting new records, only the fields which have been changed from the defaults will actually be included in the INSERT statement. The other fields will be populated by the database. This is more efficient, and also means that it will be safe to remove database columns without getting subsequent errors in running app processes (so long as the code in those processes doesn't contain any references to the removed column).
-
- 15 9月, 2012 2 次提交
-
-
由 kennyj 提交于
-
由 Jon Leighton 提交于
-
- 18 8月, 2012 1 次提交
-
-
由 Aaron Patterson 提交于
Fixes #7374
-
- 25 6月, 2012 1 次提交
-
-
由 Piotr Sarnacki 提交于
This commit needs to be reverted because it introduces difficulties when using sqlite3 in development and other databases in production. This happens because when you create time column in sqlite3, it's dumped as datetime in schema.rb file. This reverts commit 57d534ee, reversing changes made to 20f049fb. Conflicts: activerecord/test/cases/adapters/sqlite3/sqlite3_adapter_test.rb
-