- 02 4月, 2014 3 次提交
-
-
由 Yves Senn 提交于
- 01 4月, 2014 13 次提交
-
-
由 Rafael Mendonça França 提交于
PostgreSQL determine `Column#type` through corresponding OID. #7814
-
由 Yves Senn 提交于
I ran the whole test suite and compared the old to the new types. Following is the list of types that did change with this patch: ``` DIFFERENT TYPE FOR mood: NEW: enum, BEFORE: DIFFERENT TYPE FOR floatrange: NEW: floatrange, BEFORE: float ``` The `floatrange` is a custom type. The old type `float` was simply a coincidence form the name `floatrange` and our type-guessing.
-
由 Rafael Mendonça França 提交于
refactor assert_sql query to reuse capture_sql
-
由 eileencodes 提交于
set assert_sql to reuse the capture_sql method from above instead of repeating the code in response to comments on issue #14546
-
由 Aaron Patterson 提交于
Fix delete all to not produce sql in statement
-
由 eileencodes 提交于
When delete_all is run on a CollectionProxy and has a dependency of delete_all the SQL that is produced has an IN statement. (DELETE FROM `associated_model` where `associated_model` .`parent_id` = 1 AND `associated_model`.`id` IN (1, 2, 3...)). This only happens if the association is not loaded (both loaded and non-loaded delete_all should behave the same. This is a huge problem when it comes to deleting many records because the query becomes very slow. Instead the SQL produced should be (DELETE FROM `assoicated_model` where `associated_model`.`parent_model_id`=1). I fixed this by making sure the check for loaded and destroy also makes sure that the dependent is not delete_all, so the conditional goes to the else and deletes the records directly without the IN statement.
-
由 eileencodes 提交于
delete_all sql if an association is not loaded should behave the same as if the association is loaded. This test ensures the SQL statements are exactly the same.
-
由 eileencodes 提交于
Other methods compare specific patterns, this method outputs the actual sql query that is generated.
-
由 Guillermo Iguaran 提交于
Do not overwrite selected and disabled attributes
-
由 Laura Paredes 提交于
-
由 Rafael Mendonça França 提交于
Fix release task
-
由 Arthur Neves 提交于
Add a parentheses. related: b4c96490
-
由 Aaron Patterson 提交于
Fix polymorphic preloads on NOT NULL _type columns
-
- 31 3月, 2014 11 次提交
-
-
由 Yves Senn 提交于
We have `connection_adapters/column.rb` so it's easier to remember that the column in in a separate file.
-
由 Arun Agrawal 提交于
Tiny doc fix for Strong Parameters
-
由 Ian C. Anderson 提交于
- accepts_nested_attribute_for -> accepts_nested_attributes_for
-
由 thedarkone 提交于
The new method relies on AR::Associations::Association knowing about both reflection and a model class. AR::Base#association now raises a descriptive error when trying to access non-existent associations. Previously it would blow up with a confusing NoMethodError: undefined method `association_class' for nil:NilClass.
-
由 Rafael Mendonça França 提交于
remove calls to sql_type on pg columns
-
由 thedarkone 提交于
Defer to Association#klass instead of having a custom/duplicate code.
-
由 Laura Paredes 提交于
-
由 Luke Steensen 提交于
-
由 Rafael Mendonça França 提交于
Require yaml explicitly on #database_configuration
-
由 Luke Steensen 提交于
fixes #10613
-
由 Rafael Mendonça França 提交于
It is already called inside type_to_sql method.
-
- 30 3月, 2014 3 次提交
-
-
由 Yves Senn 提交于
Refactor test to use DdlHelper.
-
由 Adrià Planas 提交于
-
由 Guo Xiang Tan 提交于
Follow-Up to https://github.com/rails/rails/pull/14400 This ensures that all tables are removed after each test and thereby allowing us to run the tests in a random order.
-
- 29 3月, 2014 9 次提交
-
-
由 Yves Senn 提交于
append link to bad code when error type is SyntaxError
-
由 Yves Senn 提交于
Fix tests not unsubscribing from Notifications.
-
由 Xavier Noria 提交于
Ensure we are returning either `true` or `false` for `#==`
-
由 Vijay Dev 提交于
-
由 Vijay Dev 提交于
-
由 Godfrey Chan 提交于
460eb83d cused `ActiveRecord::Base#==` to sometimes return `nil` in some cases, this ensures we always return a boolean value. Also fixed a similar problem in AR reflections.
-
由 Xavier Noria 提交于
Replace trivial regexp with string or include, twice as fast
-
由 Kelley Reynolds 提交于
-
- 28 3月, 2014 1 次提交
-
-
由 Rafael Mendonça França 提交于
HashWithIndifferentAccess#update respects #to_hash
-