- 16 7月, 2019 2 次提交
-
-
由 Matthew Draper 提交于
Fix problem with accessing deprecated constant proxy's subclass
-
由 Ryuta Kamizono 提交于
Remove dead code in duplicable.rb
-
- 17 6月, 2019 1 次提交
-
-
由 Ryuta Kamizono 提交于
Delete method definition in rails that is compatible with ruby defini…
-
- 13 6月, 2019 1 次提交
-
-
由 Rafael França 提交于
Add missing file to require digest/uuid on active_support core ext
-
- 05 6月, 2019 2 次提交
-
-
由 John Hawthorn 提交于
Don't call listen with empty directory list
-
由 Kasper Timm Hansen 提交于
Fix EventedFileUpdateChecker through a symlink
-
- 01 6月, 2019 1 次提交
-
-
由 John Hawthorn 提交于
Fail parallel tests if workers exit early
-
- 26 5月, 2019 1 次提交
-
-
由 Ryuta Kamizono 提交于
Change comments [ci skip]
-
- 01 5月, 2019 1 次提交
-
-
由 Eileen M. Uchitelle 提交于
Revert changes to monotonic times
-
- 27 4月, 2019 1 次提交
-
-
由 Jordan Thomas 提交于
* Add test asserting truncate returns unfrozen string * Ensure strings returned from truncate are not frozen This fixes an issue where strings too short to be truncated were returned unfrozen, where as long-enough strings were returned frozen. Now retuned strings will not be frozen whether or not the string returned was shortened. * Update changelog w/ new truncate behavior description [Jordan Thomas + Rafael Mendonça França]
-
- 25 4月, 2019 1 次提交
-
-
由 Rafael Mendonça França 提交于
-
- 23 4月, 2019 1 次提交
-
-
由 Xavier Noria 提交于
This commit more or less undoes 9b5401fc, restores autoloaded? not to touch the descendants tracker, and autoloaded_constants because it is documented in the guide.
-
- 19 4月, 2019 9 次提交
-
-
由 Ryuta Kamizono 提交于
In #33325, `deprecate_methods` is replaced from `prepend` to completely emurated `alias_method_chain`, it exposed two internal methods `xxx_with_deprecation` and `xxx_without_deprecation`. After that, #34648 restored the `prepend` implementation, which doesn't expose any internal methods, so we no longer be able to ensure to always expose that internal methods. As I said at https://github.com/rails/rails/pull/33325#issuecomment-409016725, I think that internal methods exposed is not a specification but a limitation when using `alias_method_chain`, there is no longer a reason to follow that limitation.
-
由 Genadi Samokovarov 提交于
-
由 Genadi Samokovarov 提交于
-
由 Genadi Samokovarov 提交于
-
由 Genadi Samokovarov 提交于
-
由 Genadi Samokovarov 提交于
Actionable errors let's you dispatch actions from Rails' error pages. This can help you save time if you have a clear action for the resolution of common development errors. The de-facto example are pending migrations. Every time pending migrations are found, a middleware raises an error. With actionable errors, you can run the migrations right from the error page. Other examples include Rails plugins that need to run a rake task to setup themselves. They can now raise actionable errors to run the setup straight from the error pages. Here is how to define an actionable error: ```ruby class PendingMigrationError < MigrationError #:nodoc: include ActiveSupport::ActionableError action "Run pending migrations" do ActiveRecord::Tasks::DatabaseTasks.migrate end end ``` To make an error actionable, include the `ActiveSupport::ActionableError` module and invoke the `action` class macro to define the action. An action needs a name and a procedure to execute. The name is shown as the name of a button on the error pages. Once clicked, it will invoke the given procedure.
-
由 Steven Harman 提交于
There are four ways to pass the redis option, but only three were documented. This is now consistent with implementation. [ci skip]
-
由 r7kamura 提交于
-
由 Aric Walker 提交于
Resolves https://github.com/rails/rails/issues/35835 If an exception occurs during `parallelize_setup` make sure to catch that exception and apply it to the result of each successive test run. This results in marking all of the tests as failed to bring attention to the issue & ensure it is addressed before proceeding.
-
- 17 4月, 2019 3 次提交
-
-
由 Prathamesh Sonpatki 提交于
- Unused since https://github.com/rails/rails/commit/a91ea1d51048342d13f
-
由 okuramasafumi 提交于
-
由 Mauri Mustonen 提交于
-
- 16 4月, 2019 5 次提交
-
-
由 okuramasafumi 提交于
-
由 John Hawthorn 提交于
This way, we only need to filter the backtrace up to the first non-noise stack frame. This also updates noise to be able to deal with being passed a lazy enum. We don't need this anywhere, but it seemed better for this to be consistent.
-
由 Vishal Telangre 提交于
Remove @duration instance variable since we're not maintaining instances variables such as @cpu_time, @idle_time and @allocations; this reduces one allocation
-
由 Vishal Telangre 提交于
Use monotonic time to record `started` and `finished` time values for an event subscribed by a `ActiveSupport::Notifications::Fanout::Subscribers::Timed` subscriber
-
由 Vishal Telangre 提交于
Fix: #cpu_time doesn't work for a `ActiveSupport::Notifications::Fanout::Subscribers::Timed` subscriber
-
- 12 4月, 2019 3 次提交
-
-
由 David Verhasselt 提交于
When trying to call mget in Redis without any parameters, a Redis error is thrown. To avoid this, we circumvent Redis entirely when there are no key names given.
-
由 Ryuta Kamizono 提交于
It is newly added at 7b6b1054. ``` % be rubocop -a Inspecting 2781 files ...............................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................C............................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................. Offenses: activesupport/lib/active_support/dependencies/zeitwerk_integration.rb:12:1: C: [Corrected] Layout/EmptyLinesAroundBlockBody: Extra empty line detected at block body beginning. activesupport/lib/active_support/dependencies/zeitwerk_integration.rb:12:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. activesupport/lib/active_support/dependencies/zeitwerk_integration.rb:12:13: C: [Corrected] Style/RedundantBegin: Redundant begin block detected. begin ^^^^^ activesupport/lib/active_support/dependencies/zeitwerk_integration.rb:13:11: C: [Corrected] Layout/IndentationWidth: Use 2 (not 4) spaces for indentation. Rails.autoloaders.main.reload ^^^^ activesupport/lib/active_support/dependencies/zeitwerk_integration.rb:16:1: C: [Corrected] Layout/EmptyLinesAroundBlockBody: Extra empty line detected at block body end. activesupport/lib/active_support/dependencies/zeitwerk_integration.rb:16:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. 2781 files inspected, 6 offenses detected, 6 offenses corrected ```
-
由 Xavier Noria 提交于
The original message from Zeitwerk is "can't reload, please call loader.enable_reloading before setup (Zeitwerk::Error)", which is not very informative for Rails programmers. Rails should err with a message worded in terms of its interface.
-
- 09 4月, 2019 1 次提交
-
-
由 Xavier Noria 提交于
-
- 07 4月, 2019 1 次提交
-
-
由 Xavier Noria 提交于
-
- 04 4月, 2019 1 次提交
-
-
由 sushant 提交于
-
- 03 4月, 2019 2 次提交
-
-
由 Timo Schilling 提交于
-
由 Timo Schilling 提交于
-
- 01 4月, 2019 1 次提交
-
-
由 Timo Schilling 提交于
-
- 31 3月, 2019 1 次提交
-
-
由 Ryuta Kamizono 提交于
* add leading `#` before `=>` since hash rocket is valid Ruby code * add backticks * remove trailing spaces * and more
-
- 30 3月, 2019 1 次提交
-
-
由 Xavier Noria 提交于
-