- 03 2月, 2016 13 次提交
-
-
由 Prathamesh Sonpatki 提交于
-
由 Prathamesh Sonpatki 提交于
-
由 Sean Griffin 提交于
Prototype, you have served us well. But you are no longer how we make an XMLHttpRequest. RIP
-
由 Jon Moss 提交于
Use rails secret command in guides
-
由 Ryo Hashimoto 提交于
-
由 Rafael França 提交于
The minimum supported version of PostgreSQL is now >= 9.1
-
由 Remo Mueller 提交于
-
由 Arthur Nogueira Neves 提交于
Fix typo.
-
由 Zachary Smith 提交于
-
由 Eileen M. Uchitelle 提交于
Several ActionCable doc fixes
-
由 Nick Quaranto 提交于
* Properly indent code sample in ActionCable::Channel::Streams * Add a doc comment for #stop_all_streams * Reformat + add <tt> blocks around code references in ActionCable::Base docs * Clarify and a little better grammar on ActionCable::RemoteConnections * Correct indentation and clean up ActionCable::Server::Broadcasting code sample
-
由 Sean Griffin 提交于
There was a typo in the variable name leading to infinite recursion
-
由 Sean Griffin 提交于
We had previously updated this to attempt to map over whatever was passed in, so that additional types like range and array could benefit from this behavior without the time zone converter having to deal with every known type. However, the default behavior of a type is to just yield the given value to `map`, which means that if we don't actually know how to handle a value, we'll just recurse infinitely. Since both uses of `map` in this case occur in cases where we know receiving the same object will recurse, we can just break on reference equality. Fixes #23241.
-
- 02 2月, 2016 27 次提交
-
-
由 Sean Griffin 提交于
Remove unnecessary overriding of `#initialize`
-
由 Kasper Timm Hansen 提交于
Change command_task.rb to commands_task.rb in docs
-
由 Ryan Nielson 提交于
The initialization documentation references `rails/commands/command_task.rb`. This appears to be a typo as the file is actually `rails/commands/commands_task.rb`.
-
由 yui-knk 提交于
`#initialize` of `HasManyReflection`, `HasOneReflection` and `BelongsToReflection` only pass all arguments to `super` by passed order. These overriding can be removed.
-
由 Rafael França 提交于
Warn if a named scope is overwriting an existing scope or method
-
由 Rafael França 提交于
move `test_generator_if_skip_action_cable_is_given_for_an_api_app` to the appropriate file
-
由 yuuji.yaginuma 提交于
Test of Rails API should be in `api_app_generator_test.rb`.
-
由 Rafael França 提交于
Duplicate assert_generates options before modifying it
-
由 Rafael França 提交于
Fix regression in `Hash#dig` for HashWithIndifferentAccess.
-
由 Jon Moss 提交于
-
由 Aaron Patterson 提交于
Generated engines should call `protect_from_forgery`. If this method isn't called, then the Engine could be susceptible to XSS attacks. Thanks @tomekr for reporting this to us!
-
由 Akira Matsuda 提交于
-
由 Claudio B 提交于
Update CHANGELOG.md
-
由 Kang-Kyu Lee 提交于
fix indentation to show it as code
-
由 Rafael Mendonça França 提交于
And improve changelongs. [ci skip]
-
由 Sean Griffin 提交于
-
由 Jeremy Daer 提交于
Fix corrupt transaction state caused by `before_commit` exceptions
-
由 Kasper Timm Hansen 提交于
Solves personal insanity, since I was down in these files. (Please don't submit PRs like this.)
-
由 Kasper Timm Hansen 提交于
Some places were saying filter, while others said filter_options, spare the ambiguity and use filter throughout. This inlines a needless local variable and clarifies a route filter consists of defaults and values to match against.
-
由 Jeremy Daer 提交于
When a `before_commit` callback raises, the database is rolled back but AR's record of the current transaction is not, leaving the connection in a perpetually broken state that affects all future users of the connection: subsequent requests, jobs, etc. They'll think a transaction is active when none is, so they won't BEGIN on their own. This manifests as missing `after_commit` callbacks and broken ROLLBACKs. This happens because `before_commit` callbacks fire before the current transaction is popped from the stack, but the exception-handling path they hit assumes that the current transaction was already popped. So the database ROLLBACK is issued, but the transaction stack is left intact. Common cause: deadlocked `#touch`, which is now implemented with `before_commit` callbacks. What's next: * We shouldn't allow active transaction state when checking in or out from the connection pool. Verify that conns are clean. * Closer review of txn manager sad paths. Are we missing other spots where we'd end up with incorrect txn state? What's the worst that can happen if txn state drifts? How can we guarantee it doesn't and contain the fallout if it does? Thanks for @tomafro for expert diagnosis!
-
由 Kasper Timm Hansen 提交于
Assume the filter is a string, if it wasn't a hash and isn't nil. Remove needless else and rely on Ruby's default nil return. Add spaces within hash braces.
-
由 Kasper Timm Hansen 提交于
Add options for rake routes task
-
由 Sean Griffin 提交于
This reverts commit 9f3730a5, reversing changes made to 2637fb75. There are additional issues with this commit that need to be addressed before this change is ready (see #23377). This is a temporary revert in order for us to have more time to address the issues with that PR, without blocking the release of beta2.
-
由 Matthew Draper 提交于
Address remaining known issues in Interlock
-
由 Vipul A M 提交于
.git added to https repo urls
-
由 Vishnu Ks 提交于
-
由 Rafael França 提交于
Add documentation for #17573
-