1. 20 2月, 2016 1 次提交
    • K
      Add methods to array delegation from `Relation` · 95c24e9f
      Kevin Dougherty 提交于
      Delegation of some `Array` methods was removed in commit 9d79334a. That
      change did add explicit delegation of a few methods that `Array` has but
      which aren't on `Enumerable`.  However, a few non-mutation methods were
      omitted.  This adds `Array` delegation of `#in_groups`, `#in_groups_of`,
      `#shuffle` and `#split`.  This allows things like
      `MyThing.all.in_groups_of(3) { ... }` to continue working as they did
      before commit 9d79334a.
      95c24e9f
  2. 18 2月, 2016 3 次提交
  3. 17 2月, 2016 5 次提交
    • R
      Remove needless `case_insensitive_comparison` in mysql2 adapter · 4da96789
      Ryuta Kamizono 提交于
      Simply it is sufficient to override `can_perform_case_insensitive_comparison_for?`.
      4da96789
    • P
      Show proper error message when a non-relation object is passed to AR::Relation#or · e254665a
      Prathamesh Sonpatki 提交于
      - Previously it used to show error message
          <"undefined method `limit_value' for {:title=>\"Rails\"}:Hash">
      
      - Now it shows following error message.
      
          >> Post.where.not(name: 'DHH').or(name: 'Tenderlove')
          ArgumentError: You have passed Hash object to #or. Pass an ActiveRecord::Relation object instead.
      
      - Fixes #23714.
      e254665a
    • A
      Fix semantics of test names for finish option in batches_test · b13a00ed
      Akshay 提交于
      - The change was added in #23099
      b13a00ed
    • P
      Fixed `where` for polymorphic associations when passed an array containing different types. · 359adaed
      Philippe Huibonhoa 提交于
      When passing in an array of different types of objects to `where`, it would only take into account the class of the first object in the array.
      
          PriceEstimate.where(estimate_of: [Treasure.find(1), Car.find(2)])
      	# => SELECT "price_estimates".* FROM "price_estimates"
               WHERE ("price_estimates"."estimate_of_type" = 'Treasure' AND "price_estimates"."estimate_of_id" IN (1, 2))
      
      This is fixed to properly look for any records matching both type and id:
      
          PriceEstimate.where(estimate_of: [Treasure.find(1), Car.find(2)])
          # => SELECT "price_estimates".* FROM "price_estimates"
               WHERE (("price_estimates"."estimate_of_type" = 'Treasure' AND "price_estimates"."estimate_of_id" = 1)
               OR ("price_estimates"."estimate_of_type" = 'Car' AND "price_estimates"."estimate_of_id" = 2))
      359adaed
    • D
      Test parent local_stored_attributes isn't modified · 72eee06b
      David Genord II 提交于
      Saw the `merge!` and had to prove to myself that the parent model's local_stored_attributes was not being changed when stored_attributes is called on a child model. Proved to be working as expected but this test is probably still useful to keep around.
      72eee06b
  4. 16 2月, 2016 2 次提交
    • V
      Add missing CHANGELOG for regression fix in #18155 which fixes #13387 · 8d3912ac
      Vipul A M 提交于
      [ci skip]
      8d3912ac
    • G
      Let t.foreign_key use the same `to_table` twice · aedde2a3
      George Millo 提交于
      Previously if you used `t.foreign_key` twice within the same
      `create_table` block using the same `to_table`, all statements except
      the final one would fail silently. For example, the following code:
      
          def change
            create_table :flights do |t|
              t.integer :from_id, index: true, null: false
              t.integer :to_id,   index: true, null: false
      
              t.foreign_key :airports, column: :from_id
              t.foreign_key :airports, column: :to_id
            end
          end
      
      Would only create one foreign key, on the column `from_id`.
      
      This commit allows multiple foreign keys to the same table to be created
      within one `create_table` block.
      aedde2a3
  5. 14 2月, 2016 1 次提交
  6. 13 2月, 2016 4 次提交
  7. 11 2月, 2016 5 次提交
    • S
      Ensure prepared statement caching still occurs with Adequate Record · 2a56b2d9
      Sean Griffin 提交于
      In Rails 5, we're much more restrictive about when we do or don't cache
      a prepared statement. In particular, we never cache when we are sending
      an IN statement or a SQL string literal
      
      However, in the case of Adequate Record, we are *always* sending a raw
      SQL string, and we *always* want to cache the result.
      
      Fixes #23507
      
      /cc @tgxworld
      2a56b2d9
    • Y
      remove warnings from FinderMethods · 424b2019
      yuuji.yaginuma 提交于
      This removes the following warnings.
      
      ```
      activerecord/lib/active_record/relation/finder_methods.rb:252: warning: ambiguous first argument; put parentheses or a space even after `-' operator
      activerecord/lib/active_record/relation/finder_methods.rb:258: warning: ambiguous first argument; put parentheses or a space even after `-' operator
      activerecord/lib/active_record/relation/finder_methods.rb:268: warning: ambiguous first argument; put parentheses or a space even after `-' operator
      activerecord/lib/active_record/relation/finder_methods.rb:274: warning: ambiguous first argument; put parentheses or a space even after `-' operator
      ```
      424b2019
    • A
      build scope chain functionally and remove caching · 3553fe03
      Aaron Patterson 提交于
      This commit walks the reflection tree and builds the scope chain
      functionally.  It also removes the chain cache since the cache doesn't
      seem to have any impact on performance (I'd prefer to only cache at
      proven bottlenecks)
      3553fe03
    • B
      eaa1efe7
    • B
      rename to 'second_to_last' and 'third_to_last' · e8aeda2a
      Brian Christian 提交于
      e8aeda2a
  8. 10 2月, 2016 2 次提交
  9. 09 2月, 2016 1 次提交
    • R
      Addresses #23568 · 91c13624
      Ryan T. Hosford 提交于
        - Corrects an incorrect exception message when using accepts_nested_attributes_for
        - Removes rescue/reraise behavior introduced in #19077
        - Adds has_many & has_one, nested_attributes test case specifying the message that
          should be conveyed with an exception raised because one of the nested attributes provided is unknown
      91c13624
  10. 08 2月, 2016 2 次提交
  11. 07 2月, 2016 2 次提交
    • V
      fix indentation · 87f060a7
      Vijay Dev 提交于
      87f060a7
    • M
      Added numeric helper into migrations. · aa38f7d6
      Mehmet Emin İNAÇ 提交于
      With this addition, you can add a column into the table like:
      
      ```
        create_table(:numeric_types) do |t|
          t.numeric :foo, precision: 10, scale: 2, default: 2.0
        end
      ```
      
      The result of the migration above is same with:
      
      ```
        create_table(:numeric_types) do |t|
          t.decimal :foo, precision: 10, scale: 2, default: 2.0
        end
      ```
      aa38f7d6
  12. 06 2月, 2016 5 次提交
  13. 05 2月, 2016 2 次提交
  14. 04 2月, 2016 5 次提交