1. 09 3月, 2017 1 次提交
    • E
      Refactor system test driver/browser · 4dbebe48
      eileencodes 提交于
      Since using a browser is only for selenium it doesn't really make sense
      to have a separate class for handling it there. This brings a lot of the
      if/else out of the main SystemTestCase class and into the Driver class
      so we can abstract away all that extra work.
      4dbebe48
  2. 08 3月, 2017 1 次提交
  3. 06 3月, 2017 1 次提交
  4. 04 3月, 2017 1 次提交
    • Y
      Do not take screenshot if driver does not support screenshot · 2ee4058c
      yuuji.yaginuma 提交于
      `Capybara::RackTest::Driver` does not support taking screenshots. If call
      `#save_screenshot` on `Capybara::RackTest::Driver` will raise the error.
      
      ```ruby
      Error:
      UsersTest#test_visiting_the_index:
      Capybara::NotSupportedByDriverError: Capybara::Driver::Base#save_screenshot
      ```
      
      To prevent errors, if driver does not support screenshot, do not call it.
      2ee4058c
  5. 26 2月, 2017 1 次提交
    • A
      Commit flash changes when using a redirect route. · 558336ee
      Andrew White 提交于
      In ca324a0d the flash middleware was effectively removed by its
      constructor returning the app it was passed and the `commit_flash`
      call was moved to the `ActionController::Metal#dispatch` method.
      This broke any redirect routes that modified the flash because the
      redirect happens before `dispatch` gets called.
      
      To fix it, this commit adds a `commit_flash` call in the `serve`
      method of `ActionDispatch::Routing::Redirect`.
      
      Fixes #27992.
      558336ee
  6. 25 2月, 2017 2 次提交
  7. 23 2月, 2017 2 次提交
  8. 22 2月, 2017 1 次提交
  9. 21 2月, 2017 19 次提交
    • A
      Split direct method into two · d7c1e62c
      Andrew White 提交于
      Use a separate method called `resolve` for the custom polymorphic
      mapping to clarify the API.
      d7c1e62c
    • A
      Removed `model_name` method to prevent warning · 050d7b1b
      Andrew White 提交于
      050d7b1b
    • A
      Support mapping of non-model classes · 81a6761a
      Andrew White 提交于
      81a6761a
    • A
      Raise an error if `direct` is inside a scope block · 80dcfd01
      Andrew White 提交于
      80dcfd01
    • A
      Add custom polymorphic mapping · 3bf47b01
      Andrew White 提交于
      Allow the use of `direct` to specify custom mappings for polymorphic_url, e.g:
      
        resource :basket
        direct(class: "Basket") { [:basket] }
      
      This will then generate the following:
      
        >> link_to "Basket", @basket
        => <a href="/basket">Basket</a>
      
      More importantly it will generate the correct url when used with `form_for`.
      
      Fixes #1769.
      3bf47b01
    • A
      Add test for calling a url helper in Mapper#direct · d67e2520
      Andrew White 提交于
      d67e2520
    • A
      Only accept symbols and strings for Mapper#direct · e96da0a7
      Andrew White 提交于
      e96da0a7
    • A
      Rename url_helper to direct · 47a27e89
      Andrew White 提交于
      47a27e89
    • A
      Add support for defining custom url helpers in routes.rb · ce7d5fb2
      Andrew White 提交于
      Allow the definition of custom url helpers that will be available
      automatically wherever standard url helpers are available. The
      current solution is to create helper methods in ApplicationHelper
      or some other helper module and this isn't a great solution since
      the url helper module can be called directly or included in another
      class which doesn't include the normal helper modules.
      
      Reference #22512.
      ce7d5fb2
    • E
      Fix default host in setup, move teardown to helper file · 161cf89e
      eileencodes 提交于
      * Override integration test default host
      
      Integration tests automatically set the default host to
      'http://example.com'. This works fine for integration tests because they
      are not real browser sessions, but doesn't work fine for system tests
      because they are real browser sessions.
      
      We can override this by setting the `host!` in `before_setup. The
      `Capybara.always_include_port` will allow the test to look at
      `127.0.0.1:port capybara picks` and properly redirect the test.
      
      Any application can override this by setting the `host!` in
      their system test helper. Generally though, applications are going to be
      using localhost.
      
      In this commit I also moved the setup and teardown into their own module
      for tidiness.
      
      * Move teardown settings into system test case
      
      These configuration options can be put into the system test case file
      instead of the generated system tests helper file. This is an
      implementation detail and therefore shouldn't be generated with the
      template.
      161cf89e
    • E
      Fix screenshot helper to provide correct file name · 983275eb
      eileencodes 提交于
      We only want the file name to include the word `failures` if it failed,
      not any time the user wants to take a screenshot during a test run.
      983275eb
    • E
      Move and rename system tests · 1a0ca84a
      eileencodes 提交于
      * Move system tests back into Action Pack
      * Rename `ActionSystemTest` to `ActionDispatch::SystemTestCase`
      * Remove private base module and only make file for public
      `SystemTestCase` class, name private module `SystemTesting`
      * Rename `ActionSystemTestCase` to `ApplicationSystemTestCase`
      * Update corresponding documentation and guides
      * Delete old `ActionSystemTest` files
      1a0ca84a
    • E
      Turn system testing into it's own gem and rename · 5bf0aa67
      eileencodes 提交于
      Renames `Rails::SystemTestCase` to `ActionSystemTest` and moves it to a
      gem under the Rails name.
      
      We need to name the class `ActionSystemTestCase` because the gem expects
      a module but tests themselves expect a class.
      
      Adds MIT-LICENSE, CHANGELOG, and README for the future.
      5bf0aa67
    • E
      Appease Rubocop · a21e18d5
      eileencodes 提交于
      Rubocop / code climate don't like single quotes and prefer doubles.
      a21e18d5
    • E
      Refactor so all drivers use Puma by default · c83e6d36
      eileencodes 提交于
      Puma is the default webserver of Rails. Because of this it doesn't make
      sense to run tests in Webkit if the default server is Puma.
      
      Here I've refactored the webserver to be it's own standalone module so
      it can be shared between Rails' selenium default driver and Capybara's
      defaut drivers.
      c83e6d36
    • E
      Add support for screenshots · e9127f7a
      eileencodes 提交于
      This change adds support, tests, and documentation for the screenshot
      helper.
      
      If taking screenshots is supported by the driver (for example Rack Test
      doesn't support screenshots) then a screenshot will be taken if the test
      fails.
      e9127f7a
    • E
      Reconfigure how the drivers work · f482eddb
      eileencodes 提交于
      This removes the useless Rack Test Driver that Rails was providing and
      moves to a shim like approach for default adapters.
      
      If someone wants to use one of the default Capybara Drivers then we will
      initialize a new `CapybaraDriver` that simply sets the default driver.
      
      Rails though is much more opinionated than Capybara and to make system
      testing a "works out of the box" framework in Rails we have the
      `RailsSeleniumDriver`. This driver sets defaults that Rails deems
      important for selenium testing. The purpose of this is to simply add a
      test and it just works.
      f482eddb
    • E
      Add tests for system testing · 9730b1db
      eileencodes 提交于
      * Adds test case test
      * Adds driver adapter test
      * Adds tests for capybara seleium driver (testing the settings not
      actually opening the browser to test capybara w/ selenium because that
      would so so so slow)
      * Adds tests for rack test driver
      * Adds tests for generators
      9730b1db
    • M
      Use `response#location` instead of `#location` in redirect. · ca779986
      Mehmet Emin INAC 提交于
      Closes #28033
      ca779986
  10. 20 2月, 2017 1 次提交
  11. 12 2月, 2017 1 次提交
  12. 06 2月, 2017 1 次提交
    • B
      Correct spelling · c8b5d828
      Benjamin Fleischer 提交于
      ```
      go get -u github.com/client9/misspell/cmd/misspell
      misspell  -w -error -source=text .
      ```
      c8b5d828
  13. 02 2月, 2017 1 次提交
    • A
      Properly escape test names · f21c2492
      Akira Matsuda 提交于
      since the test names become Regexp filters, non-escaped test names cause RegexpError on isolated test via bin/test
      f21c2492
  14. 01 2月, 2017 1 次提交
  15. 24 1月, 2017 1 次提交
    • D
      Delete PATH_INFO after each controller test request · 13c7f2b5
      Dominic Cleal 提交于
      Prevents PATH_INFO from being used to infer the request format in later
      test requests when no explicit format is given.
      
      As the request PATH_INFO may be set before a request, it can't be
      deleted during pre-request scrubbing.
      
      Fixes #27774
      13c7f2b5
  16. 19 1月, 2017 1 次提交
  17. 18 1月, 2017 3 次提交
  18. 17 1月, 2017 1 次提交