1. 09 3月, 2017 1 次提交
    • E
      Refactor system test driver/browser · 4dbebe48
      eileencodes 提交于
      Since using a browser is only for selenium it doesn't really make sense
      to have a separate class for handling it there. This brings a lot of the
      if/else out of the main SystemTestCase class and into the Driver class
      so we can abstract away all that extra work.
      4dbebe48
  2. 08 3月, 2017 3 次提交
  3. 06 3月, 2017 3 次提交
  4. 05 3月, 2017 4 次提交
    • R
      Fix CI failure due to contain <U+2028> · 660e189c
      Ryuta Kamizono 提交于
      ```diff
      diff --git a/actionpack/lib/action_controller/metal/redirecting.rb b/actionpack/lib/action_controller/metal/redirecting.rb
      index a3159c29dd..1836a07d4e 100644
      --- a/actionpack/lib/action_controller/metal/redirecting.rb
      +++ b/actionpack/lib/action_controller/metal/redirecting.rb
      @@ -50,8 +50,8 @@ module Redirecting
           #   redirect_to post_url(@post), status: 301, flash: { updated_post_id: @post.id }
           #   redirect_to({ action: 'atom' }, alert: "Something serious happened")
           #
      -    # Statements after redirect_to in our controller get executed, so redirect_to doesn't stop the execution of the function.
      -    <U+2028># To terminate the execution of the function immediately after the redirect_to, use return.
      +    # Statements after +redirect_to+ in our controller get executed, so +redirect_to+ doesn't stop the execution of the function.
      +    # To terminate the execution of the function immediately after the +redirect_to+, use return.
           #   redirect_to post_url(@post) and return
           def redirect_to(options = {}, response_status = {})
             raise ActionControllerError.new("Cannot redirect to nil!") unless options
      ```
      
      https://travis-ci.org/rails/rails/jobs/207908041#L549
      660e189c
    • E
      Revert "Add a changelog entry for #28284 [ci skip]" · 0a7e91ab
      eileencodes 提交于
      This reverts commit 84c1b107.
      
      Reverted #28283 so reverted it's changelog update as well.
      0a7e91ab
    • E
      Revert "Merge pull request #28283 from y-yagi/silence_puma_startup_messages_in_system_test" · fea0c351
      eileencodes 提交于
      This reverts commit 0d73f911, reversing
      changes made to 21ff8a49.
      
      We don't want to silence Puma because it's start up messages can be
      useful (to see threads, port etc). #28109 was instead fixed by not
      running system tests by defaul with `bin/rails test` in #28286.
      fea0c351
    • T
      [ci skip] Fix ParameterMissing exception name in docs · 609bf1ac
      Tejas Bubane 提交于
      Should be `ActionController::ParameterMissing` and not
      `ActionController::MissingParameter`.
      
      Corresponding change was done in guides in
      https://github.com/rails/rails/pull/9816.
      609bf1ac
  5. 04 3月, 2017 5 次提交
  6. 03 3月, 2017 1 次提交
  7. 28 2月, 2017 1 次提交
    • Y
      Take failed screenshot before reset driver · 3da239a2
      yuuji.yaginuma 提交于
      Now reset the driver before take failed screenshot since #28144.
      However, I think that failed screenshot should be take with the driver
      actually used in the test.
      So, fixed to take screenshot before reset driver.
      3da239a2
  8. 26 2月, 2017 2 次提交
    • J
      Remove unused params. · 6ddd65c9
      Jerry Tao 提交于
      6ddd65c9
    • A
      Commit flash changes when using a redirect route. · 558336ee
      Andrew White 提交于
      In ca324a0d the flash middleware was effectively removed by its
      constructor returning the app it was passed and the `commit_flash`
      call was moved to the `ActionController::Metal#dispatch` method.
      This broke any redirect routes that modified the flash because the
      redirect happens before `dispatch` gets called.
      
      To fix it, this commit adds a `commit_flash` call in the `serve`
      method of `ActionDispatch::Routing::Redirect`.
      
      Fixes #27992.
      558336ee
  9. 25 2月, 2017 3 次提交
  10. 24 2月, 2017 2 次提交
  11. 23 2月, 2017 3 次提交
  12. 22 2月, 2017 5 次提交
  13. 21 2月, 2017 7 次提交