Add destroyed? to ActiveRecord, include tests for polymorphic urls for destroyed objects and refactor mime responds tests and documentation.

Some databases (e.g. Oracle) does not allow "AS" between table name and table alias name, for others it is optional

always sort lists by id before comparison to avoid errors because of different sorting of same results (on Oracle database)

Oracle stores '' string as NULL
Oracle cannot have identifiers larger than 30 characters
added missing fixtures to test setup method

Fixed adapter test cases that were failing in oracle because the asserts were looking for the presence of offset and limit which are not available in oracle. Changed the tests to check that the sql injection is not present in the output so that the tests are database adapter agnostic.

Revert "fallback_string_to_date sets Date._parse comp arg to true, so that strings with two-digit years, e.g. '1/1/09', are interpreted as modern years" [#2019 state:wontfix]

This reverts commit 55d1d12c.

Added reset_attribute! method to ActiveRecord::AttributeMethods::Dirty which will reset an attribute to its original value should it have changed.
Signed-off-by: NJoshua Peek <josh@joshpeek.com>

Modified ActiveRecord::AttributeMethods to allow classes to specify attribute method prefixes and/or suffixes. Previously only suffixes were allowed.
Signed-off-by: NJoshua Peek <josh@joshpeek.com>

fallback_string_to_date sets Date._parse comp arg to true, so that strings with two-digit years, e.g. '1/1/09', are interpreted as modern years [#2019 state:resolved]

quoted_date converts time-like objects to ActiveRecord::Base.default_timezone before serialization. This allows you to use Time.now in find conditions and have it correctly be serialized as the current time in UTC when default_timezone == :utc [#2946 state:resolved]

Revert "Methods invoked within named scope Procs should respect the scope stack. [#1267 state:resolved]"

This reverts commit 6a133765.

Conflicts:

	activerecord/test/cases/named_scope_test.rb

Patch to ActiveModel's (and ActiveRecord, by association) XML serialization: If two parameters are present in Procs supplied to to_xml's :procs option, the model being serialized will be passed as the second argument [#2373 state:resolved]
Signed-off-by: NJoshua Peek <josh@joshpeek.com>

[#765 state:committed]
Signed-off-by: NJeremy Kemper <jeremy@bitsweat.net>

Make it so AR attributes which conflict with object-private methods (e.g. system) don't 'randomly' cause NoMethodErrors

Previously if you called this attribute before others, you'd get exceptions.  But if it was the second-or-subsequent attribute you retrieved you'd get the correct behaviour.
Signed-off-by: NMichael Koziarski <michael@koziarski.com>
[#2808 state:committed]

Add support for dumping non-standard primary keys when using the SQLite3 adapter. Fix unit tests so that this feature is tested for all adapters. [#2868 state:resolved]
Signed-off-by: NYehuda Katz <wycats@yehuda-katzs-macbookpro41.local>

Signed-off-by: NYehuda Katz + Carl Lerche <ykatz+clerche@engineyard.com>

Revert "Revert "Generate proper :counter_sql from :finder_sql when there is a newline character immediately following 'SELECT' [#2118 state:resolved]""

This reverts commit 80f1f863.

The feature doesn't work on Postgres, so don't test it on Postgres.
Also, Postgres compatibility is irrelevant to the ticket/patch in question.

This gives you 'Post comment' rather than 'Postcomment' by default.
Signed-off-by: NMichael Koziarski <michael@koziarski.com>
[#2120 state:committed]

Signed-off-by: NMichael Koziarski <michael@koziarski.com>

Translate adapter errors that indicate a violated uniqueness constraint to ActiveRecord::RecordNotUnique exception derived from ActiveReecord::StatementInvalid.
Signed-off-by: NMichael Koziarski <michael@koziarski.com>

Revert "Generate proper :counter_sql from :finder_sql when there is a newline character immediately following 'SELECT' [#2118 state:resolved]"

This reverts commit 4851ca9e.

The tests do not pass for postgresql.