- 02 3月, 2016 1 次提交
-
-
由 Jon Moss 提交于
Fixes #22675 Allow channel identifiers and also data with no backslahes/escaping to be accepted by the subscription storer.
-
- 01 3月, 2016 3 次提交
-
-
由 Matthew Draper 提交于
-
由 Daniel Rhodes 提交于
This change makes ping into a message type, which makes the whole protocol a lot more consistent. Also fixes hacks on the client side to make this all work.
-
由 Daniel Rhodes 提交于
-
- 28 2月, 2016 1 次提交
-
-
由 Arthur Neves 提交于
-
- 25 2月, 2016 4 次提交
-
-
由 Jon Moss 提交于
Fixes #23471
-
由 Jay Hayes 提交于
Similar to the channel streaming side, these values must be strings for ActionCable to behave as expected. The conversion will allow users to send string-convertible values and get the expected behavior.
-
由 Jay Hayes 提交于
ActionCable does some things behind the scenes that expects these "broadcasting"s or "channel"s to be strings. However it's not immediately obvious that the value must be a string. So adding this conversion ensures things work as expected.
-
由 Jay Hayes 提交于
-
- 23 2月, 2016 2 次提交
-
-
由 Pratik Naik 提交于
-
-
- 19 2月, 2016 2 次提交
-
-
由 Jon Moss 提交于
Before this commit, the `unsubscribed` callbacks in Action Cable server side channels were never called. This is because when a WebSocket "goodbye" message was sent from the client, the Action Cable server didn't properly clean up after the now closed WebSocket. This means that memory could possibly skyrocket with this behavior, since part of this commit is to properly remove closed subscriptions from the global subscriptions hash. Say you have 10,000 users currently connected, and then all 10,000 disconnect -- before this patch, Action Cable would still hold onto information (and Ruby objects!) for all of these now dead connections.
-
由 Matthew Draper 提交于
The Event hack was too much of a hack: on actually thinking about it, there's a rather obvious race.
-
- 15 2月, 2016 3 次提交
-
-
由 Kasper Timm Hansen 提交于
The `WorkerTest`'s `Receiver` is imporsonating an `ActionCable::Connection::Base`, but just delegates the logger to `ActionCable.logger`. This creates a mismatch as the connection requires the logger to be a `TaggedLoggerProxy`'ied logger, while the server doesn't. Thus to ensure an exception isn't raised when the worker tries to call `tag` other tests have to assign a proxied logger to their test server. Instead of forcing change on other tests, have Receiver adhere to the connection contract and use a `TaggedLoggerProxy`. As a consequence remove more setup from the tests.
-
由 Kasper Timm Hansen 提交于
Instead of depending on ApplicationCable::Connection being defined at initialize we should inject it in the Railtie. Thus we can kill more setup in the tests too.
-
由 Kasper Timm Hansen 提交于
We were explicitly referencing Rails.root in ActionCable::Server::Configuration.initialize, thereby coupling ourselves to Rails. Instead add `app/channels` to Rails' app paths and assign the existent files to `channel_paths`. Users can still append to those load paths with `<<` and `push` in `config/application.rb`. This means we can remove the custom `Dir` lookup in `channel_paths` and the Rails and root definitions in the tests.
-
- 05 2月, 2016 1 次提交
-
-
由 David Heinemeier Hansson 提交于
-
- 01 2月, 2016 2 次提交
-
-
由 Jon Moss 提交于
-
由 Matthew Draper 提交于
-
- 31 1月, 2016 1 次提交
-
-
由 Matthew Draper 提交于
This new adapter does get a little more intimate with the redis-rb gem's implementation than I would like, but it's the least bad of the approaches I've come up with.
-
- 30 1月, 2016 8 次提交
-
-
由 Matthew Draper 提交于
The detach used by close! seems to be making EM very sad on Travis.
-
由 Matthew Draper 提交于
It's not strictly necessary, and maybe this will help with the current test failure.
-
由 Matthew Draper 提交于
We may still try to send to it.
-
由 Matthew Draper 提交于
-
由 Matthew Draper 提交于
-
由 Matthew Draper 提交于
Also, address the possibility of the listen thread dying and needing to be respawned. As a bonus, we now defer construction of the thread until we are first given something to monitor.
-
由 Matthew Draper 提交于
-
由 Matthew Draper 提交于
-
- 27 1月, 2016 1 次提交
-
-
由 David Heinemeier Hansson 提交于
-
- 24 1月, 2016 4 次提交
-
-
由 Matthew Draper 提交于
We're no longer doing our work in the EM event loop, so errors are quite unlikely, and if they do occur, they're not really our responsibility to handle.
-
由 Matthew Draper 提交于
(as adapted to use concurrent-ruby / nio4r instead of eventmachine)
-
由 Matthew Draper 提交于
-
由 Matthew Draper 提交于
-
- 19 1月, 2016 5 次提交
- 16 1月, 2016 1 次提交
-
-
由 David Heinemeier Hansson 提交于
This reverts commit d0393fcc, reversing changes made to 3b7ccadf.
-
- 09 1月, 2016 1 次提交
-
-
由 David Heinemeier Hansson 提交于
-