1. 02 3月, 2016 1 次提交
  2. 01 3月, 2016 4 次提交
  3. 28 2月, 2016 3 次提交
  4. 27 2月, 2016 1 次提交
  5. 26 2月, 2016 1 次提交
  6. 25 2月, 2016 9 次提交
  7. 24 2月, 2016 1 次提交
  8. 23 2月, 2016 12 次提交
  9. 21 2月, 2016 1 次提交
  10. 19 2月, 2016 2 次提交
    • J
      Fix `unsubscribed` server side behavior · cefcc0f6
      Jon Moss 提交于
      Before this commit, the `unsubscribed` callbacks in Action Cable server
      side channels were never called. This is because when a WebSocket
      "goodbye" message was sent from the client, the Action Cable server
      didn't properly clean up after the now closed WebSocket. This means that
      memory could possibly skyrocket with this behavior, since part of this
      commit is to properly remove closed subscriptions from the global
      subscriptions hash. Say you have 10,000 users currently connected, and
      then all 10,000 disconnect -- before this patch, Action Cable would
      still hold onto information (and Ruby objects!) for all of these now
      dead connections.
      cefcc0f6
    • M
      Use a semaphore to signal message availability · 604fd2cb
      Matthew Draper 提交于
      The Event hack was too much of a hack: on actually thinking about it,
      there's a rather obvious race.
      604fd2cb
  11. 18 2月, 2016 2 次提交
    • J
      Truncate ActionCable broadcast message to 300 chars · 3fe383c6
      Jankees van Woezik 提交于
      When running the ActionCable server in development I get a lot of output
      in my logs, this commit sets a maximum length of 300 characters for a
      broadcast log message.
      3fe383c6
    • J
      Full Action Cable documentation read through · 05088b62
      Jon Moss 提交于
      This PR checks all active Action Cable documentation for typos and other
      fixes. It aims to make sure that when Rails 5 is released, that the
      Action Cable docs are up to snuff with the other documentation included
      with Rails.
      
      [ci skip]
      05088b62
  12. 15 2月, 2016 3 次提交
    • K
      Don't rely on the global server as a receiver. · 3ae8eb13
      Kasper Timm Hansen 提交于
      The `WorkerTest`'s `Receiver` is imporsonating an `ActionCable::Connection::Base`, but
      just delegates the logger to `ActionCable.logger`.
      
      This creates a mismatch as the connection requires the logger to be a
      `TaggedLoggerProxy`'ied logger, while the server doesn't.
      
      Thus to ensure an exception isn't raised when the worker tries to call `tag`
      other tests have to assign a proxied logger to their test server.
      
      Instead of forcing change on other tests, have Receiver adhere to the connection
      contract and use a `TaggedLoggerProxy`.
      
      As a consequence remove more setup from the tests.
      3ae8eb13
    • K
      Default connection class to ActionCable::Connection::Base. · 861ece99
      Kasper Timm Hansen 提交于
      Instead of depending on ApplicationCable::Connection being defined at initialize
      we should inject it in the Railtie.
      
      Thus we can kill more setup in the tests too.
      861ece99
    • K
      Inject Rails' channel paths in engine. · 66129817
      Kasper Timm Hansen 提交于
      We were explicitly referencing Rails.root in ActionCable::Server::Configuration.initialize,
      thereby coupling ourselves to Rails.
      
      Instead add `app/channels` to Rails' app paths and assign the existent files
      to `channel_paths`.
      
      Users can still append to those load paths with `<<` and `push` in `config/application.rb`.
      
      This means we can remove the custom `Dir` lookup in `channel_paths` and the Rails
      and root definitions in the tests.
      66129817