1. 18 7月, 2012 1 次提交
  2. 28 6月, 2012 3 次提交
  3. 24 5月, 2012 1 次提交
    • V
      Revert "Remove blank trailing comments" · 1ad0b378
      Vijay Dev 提交于
      This reverts commit fa6d921e.
      
      Reason: Not a fan of such massive changes. We usually close such changes
      if made to Rails master as a pull request. Following the same principle
      here and reverting.
      
      [ci skip]
      1ad0b378
  4. 20 5月, 2012 1 次提交
    • H
      Remove blank trailing comments · fa6d921e
      Henrik Hodne 提交于
      For future reference, this is the regex I used: ^\s*#\s*\n(?!\s*#). Replace
      with the first match, and voilà! Note that the regex matches a little bit too
      much, so you probably want to `git add -i .` and go through every single diff
      to check if it actually should be changed.
      fa6d921e
  5. 30 4月, 2012 1 次提交
  6. 27 4月, 2012 2 次提交
  7. 07 3月, 2012 1 次提交
  8. 01 3月, 2012 1 次提交
  9. 28 2月, 2012 1 次提交
  10. 17 2月, 2012 1 次提交
  11. 12 2月, 2012 1 次提交
  12. 11 2月, 2012 1 次提交
  13. 10 2月, 2012 2 次提交
  14. 11 1月, 2012 2 次提交
  15. 24 12月, 2011 1 次提交
  16. 22 12月, 2011 1 次提交
  17. 20 12月, 2011 1 次提交
  18. 14 12月, 2011 1 次提交
  19. 04 12月, 2011 1 次提交
    • J
      Fix #3837. · 9c172b29
      Jon Leighton 提交于
      We also need to time zone convert time zone aware attributes when
      accessed via read_attribute, not only when via direct access.
      9c172b29
  20. 02 12月, 2011 1 次提交
  21. 01 12月, 2011 4 次提交
  22. 06 11月, 2011 1 次提交
  23. 14 9月, 2011 1 次提交
    • J
      Stop trying to be clever about when to define attribute methods. · 3b8a7cf2
      Jon Leighton 提交于
      There is no meaningful performance penalty in defining attribute
      methods, since it only happens once.
      
      There is also no reason *not* to define them, since they get thrown in
      an included module, so they will not 'overwrite' anything. In fact, this
      is desirable, since it allows us to call super.
      3b8a7cf2
  24. 13 9月, 2011 3 次提交
    • J
      Deprecate using method_missing for attributes that are columns. · 1a421cec
      Jon Leighton 提交于
      This shouldn't ever happen unless people are doing something
      particularly weird, but adding a deprecation in case there are bugs not
      caught by our tests.
      1a421cec
    • J
      Let Ruby deal with method visibility. · ac687ed6
      Jon Leighton 提交于
      Check respond_to_without_attributes? in method_missing. If there is any
      method that responds (even private), let super handle it and raise
      NoMethodError if necessary.
      ac687ed6
    • J
      Always generate attribute methods on the base class. · eecfa84a
      Jon Leighton 提交于
      This fixes a situation I encountered where a subclass would cache the
      name of a generated attribute method in @_defined_class_methods. Then,
      when the superclass has it's attribute methods undefined, the subclass
      would always have to dispatch through method_missing, because the
      presence of the attribute in @_defined_class_methods would mean that it
      is never generated again, even if undefine_attribute_methods is called
      on the subclass.
      
      There various other confusing edge cases like this. STI classes share
      columns, so let's just keep all the attribute method generation state
      isolated to the base class.
      eecfa84a
  25. 16 8月, 2011 2 次提交
  26. 14 8月, 2011 1 次提交
  27. 31 7月, 2011 1 次提交
  28. 07 6月, 2011 1 次提交
  29. 05 6月, 2011 1 次提交
    • J
      Refactor Active Record test connection setup. Please see the... · 253bb6b9
      Jon Leighton 提交于
      Refactor Active Record test connection setup. Please see the RUNNING_UNIT_TESTS file for details, but essentially you can now configure things in test/config.yml. You can also run tests directly via the command line, e.g. ruby path/to/test.rb (no rake needed, uses default db connection from test/config.yml). This will help us fix the CI by enabling us to isolate the different Rails versions to different databases.
      253bb6b9