- 05 5月, 2020 1 次提交
-
-
由 Rafael Mendonça França 提交于
-
- 01 5月, 2020 1 次提交
-
-
由 Alberto Almagro 提交于
37913 added the possibility to deeply merge configurations by grouping them within a shared section. This powerful alternative was not reflected in any documentation, which made my team think it was not possible until I found out this feature after looking at the source code. This patch reflects this change in the documentation so that it is easier for other developers to know about this behavior.
-
- 22 4月, 2020 1 次提交
-
-
由 JvH 提交于
Add `config.active_storage.web_image_content_types` to allow applications to add content types (like `image/webp`) in which variants can be processed, instead of letting those images be converted to the fallback PNG format.
-
- 17 4月, 2020 1 次提交
-
-
由 Nick Burns 提交于
Co-Authored-By: NEileen M. Uchitelle <eileencodes@users.noreply.github.com>
-
- 12 4月, 2020 1 次提交
-
-
由 Haroon Ahmed 提交于
-
- 06 4月, 2020 2 次提交
-
-
由 Abhay Nikam 提交于
-
由 Jonathan Hefner 提交于
`url_for` will now use "https://" as the default protocol when `Rails.application.config.force_ssl` is set to true. Action Mailer already behaves this way, effectively. This commit extends that behavior application-wide. Closes #23543.
-
- 04 4月, 2020 1 次提交
-
-
由 Nick Burns 提交于
- adds the option `metadata_table` to a database connection
-
- 30 3月, 2020 1 次提交
-
-
由 David Heinemeier Hansson 提交于
* require, require_relative, load by double quotes We're getting rid of all single quote usage, unless it serves a specific purpose, as per the general style guide.
-
- 11 3月, 2020 1 次提交
-
-
由 Dino Maric 提交于
This PR adds `image/webp` to the default array of variable content types. Without this commit if we want to "handle" webp images overwriting `config.active_storage.variable_content_types` was necessary.
-
- 16 1月, 2020 1 次提交
-
-
由 Cliff Pruitt 提交于
This allows deprecation messages to be matched by substring, symbol (treated as substring), or regular expression. If a warning is matched, the behaviors configured for disallowed deprecations will be used. The default behavior for disallowed deprecation warnings is `:raise`. Also adds `ActiveSupport::Deprecation.allow` for thread-local, block level ignoring of deprecation warnings which would otherwise be disallowed by ActiveSupport::Deprecation.disallowed_warnings.
-
- 08 1月, 2020 1 次提交
-
-
由 Genadi Samokovarov 提交于
While trying to fix #16433, we made the middleware deletions always happen at the end. While this works for the case of deleting the Rack::Runtime middleware, it makes operations like the following misbehave. ```ruby gem "bundler", "< 1.16" begin require "bundler/inline" rescue LoadError => e $stderr.puts "Bundler version 1.10 or later is required. Please update your Bundler" raise e end gemfile(true) do source "https://rubygems.org" git_source(:github) { |repo| "https://github.com/#{repo}.git" } gem "rails", github: "rails/rails" end require "action_controller/railtie" class TestApp < Rails::Application config.root = __dir__ secrets.secret_key_base = "secret_key_base" config.logger = Logger.new($stdout) Rails.logger = config.logger middleware.insert_after ActionDispatch::Session::CookieStore, ::Rails::Rack::Logger, config.log_tags middleware.delete ::Rails::Rack::Logger end require "minitest/autorun" require "rack/test" class BugTest < Minitest::Test include Rack::Test::Methods def test_returns_success get "/" assert last_response.ok? end private def app Rails.application end end ``` In the case
☝ ️ the ::Rails::Rack::Logger would be deleted instead of moved, because the order of middleware stack building execution will be: ```ruby [:insert, ActionDispatch::Session::CookieStore, [::Rails::Rack::Logger]] [:delete, ::Rails::Rack::Logger, [config.log_tags]] ``` This is pretty surprising and hard to reason about behaviour, unless you go spelunking into the Rails configuration code. I have a few solutions in mind and all of them have their drawbacks. 1. Introduce a `Rails::Configuration::MiddlewareStackProxy#delete!` that delays the deleted operations. This will make `#delete` to be executed in order. The drawback here is backwards incompatible behavior and a new public method. 2. Just revert to the old operations. This won't allow people to delete the `Rack::Runtime` middleware. 3. Legitimize the middleware moving with the new `#move_after` and `#move_before` methods. This does not breaks any backwards compatibility, but includes 2 new methods to the middleware stack. I have implemented `3.` in this pull request. Happy holidays!🎄
-
- 02 1月, 2020 1 次提交
-
-
由 bogdanvlviv 提交于
This commit copies info from https://github.com/rails/rails/pull/33145 ([an excellent changelog](https://github.com/rails/rails/blob/6-0-stable/railties/CHANGELOG.md)) to our guides. Closes https://github.com/rails/rails/issues/36959 Not sure whether there is a need mentioning `config.hosts` in the "Upgrading to Rails 6.0" guide since it is configured to work in the development environment by default and we guide how to deal with "blocked host" issue, see: https://github.com/rails/rails/blob/6-0-stable/actionpack/lib/action_dispatch/middleware/templates/rescues/blocked_host.html.erb I would like to backport this to `6-0-stable` so users will be able to find info about `ActionDispatch::HostAuthorization` middleware and how to configure it. Give credit to @gsamokovarov since I copied the info from the changelog. <3 [bogdanvlviv, Genadi Samokovarov]
-
- 28 12月, 2019 1 次提交
-
-
由 Haroon Ahmed 提交于
-
- 23 12月, 2019 1 次提交
-
-
由 Petrik 提交于
According to the guide guidelines, all words except for prepositions, conjunctions, internal articles, and forms of the verb "to be" should be capitalized. This commit fixes some titles.
-
- 18 12月, 2019 1 次提交
-
-
由 Petrik 提交于
Some code examples were missing the language used for code highlighting.
-
- 13 12月, 2019 1 次提交
-
-
由 Kasper Timm Hansen 提交于
-
- 11 12月, 2019 1 次提交
-
-
由 Cliff Pruitt 提交于
-
- 07 12月, 2019 1 次提交
-
-
由 George Claghorn 提交于
-
- 03 12月, 2019 1 次提交
-
-
由 Peter Zhu 提交于
-
- 24 11月, 2019 1 次提交
-
-
由 Benoit Daloze 提交于
* https://github.com/guard/listen/releases/tag/v3.2.0 * https://github.com/guard/listen/issues/465 * `listen` removed the unmaintained `ruby_dep` dependency, which incorrectly shows warnings when running on TruffleRuby.
-
- 11 11月, 2019 1 次提交
-
-
由 bogdanvlviv 提交于
I changed `load_defaults` to `config.load_defaults` in the guide to emphasize its context, sorted headers "With 'x.x'" in descending and rephrased them to "With 'x.x', it includes previous versions' new defaults" and documented the method on https://api.rubyonrails.org.
-
- 09 11月, 2019 1 次提交
-
-
由 Rafael Mendonça França 提交于
class SensitiveJob < ApplicationJob self.log_arguments = false def perform(my_sensitive_argument) end end When dealing with sensitive arugments as password and tokens it is now possible to configure the job to not put the sensitive argument in the logs. Closes #34438.
-
- 07 11月, 2019 1 次提交
-
-
由 Takayuki Nakata 提交于
-
- 30 10月, 2019 1 次提交
-
-
由 Nate Dalo 提交于
-
- 07 10月, 2019 1 次提交
-
-
由 Kasper Timm Hansen 提交于
-
- 14 9月, 2019 2 次提交
-
-
由 Xavier Noria 提交于
-
由 Madogiwa 提交于
-
- 23 7月, 2019 2 次提交
-
-
由 ch3rub1m 提交于
-
由 Gannon McGibbon 提交于
Add configuration option to turn off drawing of Active Storage routes.
-
- 20 7月, 2019 1 次提交
-
-
由 George Claghorn 提交于
Assigning to a collection of attachments appends rather than replacing, as in 5.2. Existing 5.2 apps that rely on this behavior will no longer break when they're upgraded to 6.0. For apps generated on 6.0 or newer, assigning replaces the existing attachments in the collection. #attach should be used to add new attachments to the collection without removing existing ones. I expect that we'll deprecate the old behavior in 6.1. Closes #36374.
-
- 27 6月, 2019 1 次提交
-
-
由 Rodrigo Pavano 提交于
-
- 25 6月, 2019 1 次提交
-
-
由 Tatsuya Hoshino 提交于
The robots.txt site is moved permanently to https URL.
-
- 21 6月, 2019 1 次提交
-
-
由 yuuji.yaginuma 提交于
I changed return value of `ActionDispatch::Response#content_type` in #36034. But this change seems to an obstacle to upgrading. https://github.com/rails/rails/pull/36034#issuecomment-498795893 Therefore, I restored the behavior of `ActionDispatch::Response#content_type` to 5.2 and deprecated old behavior. Also, made it possible to control the behavior with the config.
-
- 16 6月, 2019 1 次提交
-
-
由 yuuji.yaginuma 提交于
Ref: bcf370d6, 06ab7b27.
-
- 05 6月, 2019 1 次提交
-
-
由 yuuji.yaginuma 提交于
-
- 28 5月, 2019 1 次提交
-
-
由 Corprew Reed 提交于
'Week day' has a specific meaning in English -- see https://en.wiktionary.org/wiki/weekday for details -- that is not meant here. 'Day of week' is more appropriate. [ci skip]
-
- 23 5月, 2019 1 次提交
-
-
由 George Claghorn 提交于
-
- 14 5月, 2019 1 次提交
-
-
由 Xavier Noria 提交于
-
- 13 5月, 2019 1 次提交
-
-
由 Vishal Telangre 提交于
[skip ci] The default value of config.active_record.collection_cache_versioning without loading Railtie is false Please check https://github.com/rails/rails/pull/36260#discussion_r283266942 for reference. [Vishal Telangre, bogdanvlviv]
-