- 26 11月, 2012 1 次提交
-
-
由 Roberto Soares 提交于
-
- 24 11月, 2012 2 次提交
-
-
由 Roberto Soares 提交于
-
由 Roberto Soares 提交于
For instance, it prevents false positive in this case: file = nil get :index assert_template("#{file}")
-
- 20 11月, 2012 1 次提交
-
-
由 Yves Senn 提交于
This resolves issues when rendering nested partials. Previously the `PartialRenderer` was reused which led to situations where the state of the renderer was reset. Closes #8197
-
- 16 11月, 2012 1 次提交
-
-
由 Santiago Pastorino 提交于
-
- 14 11月, 2012 1 次提交
-
-
由 Aaron Patterson 提交于
-
- 09 11月, 2012 2 次提交
-
-
由 James Coglan 提交于
Store FlashHashes in the session as plain hashes rather than custom objects with unstable class names and instance variables. Refactor FlashHash to take values for its ivars in the constructor, to pretty up FlashHash.from_session_value. Remove stale comment on FlashHash: it is no longer Marshaled in the session so we can change its implementation. Remove blank lines I introduced in controller/test_case.rb. Unit tests for FlashHash#to_session_value. Put in a compatibility layer to accept FlashHash serializations from Rails 3.0+. Test that Rails 3.2 session flashes are correctly converted to the new format. Remove code path for processing Rails 3.0 FlashHashes since they can no longer deserialize. Fix session['flash'] deletion condition: it will never be empty?, it will either be nil or a hash with 'discard' and 'flashes' keys.
-
由 Jon Leighton 提交于
This reverts commit 36376560, reversing changes made to 3148ed9a. Conflicts: actionpack/lib/action_dispatch/middleware/flash.rb Reason: it broke Sam's CI https://github.com/rails/rails/pull/8017#issuecomment-10210655
-
- 07 11月, 2012 4 次提交
-
-
由 Benjamin Quorning 提交于
-
由 Benjamin Quorning 提交于
-
由 Benjamin Quorning 提交于
-
由 Benjamin Quorning 提交于
-
- 05 11月, 2012 1 次提交
-
-
由 Carlos Antonio da Silva 提交于
-
- 04 11月, 2012 3 次提交
-
-
由 Santiago Pastorino 提交于
-
由 Santiago Pastorino 提交于
-
由 Santiago Pastorino 提交于
-
- 03 11月, 2012 1 次提交
-
-
由 James Coglan 提交于
Store FlashHashes in the session as plain hashes rather than custom objects with unstable class names and instance variables. Refactor FlashHash to take values for its ivars in the constructor, to pretty up FlashHash.from_session_value. Remove stale comment on FlashHash: it is no longer Marshaled in the session so we can change its implementation. Remove blank lines I introduced in controller/test_case.rb. Unit tests for FlashHash#to_session_value. Put in a compatibility layer to accept FlashHash serializations from Rails 3.0+. Test that Rails 3.2 session flashes are correctly converted to the new format. Remove code path for processing Rails 3.0 FlashHashes since they can no longer deserialize.
-
- 31 10月, 2012 2 次提交
-
-
由 David Heinemeier Hansson 提交于
-
由 David Heinemeier Hansson 提交于
-
- 27 10月, 2012 1 次提交
-
-
由 Yves Senn 提交于
-
- 18 10月, 2012 1 次提交
-
-
由 Rafael Mendonça França 提交于
-
- 12 10月, 2012 2 次提交
-
-
由 dfens 提交于
-
由 Santiago Pastorino 提交于
params.require(:person).permit(:projects_attributes) was returning => {"projects_attributes"=>{"0"=>{"name"=>"Project 1"}}} When should return => {} You should be doing ... params.require(:person).permit(projects_attributes: :name) to get just the projects attributes you want to allow
-
- 06 10月, 2012 2 次提交
-
-
由 Yves Senn 提交于
the documentation on #assert_template states that the :locals option is only available in view test cases: # In a view test case, you can also assert that specific locals are passed # to partials: I added a warning when it's passed in an inapropriate context to prevent a NoMethodError.
-
由 Rafael Mendonça França 提交于
This will make easier to permit date/time attributes generated by helpers like date_select. [Sven Schwyn + Rafael Mendonça França]
-
- 05 10月, 2012 1 次提交
-
-
由 Brendan Loudermilk 提交于
-
- 04 10月, 2012 2 次提交
-
-
由 Francesco Rodriguez 提交于
-
由 Francesco Rodriguez 提交于
-
- 02 10月, 2012 1 次提交
-
-
由 Steve Klabnik 提交于
It's best to just return text/plain when something has gone terribly wrong. Fixes #5660.
-
- 30 9月, 2012 1 次提交
-
-
由 Hugo Roque 提交于
Given Im rendering an template `/layout/hello.html.erb`, assert_template was passing with any string that matches. This behavior allowed false passing like: assert_template "layout" assert_template "out/hello" Now the passing possibilities are: assert_template "layout/hello" assert_template "hello" fixing assert_template bug when template matches expected, but not ends with Cherry Pick Merge: Fixes issue #3849 assert_template false positive taking redundant test off prevening incorrect assert_template when rendering with repeated names in path updating CHANGELOG with bugfix: assert_template false passing
-
- 28 9月, 2012 2 次提交
-
-
由 Francesco Rodriguez 提交于
-
由 Rafael Mendonça França 提交于
actionpack/test/template/spec_type_test.rb:32: warning: method redefined; discarding old test_spec_type_wont_match_non_space_characters actionpack/test/controller/spec_type_test.rb:30: warning: previous definition of test_spec_type_wont_match_non_space_characters was here
-
- 25 9月, 2012 2 次提交
-
-
由 Mike Moore 提交于
Allow controller tests using the spec DSL to match strings. Add test coverage for the register_spec_type calls.
-
由 Mike Moore 提交于
Add tests for controller tests using the minitest spec DSL.
-
- 19 9月, 2012 1 次提交
-
-
由 Philip Arndt 提交于
* The params as supplied pass born in authors[0] but not authors[1] so it seems like the test isn't covering what it should be covering.
-
- 18 9月, 2012 1 次提交
-
-
由 Yves Senn 提交于
-
- 17 9月, 2012 4 次提交
-
-
由 Guillermo Iguaran 提交于
-
由 Guillermo Iguaran 提交于
-
由 Guillermo Iguaran 提交于
-
由 Guillermo Iguaran 提交于
-