1. 26 11月, 2012 1 次提交
  2. 24 11月, 2012 2 次提交
  3. 20 11月, 2012 1 次提交
  4. 16 11月, 2012 1 次提交
  5. 14 11月, 2012 1 次提交
  6. 09 11月, 2012 2 次提交
    • J
      Store FlashHashes in the session as plain hashes rather than custom objects... · 654a2de7
      James Coglan 提交于
      Store FlashHashes in the session as plain hashes rather than custom objects with unstable class names and instance variables.
      
      Refactor FlashHash to take values for its ivars in the constructor, to pretty up FlashHash.from_session_value.
      
      Remove stale comment on FlashHash: it is no longer Marshaled in the session so we can change its implementation.
      
      Remove blank lines I introduced in controller/test_case.rb.
      
      Unit tests for FlashHash#to_session_value.
      
      Put in a compatibility layer to accept FlashHash serializations from Rails 3.0+.
      
      Test that Rails 3.2 session flashes are correctly converted to the new format.
      
      Remove code path for processing Rails 3.0 FlashHashes since they can no longer deserialize.
      
      Fix session['flash'] deletion condition: it will never be empty?, it will either be nil or a hash with 'discard' and 'flashes' keys.
      654a2de7
    • J
      Revert "Merge pull request #8017 from jcoglan/objectless_sessions" · 48428396
      Jon Leighton 提交于
      This reverts commit 36376560, reversing
      changes made to 3148ed9a.
      
      Conflicts:
      	actionpack/lib/action_dispatch/middleware/flash.rb
      
      Reason: it broke Sam's CI
      
      https://github.com/rails/rails/pull/8017#issuecomment-10210655
      48428396
  7. 07 11月, 2012 4 次提交
  8. 05 11月, 2012 1 次提交
  9. 04 11月, 2012 3 次提交
  10. 03 11月, 2012 1 次提交
    • J
      Store FlashHashes in the session as plain hashes rather than custom objects... · 76a0237c
      James Coglan 提交于
      Store FlashHashes in the session as plain hashes rather than custom objects with unstable class names and instance variables.
      
      Refactor FlashHash to take values for its ivars in the constructor, to pretty up FlashHash.from_session_value.
      
      Remove stale comment on FlashHash: it is no longer Marshaled in the session so we can change its implementation.
      
      Remove blank lines I introduced in controller/test_case.rb.
      
      Unit tests for FlashHash#to_session_value.
      
      Put in a compatibility layer to accept FlashHash serializations from Rails 3.0+.
      
      Test that Rails 3.2 session flashes are correctly converted to the new format.
      
      Remove code path for processing Rails 3.0 FlashHashes since they can no longer deserialize.
      76a0237c
  11. 31 10月, 2012 2 次提交
  12. 27 10月, 2012 1 次提交
  13. 18 10月, 2012 1 次提交
  14. 12 10月, 2012 2 次提交
  15. 06 10月, 2012 2 次提交
  16. 05 10月, 2012 1 次提交
  17. 04 10月, 2012 2 次提交
  18. 02 10月, 2012 1 次提交
  19. 30 9月, 2012 1 次提交
    • H
      `assert_template` no more passing with what ever string that matches. · 19dff78d
      Hugo Roque 提交于
      Given Im rendering an template `/layout/hello.html.erb`, assert_template was
      passing with any string that matches. This behavior allowed false passing like:
      
      	assert_template "layout"
      	assert_template "out/hello"
      
      Now the passing possibilities are:
      
      	assert_template "layout/hello"
      	assert_template "hello"
      
      fixing assert_template bug when template matches expected, but not ends with
      
      Cherry Pick Merge: Fixes issue #3849 assert_template false positive
      
      taking redundant test off
      
      prevening incorrect assert_template when rendering with repeated names in path
      
      updating CHANGELOG with bugfix: assert_template false passing
      19dff78d
  20. 28 9月, 2012 2 次提交
  21. 25 9月, 2012 2 次提交
  22. 19 9月, 2012 1 次提交
    • P
      Correct parameter access. · 45d6944a
      Philip Arndt 提交于
      * The params as supplied pass born in authors[0] but not authors[1] so it seems like the test isn't covering what it should be covering.
      45d6944a
  23. 18 9月, 2012 1 次提交
  24. 17 9月, 2012 4 次提交