- 28 2月, 2017 1 次提交
-
-
由 yuuji.yaginuma 提交于
Now reset the driver before take failed screenshot since #28144. However, I think that failed screenshot should be take with the driver actually used in the test. So, fixed to take screenshot before reset driver.
-
- 27 2月, 2017 17 次提交
-
-
由 Andrew White 提交于
Set correct host except development environment
-
由 Matthew Draper 提交于
Handle non-existing $ARCONN
-
由 Kir Shatrov 提交于
-
由 Eileen M. Uchitelle 提交于
Only load SystemTestCase if Puma is defined
-
由 yuuji.yaginuma 提交于
Currently `localhost` is used for the default host in all environments. But up to Rails 5.0, `0.0.0.0` is used except for development. So fixed to use the same value as 5.0. Fixes #28184
-
由 yuuji.yaginuma 提交于
SystemTestCase supports only Puma, and always load puma's file. https://github.com/rails/rails/blob/master/actionpack/lib/action_dispatch/system_testing/server.rb#L1 For that reason, the case of use Capybara but do not use Puma, it will cause an error. So we need to check about Puma is defined as well.
-
由 Andrew White 提交于
Use `max_identifier_length` for `index_name_length`
-
由 Andrew White 提交于
Fix `test_apply_distinct_in_count` failure in PG adapter
-
由 Andrew White 提交于
Fix `find_nth` with `limit_value`
-
由 Jon Moss 提交于
Update i18n guide to cover :zero key support in pluralization [ci skip]
-
由 Ryuta Kamizono 提交于
``` % ARCONN=postgresql be ruby -w -Itest test/cases/calculations_test.rb -n test_apply_distinct_in_count /Users/kamipo/src/github.com/rails/rails/activesupport/lib/active_support/core_ext/enumerable.rb:20: warning: method redefined; discarding old sum Using postgresql Run options: -n test_apply_distinct_in_count --seed 27731 F Finished in 0.163682s, 6.1094 runs/s, 30.5470 assertions/s. 1) Failure: CalculationsTest#test_apply_distinct_in_count [test/cases/calculations_test.rb:238]: Expected /\ASELECT(?! DISTINCT) COUNT\(DISTINCT\b/ to match "SHOW max_identifier_length". 1 runs, 5 assertions, 1 failures, 0 errors, 0 skips ``` https://travis-ci.org/rails/rails/jobs/205493811#L1933 https://travis-ci.org/rails/rails/jobs/205496299#L1562 https://travis-ci.org/rails/rails/jobs/205514765#L1562
-
由 Ryuta Kamizono 提交于
Actually `index_name_length` depend on `max_identifier_length`, not always 63.
-
由 Anne Johnson 提交于
-
由 Andrew White 提交于
Deprecate `supports_migrations?` on connection adapters
-
由 Andrew White 提交于
Refactor connection_pool_test
-
由 Ryuta Kamizono 提交于
`supports_migrations?` was added at 4160b518 to determine if schema statements (`create_table`, `drop_table`, etc) are implemented in the adapter. But all tested databases has been supported migrations since a4fc93c3 at least.
-
由 Kir Shatrov 提交于
-
- 26 2月, 2017 22 次提交
-
-
由 Andrew White 提交于
-
由 Andrew White 提交于
Include selects in group query with having clause
-
由 Eugene Kenny 提交于
When a grouped calculation contains a having clause that references a selected value, we need to include that selected value in the query. Postgres doesn't support referencing a selected value in a having clause, but other databases do; we can skip the test on the pg adapter but run it for the others. This was fixed before in 9a298a16, but the test coverage was lost in 5a05207d. The fix regressed in 6311975f and was removed in 97d46c17.
-
由 Andrew White 提交于
Remove unused params in RouteSet#add_route
-
由 Jerry Tao 提交于
-
由 Ryuta Kamizono 提交于
If the `index` exceeds a `limit`, simply return an empty result without querying the database.
-
由 Andrew White 提交于
Push `valid_type?` up to abstract adapter
-
由 Andrew White 提交于
Remove duplicated private method in ActiveRecord::FinderMethods
-
由 Andrew White 提交于
Remove useless `select_values += select_values`
-
由 Andrew White 提交于
Use released arel
-
由 yuuji.yaginuma 提交于
Follow up to ea9566f6
-
由 Ryuta Kamizono 提交于
`select_values` is a local variable defined at previous line. `select_values += select_values` is totally useless.
-
由 kami-zh 提交于
-
由 Nick Johnstone 提交于
It's common in test cases at my job to have code like this: let(:today) { customer_start_date + 2.weeks } let(:earlier_date) { today - 5.days } With this change, we can instead write let(:today) { 2.weeks.after(customer_start_date) } let(:earlier_date) { 5.days.before(today) } Closes #27721
-
由 Ryuta Kamizono 提交于
`valid_type?` should return true if a type exists in `native_database_types` at least. https://github.com/rails/rails/blob/v5.1.0.beta1/activerecord/lib/active_record/schema_dumper.rb#L136
-
由 Kasper Timm Hansen 提交于
Fix typo 'affect' -> 'effect' [ci skip]
-
由 Rebecca Skinner 提交于
-
由 Ryuta Kamizono 提交于
Currently `change_column` cannot drop default if `null: false` is specified at the same time. This change fixes the issue. ```ruby # cannot drop default change_column "tests", "contributor", :boolean, default: nil, null: false # we need the following workaround currently change_column "tests", "contributor", :boolean, null: false change_column "tests", "contributor", :boolean, default: nil ``` Closes #26582
-
由 Kasper Timm Hansen 提交于
AS CHANGELOG Pass
-
由 Vipul A M 提交于
-
由 Matthew Draper 提交于
Deprecate AbstractAdapter#verify! with arguments
-
由 Matthew Draper 提交于
Use ensure block for things we cleanup in tests
-