提交 45c5e26b 编写于 作者: R Ryuta Kamizono

Fix `test_apply_distinct_in_count` failure in PG adapter

```
% ARCONN=postgresql be ruby -w -Itest test/cases/calculations_test.rb -n test_apply_distinct_in_count
/Users/kamipo/src/github.com/rails/rails/activesupport/lib/active_support/core_ext/enumerable.rb:20: warning: method redefined; discarding old sum
Using postgresql
Run options: -n test_apply_distinct_in_count --seed 27731

F

Finished in 0.163682s, 6.1094 runs/s, 30.5470 assertions/s.

  1) Failure:
CalculationsTest#test_apply_distinct_in_count [test/cases/calculations_test.rb:238]:
Expected /\ASELECT(?! DISTINCT) COUNT\(DISTINCT\b/ to match "SHOW max_identifier_length".

1 runs, 5 assertions, 1 failures, 0 errors, 0 skips
```

https://travis-ci.org/rails/rails/jobs/205493811#L1933
https://travis-ci.org/rails/rails/jobs/205496299#L1562
https://travis-ci.org/rails/rails/jobs/205514765#L1562
上级 25c32272
......@@ -234,6 +234,9 @@ def test_apply_distinct_in_count
end
queries.each do |query|
# `table_alias_length` in `column_alias_for` would execute
# "SHOW max_identifier_length" statement in PostgreSQL adapter.
next if query == "SHOW max_identifier_length"
assert_match %r{\ASELECT(?! DISTINCT) COUNT\(DISTINCT\b}, query
end
end
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册