1. 01 6月, 2016 1 次提交
    • S
      Make Active Record emit significantly smaller YAML · c4cb6862
      Sean Griffin 提交于
      This reduces the size of a YAML encoded Active Record object by ~80%
      depending on the number of columns. There were a number of wasteful
      things that occurred when we encoded the objects before that have
      resulted in numerous wins
      
      - We were emitting the result of `attributes_before_type_cast` as a hack
        to work around some laziness issues
      - The name of an attribute was emitted multiple times, since the
        attribute objects were in a hash keyed by the name. We now store them
        in an array instead, and reconstruct the hash using the name
      - The types were included for every attribute. This would use backrefs
        if multiple objects were encoded, but really we don't need to include
        it at all unless it differs from the type at the class level. (The
        only time that will occur is if the field is the result of a custom
        select clause)
      - `original_attribute:` was included over and over and over again since
        the ivar is almost always `nil`. We've added a custom implementation
        of `encode_with` on the attribute objects to ensure we don't write the
        key when the field is `nil`.
      
      This isn't without a cost though. Since we're no longer including the
      types, an object can find itself in an invalid state if the type changes
      on the class after serialization. This is the same as 4.1 and earlier,
      but I think it's worth noting.
      
      I was worried that I'd introduce some new state bugs as a result of
      doing this, so I've added an additional test that asserts mutation not
      being lost as the result of YAML round tripping.
      
      Fixes #25145
      c4cb6862
  2. 31 5月, 2016 1 次提交
    • S
      `ActiveRecord::Base#hash` should differ between classes · c8be4574
      Sean Griffin 提交于
      Prior to this change, we would get collisions if Active Record objects
      of different classes with the same ID were used as keys of the same
      hash. It bothers me slightly that we have to allocate inside of this
      method, but Ruby doesn't provide any way to hash multiple values without
      allocation
      c8be4574
  3. 07 5月, 2016 1 次提交
  4. 06 5月, 2016 2 次提交
    • A
      s/specification_id/specification_name · 598e7c9e
      Arthur Neves 提交于
      598e7c9e
    • A
      Refactor connection handler · b83fb847
      Arthur Neves 提交于
      ConnectionHandler will not have any knowlodge of AR models now, it will
      only know about the specs.
      Like that we can decouple the two, and allow the same model to use more
      than one connection.
      
      Historically, folks used to create abstract AR classes on the fly in
      order to have multiple connections for the same model, and override the
      connection methods.
      
      With this, now we can override the `specificiation_id` method in the
      model, to return a key, that will be used to find the connection_pool
      from the handler.
      b83fb847
  5. 12 4月, 2016 1 次提交
  6. 01 4月, 2016 1 次提交
  7. 04 2月, 2016 2 次提交
  8. 03 2月, 2016 1 次提交
    • S
      Add initial support for allowing an error on order or limit of queries being ignored in batches · 08a74811
      Scott Ringwelski 提交于
      add some documentation and add 4 tests regarding error vs. warning behavior
      
      fix a typo when referring to the message
      
      go back to default in tests so that ordering is not important. use a constant instead of method. fix assert_nothing_raised call. use self.klass to allow per class configuration
      
      remove logger warn assets as that is tested elsewhere. pass error_on_ignore through find_each and find_in_batches also.
      
      add blocks to the finds so that the code is actually executed
      
      put the setting back to default in an ensure
      
      Add a changelog entry
      08a74811
  9. 12 1月, 2016 1 次提交
    • M
      Skip the STI condition when evaluating a default scope · 5c6d3653
      Matthew Draper 提交于
      Given a default_scope on a parent of the current class, where that
      parent is not the base class, the parent's STI condition would become
      attached to the evaluated default scope, and then override the child's
      own STI condition.
      
      Instead, we can treat the STI condition as though it is a default scope,
      and skip it in this situation: the scope will be merged into the base
      relation, which already contains the correct STI condition.
      
      Fixes #22426.
      5c6d3653
  10. 03 11月, 2015 1 次提交
  11. 14 10月, 2015 1 次提交
    • Y
      applies new doc guidelines to Active Record. · 428d47ad
      Yves Senn 提交于
      The focus of this change is to make the API more accessible.
      References to method and classes should be linked to make it easy to
      navigate around.
      
      This patch makes exzessiv use of `rdoc-ref:` to provide more readable
      docs. This makes it possible to document `ActiveRecord::Base#save` even
      though the method is within a separate module
      `ActiveRecord::Persistence`. The goal here is to bring the API closer to
      the actual code that you would write.
      
      This commit only deals with Active Record. The other gems will be
      updated accordingly but in different commits. The pass through Active
      Record is not completely finished yet. A follow up commit will change
      the spots I haven't yet had the time to update.
      
      /cc @fxn
      428d47ad
  12. 06 10月, 2015 1 次提交
  13. 29 9月, 2015 1 次提交
    • S
      Separate `dup` from `deep_dup` in the attributes hash · fb03a9ab
      Sean Griffin 提交于
      I'm looking to move towards a tree-like structure for dirty checking
      that involves an attribute holding onto the attribute that it was
      created from. This means that `changed?` can be fully encapsulated on
      that object. Since the objects are immutable, in `changes_applied`, we
      can simply perform a shallow dup, instead of a deep one.
      
      I'm not sure if that will actually end up in a performance boost, but
      I'd like to semantically separate these concepts regardless
      fb03a9ab
  14. 21 7月, 2015 1 次提交
    • S
      Extra caller details added to ActiveRecord::RecordNotFound · d763956e
      Sameer Rahmani 提交于
      ActiveRecord::RecordNotFound modified to store model name, primary_key
      and id of the caller model. It allows the catcher of this exception to make
      a better decision to what to do with it. For example consider this simple
      example:
      
          class SomeAbstractController < ActionController::Base
            rescue_from ActiveRecord::RecordNotFound, with: :redirect_to_404
      
            private def redirect_to_404(e)
              return redirect_to(posts_url) if e.model == 'Post'
              raise
            end
          end
      d763956e
  15. 16 7月, 2015 1 次提交
    • G
      Revert "Revert "Reduce allocations when running AR callbacks."" · beb07fbf
      Guo Xiang Tan 提交于
      This reverts commit bdc1d329.
      
      Before:
      Calculating -------------------------------------
                              22.000  i/100ms
      -------------------------------------------------
                              229.700  (± 0.4%) i/s -      1.166k
      Total Allocated Object: 9939
      
      After:
      Calculating -------------------------------------
                              24.000  i/100ms
      -------------------------------------------------
                              246.443  (± 0.8%) i/s -      1.248k
      Total Allocated Object: 7939
      
      ```
      begin
        require 'bundler/inline'
      rescue LoadError => e
        $stderr.puts 'Bundler version 1.10 or later is required. Please update your Bundler'
        raise e
      end
      
      gemfile(true) do
        source 'https://rubygems.org'
        # gem 'rails', github: 'rails/rails', ref: 'bdc1d329'
        gem 'rails', github: 'rails/rails', ref: 'd2876141'
        gem 'arel', github: 'rails/arel'
        gem 'sqlite3'
        gem 'benchmark-ips'
      end
      
      require 'active_record'
      require 'benchmark/ips'
      
      ActiveRecord::Base.establish_connection('sqlite3::memory:')
      
      ActiveRecord::Migration.verbose = false
      
      ActiveRecord::Schema.define do
        create_table :users, force: true do |t|
          t.string :name, :email
          t.boolean :admin
          t.timestamps null: false
        end
      end
      
      class User < ActiveRecord::Base
        default_scope { where(admin: true) }
      end
      
      admin = true
      
      1000.times do
        attributes = {
          name: "Lorem ipsum dolor sit amet, consectetur adipiscing elit.",
          email: "foobar@email.com",
          admin: admin
        }
      
        User.create!(attributes)
      
        admin = !admin
      end
      
      GC.disable
      
      Benchmark.ips(5, 3) do |x|
        x.report { User.all.to_a }
      end
      
      key =
        if RUBY_VERSION < '2.2'
          :total_allocated_object
        else
          :total_allocated_objects
        end
      
      before = GC.stat[key]
      User.all.to_a
      after = GC.stat[key]
      puts "Total Allocated Object: #{after - before}"
      ```
      beb07fbf
  16. 06 5月, 2015 1 次提交
  17. 30 3月, 2015 1 次提交
  18. 27 3月, 2015 1 次提交
  19. 26 3月, 2015 1 次提交
    • J
      Add `config.active_record.warn_on_records_fetched_greater_than` option · 4d6fbe29
      Jason Nochlin 提交于
      When set to an integer, a warning will be logged whenever a result set
      larger than the specified size is returned by a query. Fixes #16463
      
      The warning is outputed a module which is prepended in an initializer,
      so there will be no performance impact if
      `config.active_record.warn_on_records_fetched_greater_than` is not set.
      4d6fbe29
  20. 22 3月, 2015 1 次提交
  21. 18 3月, 2015 1 次提交
  22. 12 3月, 2015 1 次提交
    • B
      Isolate access to .default_scopes in ActiveRecord::Scoping::Default · c1deb81c
      Ben Woosley 提交于
      Instead use .scope_attributes? consistently in ActiveRecord to check whether
      there are attributes currently associated with the scope.
      
      Move the implementation of .scope_attributes? and .scope_attributes to
      ActiveRecord::Scoping because they don't particularly have to do specifically
      with Named scopes and their only dependency, in the case of
      .scope_attributes?, and only caller, in the case of .scope_attributes is
      contained in Scoping.
      c1deb81c
  23. 11 3月, 2015 1 次提交
    • S
      Attempt to provide backwards compatible YAML deserialization · afc124c3
      Sean Griffin 提交于
      I should have done this in the first place. We are now serializing an
      explicit version so we can make more careful changes in the future. This
      will load Active Record objects which were serialized in Rails 4.1.
      
      There will be bugs, as YAML serialization was at least partially broken
      back then. There will also be edge cases that we might not be able to
      handle, especially if the type of a column has changed.
      
      In addition, we're passing this as `from_database`, since that is
      required for serialized columns at minimum. All other types were
      serializing the cast value. At a glance, there should be no types for
      which this is a problem.
      
      Finally, dirty checking information will be lost on records serialized
      in 4.1, so no columns will be marked as changed.
      afc124c3
  24. 03 3月, 2015 2 次提交
  25. 02 3月, 2015 3 次提交
  26. 25 2月, 2015 1 次提交
  27. 22 2月, 2015 1 次提交
  28. 06 2月, 2015 2 次提交
  29. 02 2月, 2015 2 次提交
  30. 01 2月, 2015 1 次提交
    • S
      Attribute assignment and type casting has nothing to do with columns · 70ac0729
      Sean Griffin 提交于
      It's finally finished!!!!!!! The reason the Attributes API was kept
      private in 4.2 was due to some publicly visible implementation details.
      It was previously implemented by overloading `columns` and
      `columns_hash`, to make them return column objects which were modified
      with the attribute information.
      
      This meant that those methods LIED! We didn't change the database
      schema. We changed the attribute information on the class. That is
      wrong! It should be the other way around, where schema loading just
      calls the attributes API for you. And now it does!
      
      Yes, this means that there is nothing that happens in automatic schema
      loading that you couldn't manually do yourself. (There's still some
      funky cases where we hit the connection adapter that I need to handle,
      before we can turn off automatic schema detection entirely.)
      
      There were a few weird test failures caused by this that had to be
      fixed. The main source came from the fact that the attribute methods are
      now defined in terms of `attribute_names`, which has a clause like
      `return [] unless table_exists?`. I don't *think* this is an issue,
      since the only place this caused failures were in a fake adapter which
      didn't override `table_exists?`.
      
      Additionally, there were a few cases where tests were failing because a
      migration was run, but the model was not reloaded. I'm not sure why
      these started failing from this change, I might need to clear an
      additional cache in `reload_schema_from_cache`. Again, since this is not
      normal usage, and it's expected that `reset_column_information` will be
      called after the table is modified, I don't think it's a problem.
      
      Still, test failures that were unrelated to the change are worrying, and
      I need to dig into them further.
      
      Finally, I spent a lot of time debugging issues with the mutex used in
      `define_attribute_methods`. I think we can just remove that method
      entirely, and define the attribute methods *manually* in the call to
      `define_attribute`, which would simplify the code *tremendously*.
      
      Ok. now to make this damn thing public, and work on moving it up to
      Active Model.
      70ac0729
  31. 31 1月, 2015 1 次提交
  32. 13 1月, 2015 1 次提交
  33. 10 1月, 2015 1 次提交