- 12 7月, 2016 1 次提交
-
-
由 Santosh Wadghule 提交于
-
- 11 7月, 2016 1 次提交
-
-
由 Sean Griffin 提交于
When `group` is used in combination with any calculation method, the resulting hash uses the grouping expression as the key. Currently we're incorrectly always favoring the type reported by the query, instead of the type known by the class. This causes differing behavior depending on whether the adaptor actually gives proper types with the query or not. After this change, the behavior will be the same on all adaptors -- we see if we know the type from the class, fall back to the type from the query, and finally fall back to the identity type. Fixes #25595
-
- 09 7月, 2016 1 次提交
-
-
由 Rob Biedenharn 提交于
The documentation states that parameter values longer than 20 characters will be truncated by words, but the example shows that a parameter based on "David Heinemeier Hansson" (with id: 125) becomes "125-david" when "David Heinemeier".length == 16 so why so short? The answer lies in the use of the #truncate option omission: nil which seems to have been intended to mean "nothing", but which actually causes the default string "..." to be used. This causes #truncate to cleave words until the "..." can be added and still remain within the requested size of 20 characters. The better option is omission: '' (which is probably what was originally intended). Furthermore, since the use of #parameterize will remove non-alphanumeric characters, we can maximize the useful content of the output by calling parameterize first and then giving truncate a separator: /-/ rather than a space.
-
- 08 7月, 2016 1 次提交
-
-
由 Alex Kitchens 提交于
This includes minor grammar fixes throughout the file.
-
- 06 7月, 2016 5 次提交
-
-
由 Alex Kitchens 提交于
-
由 Matthew Draper 提交于
-
由 Matthew Draper 提交于
This way, we aren't racing other threads, so we don't need to re-check the conditional. And we no longer need to hold the lock while calling remove (which can choose to make a new connection while we wait).
-
由 Matthew Draper 提交于
A concurrent thread may have also detected it to be stale, and already released (or even reassigned) it by now. Fixes #25585
-
由 Matthew Draper 提交于
A thread can only release a connection if it owns it, or it's owned by a thread that has died.
-
- 04 7月, 2016 3 次提交
-
-
由 Kivanio Barbosa 提交于
-
由 Herman Hiddema 提交于
This nested if checked the same value as the containing case statement. Moved the code in the if/else into when/else in the containing case.
-
由 Ryuta Kamizono 提交于
-
- 03 7月, 2016 2 次提交
-
-
由 William Johnston 提交于
-
由 Ben Standefer 提交于
The current error message only indicates that a touch can fail because the record is new. In practice, we saw cases where touches were failing because the record had been destroyed. `persisted?` checks `new_record?` *and* `destroyed?`. It was confusing to get a message about a new record when in reality we were destroying records. I also included a helpful tip for users to consider using `persisted?`, `new_record?`, or `destroyed?` before touching.
-
- 02 7月, 2016 3 次提交
-
-
由 Ryuta Kamizono 提交于
-
由 Ryuta Kamizono 提交于
`create_table_info_cache` is used for sharing `create_table_info` both `table_options` and `foreign_keys`. But `foreign_keys` no longer uses `create_table_info_cache` by #25307. No need caching anymore.
-
由 Yasuo Honda 提交于
This reverts commit 407e0ab5.
-
- 01 7月, 2016 1 次提交
-
-
由 Ryuta Kamizono 提交于
Because causing an extra query by `sql_for_insert` for guessing a primary key. https://github.com/rails/rails/blob/v5.0.0/activerecord/lib/active_record/connection_adapters/postgresql/database_statements.rb#L121-L125
-
- 29 6月, 2016 3 次提交
-
-
由 Kevin McPhillips 提交于
Do not specal case inspecting associated arrays of over 10 elements, preventing infinite looping in some cases.
-
由 Sean Griffin 提交于
Right now with this middleware we are likely always connected, but I'm hoping to change that soon. This is an easy change to pull out on its own.
-
由 Sean Griffin 提交于
This method appears to have been partially used in connection pool caching, but it was introduced without much reasoning or any tests. One edge case test was added later on, but it was focused on implementation details. This method is no longer used outside of tests, and as such is removed.
-
- 27 6月, 2016 1 次提交
-
-
由 Alex Kitchens 提交于
-
- 25 6月, 2016 3 次提交
-
-
由 Ryuta Kamizono 提交于
This was added at c7c3f73f but it never raised because MySQL cannot create text/blob columns with a default value.
-
- 24 6月, 2016 4 次提交
-
-
由 Benjamin Quorning 提交于
If you only want the last element of a result set, there's no need to create all of hash_rows. Also, add a test.
-
由 Benjamin Quorning 提交于
The implementation from abstract/database_statements.rb seems to work just fine. And with ActiveRecord::Result now implementing an optimized #first method, the performance concerns previously addressed in https://github.com/rails/rails/commit/bf79aa4fc14aeb2646331e767038acf0b77e9e7f should not be an issue.
-
由 Benjamin Quorning 提交于
When you only need the first element of a result set, you shouldn't need to instantiate all of hash_rows.
-
由 yuuji.yaginuma 提交于
-
- 23 6月, 2016 1 次提交
-
-
由 Alex Kitchens 提交于
-
- 22 6月, 2016 1 次提交
-
-
由 David Elliott 提交于
-
- 20 6月, 2016 1 次提交
-
-
由 Alex Kitchens 提交于
-
- 16 6月, 2016 1 次提交
-
-
由 Ryuta Kamizono 提交于
`FinderMethods#exists?` should return a boolean rather than raising an exception. `UniquenessValidator#build_relation` catches a `RangeError` because it includes type casting due to a string value truncation. But a string value truncation was removed at #23523 then type casting in `build_relation` is no longer necessary. aa062318 removes type casting in `build_relation` then a `RangeError` moves to `relation.exists?`. This change will remove the catching a `RangeError`.
-
- 15 6月, 2016 1 次提交
-
-
由 Arthur Neves 提交于
Before we enable query caching we check if the connection is connected. Before this fix we were always checking against the main connection, and not the model connection.
-
- 14 6月, 2016 1 次提交
-
-
由 Rafael Mendonça França 提交于
Fixes #25391
-
- 13 6月, 2016 1 次提交
-
-
由 Ryuta Kamizono 提交于
`construct_relation_for_association_calculations` pass a string value to `construct_join_dependency` when setting a string value in `from`. It should not pass a string value, but always `joins_values`. Related #14834, #19452. Fixes #24193.
-
- 12 6月, 2016 1 次提交
-
-
由 Francesco Rodriguez 提交于
[ci skip]
-
- 11 6月, 2016 1 次提交
-
-
由 Ryuta Kamizono 提交于
-
- 10 6月, 2016 1 次提交
- 07 6月, 2016 1 次提交
-
-
由 Ryuta Kamizono 提交于
Fixes #25300.
-