Signed-off-by: NJosé Valim <jose.valim@gmail.com>

Signed-off-by: NXavier Noria <fxn@hashref.com>

[#5375 state:resolved]
Signed-off-by: NJosé Valim <jose.valim@gmail.com>

Signed-off-by: NJosé Valim <jose.valim@gmail.com>

no test was failing. Tests have been added to ensure that commenting
out the code within if loop would cause test failure.
Signed-off-by: NJosé Valim <jose.valim@gmail.com>

[#5486 state:committed]
Signed-off-by: NJeremy Kemper <jeremy@bitsweat.net>

now the reported line is the first line in the stack
that's outside Rails, which is the one that actually
caused the problem in the first place

[#5231 state:resolved]
Signed-off-by: NJosé Valim <jose.valim@gmail.com>

Signed-off-by: NSantiago Pastorino <santiago@wyeworks.com>

avoids a ton o warnings activesupport/lib/active_support/dependencies.rb:239: warning: loading in progress, circular require considered harmful ... activesupport/lib/active_support/core_ext/hash/indifferent_access.rb while running the suite in Ruby 1.9.2

Signed-off-by: Nwycats <wycats@gmail.com>

code gardening: we have assert_(nil|blank|present), more concise, with better default failure messages - let's use them

This reverts commit f480b2ce.

Reason: API guidelines discourage this, see http://edgeguides.rubyonrails.org/api_documentation_guidelines.html#example-code

This reverts commit 693f770a.

Reason: to be able to revert f480b2ce