提交 cacb4487 编写于 作者: N Neeraj Singh 提交者: José Valim

delegate method should treat :prefix => false same as :prefix => nil

[#5375 state:resolved]
Signed-off-by: NJosé Valim <jose.valim@gmail.com>
上级 9a6e3ae7
......@@ -113,7 +113,7 @@ def delegate(*methods)
raise ArgumentError, "Can only automatically set the delegation prefix when delegating to a method."
end
prefix = options[:prefix] && "#{options[:prefix] == true ? to : options[:prefix]}_"
prefix = options[:prefix] && "#{options[:prefix] == true ? to : options[:prefix]}_" || ''
file, line = caller.first.split(':', 2)
line = line.to_i
......
......@@ -47,6 +47,14 @@ class De
delegate :to_f, :to => :description, :allow_nil => true
end
Developer = Struct.new(:client) do
delegate :name, :to => :client, :prefix => nil
end
Tester = Struct.new(:client) do
delegate :name, :to => :client, :prefix => false
end
class Name
delegate :upcase, :to => :@full_name
......@@ -97,6 +105,11 @@ def test_delegation_custom_prefix
assert_equal invoice.customer_city, "Chicago"
end
def test_delegation_prefix_with_nil_or_false
assert_equal Developer.new(@david).name, "David"
assert_equal Tester.new(@david).name, "David"
end
def test_delegation_prefix_with_instance_variable
assert_raise ArgumentError do
Class.new do
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册