- 14 11月, 2017 2 次提交
-
-
由 Nikita Penzin 提交于
Ensure plugin_generator adds to new line in Gemfile, even if the Gemfile does not end with an empty line. [Lisa Ugray, Nikita Penzin]
-
由 Rafael Mendonça França 提交于
Make clear that the files are not to be run for interpreters. Fixes #23847. Fixes #30690. Closes #23878.
-
- 13 11月, 2017 1 次提交
-
-
由 Kasper Timm Hansen 提交于
Allow edits of existing encrypted secrets generated on Rails 5.1, but refer to credentials when attempting to setup. This also removes the need for any of the setup code, so the generator can be ripped out altogether.
-
- 09 11月, 2017 1 次提交
-
-
由 bogdanvlviv 提交于
These were added in #30101, after #31084 it became redundant.
-
- 08 11月, 2017 1 次提交
-
-
由 yuuji.yaginuma 提交于
In order to execute the `rails` command, need to run bundle install in advance. Therefore, if skipped bundle install, `rails` command may fail and should not do it.
-
- 07 11月, 2017 3 次提交
-
-
由 bogdanvlviv 提交于
-
由 bogdanvlviv 提交于
Omit `rails activestorage:install` for jdbcmysql, jdbc and shebang tests AppGeneratorTest#test_config_jdbcmysql_database rails aborted! LoadError: Could not load 'active_record/connection_adapters/mysql_adapter'. Make sure that the adapter in config/database.yml is valid. If you use an adapter other than 'mysql2', 'postgresql' or 'sqlite3' add the necessary adapter gem to the Gemfile. (compressed) bin/rails:4:in `<main>' Tasks: TOP => activestorage:install => environment (See full trace by running task with --trace) AppGeneratorTest#test_config_jdbc_database rails aborted! LoadError: Could not load 'active_record/connection_adapters/jdbc_adapter'. Make sure that the adapter in config/database.yml is valid. If you use an adapter other than 'mysql2', 'postgresql' or 'sqlite3' add the necessary adapter gem to the Gemfile. (compressed) bin/rails:4:in `<main>' Tasks: TOP => activestorage:install => environment (See full trace by running task with --trace) AppGeneratorTest#test_shebang_is_added_to_rails_file /home/ubuntu/.rbenv/versions/2.4.1/bin/ruby: no Ruby script found in input (LoadError) Prevent PendingMigrationError in tests * Run `bin/rails db:migrate RAILS_ENV=test` in test_cases before start tests to prevent PendingMigrationError * FileUtils.rm_r("db/migrate") * --skip-active-storage Fix failed tests in `railties/test/railties/engine_test.rb` Related to #30111 Imporve `SharedGeneratorTests#test_default_frameworks_are_required_when_others_are_removed` - Explicitly skip active_storage - Ensure that skipped frameworks are commented - Ensure that default frameworks are not commented Fix error `Errno::ENOSPC: No space left on device - sendfile` Since `rails new` runs `rails active_storage:install` that boots an app. Since adding Bootsnap 0312a5c6 during booting an app, it creates the cache: 264K tmp/cache/bootsnap-load-path-cache 27M tmp/cache/bootsnap-compile-cache * teardown_app must remove app
-
由 bogdanvlviv 提交于
Closes #30102 Revert part 787fe90d --skip-active-storage pass throughs `rails plugin new` Add changelog entry about default initialization of Active Storage
-
- 05 11月, 2017 1 次提交
-
-
由 yuuji.yaginuma 提交于
Currently, namespaced scaffold generator will generate an incorrect path and the generated file will not work properly. ``` $ ./bin/rails g scaffold admin/user $ ./bin/rails db:migrate $ ./bin/rails t test/controllers # Running: E Error: Admin::UsersControllerTest#test_should_create_admin_user: NameError: undefined local variable or method `admin_admin_users_url' for #<Admin::UsersControllerTest:0x000055a59f25ff68> Did you mean? admin_users test/controllers/admin/users_controller_test.rb:20:in `block (2 levels) in <class:UsersControllerTest>' test/controllers/admin/users_controller_test.rb:19:in `block in <class:UsersControllerTest>' bin/rails test test/controllers/admin/users_controller_test.rb:18 ``` This is because combine `controller_class_path` and `singular_table_name` to generate route. https://github.com/rails/rails/blob/360698aa245b45349d1d1b12e1afb34759515e69/railties/lib/rails/generators/named_base.rb#L172 Normally, if using namspaced generator, table name already contains namespace. Therefore, adding `controller_class_path` adds extra namespace. Since it is special only when explicitly specifying `model-name`, it is modified to change the value only when `model-name`is specified. Follow up of #30729
-
- 18 10月, 2017 1 次提交
-
-
由 Guillermo Iguaran 提交于
-
- 12 10月, 2017 1 次提交
-
-
由 yuuji.yaginuma 提交于
Ruby 2.5 warns about this. Ref: https://travis-ci.org/rails/rails/jobs/286338999
-
- 02 10月, 2017 1 次提交
-
-
由 yuuji.yaginuma 提交于
Because dummy application is only for use test, so credentials is unnecessary.
-
- 30 9月, 2017 1 次提交
-
-
由 yuuji.yaginuma 提交于
Since warning was issued due to duplication of test names, fix the test name to a meaningful name. This fixes following warnings: ``` railties/test/generators/named_base_test.rb:141: warning: method redefined; discarding old test_scaffold_plural_names railties/test/generators/named_base_test.rb:62: warning: previous definition of test_scaffold_plural_names was here ```
-
- 27 9月, 2017 1 次提交
-
-
由 yalab 提交于
-
- 25 9月, 2017 1 次提交
-
-
由 yuuji.yaginuma 提交于
If specify the `quiet` option, expect that no status will be shown. However, some process show status. This suppresses all status output.
-
- 12 9月, 2017 2 次提交
-
-
由 yhirano55 提交于
-
由 David Heinemeier Hansson 提交于
* WIP: Add credentials using a generic EncryptedConfiguration class This is sketch code so far. * Flesh out EncryptedConfiguration and test it * Better name * Add command and generator for credentials * Use the Pathnames * Extract EncryptedFile from EncryptedConfiguration and add serializers * Test EncryptedFile * Extract serializer validation * Stress the point about losing comments * Allow encrypted configuration to be read without parsing for display * Use credentials by default and base them on the master key * Derive secret_key_base in test/dev, source it from credentials in other envs And document the usage. * Document the new credentials setup * Stop generating the secrets.yml file now that we have credentials * Document what we should have instead Still need to make it happen, tho. * [ci skip] Keep wording to `key base`; prefer defaults. Usually we say we change defaults, not "spec" out a release. Can't use backticks in our sdoc generated documentation either. * Abstract away OpenSSL; prefer MessageEncryptor. * Spare needless new when raising. * Encrypted file test shouldn't depend on subclass. * [ci skip] Some woordings. * Ditch serializer future coding. * I said flip it. Flip it good. * [ci skip] Move require_master_key to the real production.rb. * Add require_master_key to abort the boot process. In case the master key is required in a certain environment we should inspect that the key is there and abort if it isn't. * Print missing key message and exit immediately. Spares us a lengthy backtrace and prevents further execution. I've verified the behavior in a test app, but couldn't figure the test out as loading the app just exits immediately with: ``` /Users/kasperhansen/Documents/code/rails/activesupport/lib/active_support/testing/isolation.rb:23:in `load': marshal data too short (ArgumentError) from /Users/kasperhansen/Documents/code/rails/activesupport/lib/active_support/testing/isolation.rb:23:in `run' from /Users/kasperhansen/.rbenv/versions/2.4.1/lib/ruby/gems/2.4.0/gems/minitest-5.10.2/lib/minitest.rb:830:in `run_one_method' from /Users/kasperhansen/.rbenv/versions/2.4.1/lib/ruby/gems/2.4.0/gems/minitest-5.10.2/lib/minitest/parallel.rb:32:in `block (2 levels) in start' ``` It's likely we need to capture and prevent the exit somehow. Kernel.stub(:exit) didn't work. Leaving it for tomorrow. * Fix require_master_key config test. Loading the app would trigger the `exit 1` per require_master_key's semantics, which then aborted the test. Fork and wait for the child process to finish, then inspect the exit status. Also check we aborted because of a missing master key, so something else didn't just abort the boot. Much <3 to @tenderlove for the tip. * Support reading/writing configs via methods. * Skip needless deep symbolizing. * Remove save; test config reader elsewhere. * Move secret_key_base check to when we're reading it. Otherwise we'll abort too soon since we don't assign the secret_key_base to secrets anymore. * Add missing string literal comments; require unneeded yaml require. * ya ya ya, rubocop. * Add master_key/credentials after bundle. Then we can reuse the existing message on `rails new bc4`. It'll look like: ``` Using web-console 3.5.1 from https://github.com/rails/web-console.git (at master@ce985eb) Using rails 5.2.0.alpha from source at `/Users/kasperhansen/Documents/code/rails` Using sass-rails 5.0.6 Bundle complete! 16 Gemfile dependencies, 72 gems now installed. Use `bundle info [gemname]` to see where a bundled gem is installed. Adding config/master.key to store the master encryption key: 97070158c44b4675b876373a6bc9d5a0 Save this in a password manager your team can access. If you lose the key, no one, including you, can access anything encrypted with it. create config/master.key ``` And that'll be executed even if `--skip-bundle` was passed. * Ensure test app has secret_key_base. * Assign secret_key_base to app or omit. * Merge noise * Split options for dynamic delegation into its own method and use deep symbols to make it work * Update error to point to credentials instead * Appease Rubocop * Validate secret_key_base when reading it. Instead of relying on the validation in key_generator move that into secret_key_base itself. * Fix generator and secrets test. Manually add config.read_encrypted_secrets since it's not there by default anymore. Move mentions of config/secrets.yml to config/credentials.yml.enc. * Remove files I have no idea how they got here. * [ci skip] swap secrets for credentials. * [ci skip] And now, changelogs are coming.
-
- 04 9月, 2017 1 次提交
-
-
由 yuuji.yaginuma 提交于
If the user used the `bin/test` to execute the test, this file is automatically loaded, so require is unnecessary. https://github.com/rails/rails/blob/acea68de026ba657cb65c4dd0fc1f24ba67e1cf8/railties/lib/rails/plugin/test.rb#L4 However, when using `rake test`, an explicit require is required because the above file is not loaded. Fixes #30516
-
- 23 8月, 2017 1 次提交
-
-
由 Yoshiyuki Hirano 提交于
-
- 22 8月, 2017 1 次提交
-
-
由 Koichi ITO 提交于
-
- 19 8月, 2017 1 次提交
-
-
由 Yoshiyuki Hirano 提交于
-
- 17 8月, 2017 1 次提交
-
-
由 bogdanvlviv 提交于
-
- 16 8月, 2017 2 次提交
-
-
由 Koichi ITO 提交于
And enable `context_dependent` of Style/BracesAroundHashParameters cop.
-
由 bogdanvlviv 提交于
Add SharedGeneratorTests#application_path This method will help to DRY in files app_generator_test.rb, plugin_generator_test.rb
-
- 15 8月, 2017 4 次提交
-
-
由 Yoshiyuki Hirano 提交于
-
由 Pat Allan 提交于
-
由 Pat Allan 提交于
-
由 Pat Allan 提交于
-
- 14 8月, 2017 1 次提交
-
-
由 Yoshiyuki Hirano 提交于
-
- 13 8月, 2017 1 次提交
-
-
由 Yoshiyuki Hirano 提交于
It can't use JavaScript in api mode. Action cable should be disabled by default.
-
- 12 8月, 2017 1 次提交
-
-
由 yhirano55 提交于
-
- 11 8月, 2017 1 次提交
-
-
由 Yoshiyuki Hirano 提交于
-
- 10 8月, 2017 4 次提交
-
-
由 bogdanvlviv 提交于
-
由 bogdanvlviv 提交于
Improve app generator tests. Ensure that generation `config/application.rb` is correct. Ensure that generation `config/application.rb` is correct.
-
由 David Heinemeier Hansson 提交于
This reverts commit a8f59044. See discussion on https://github.com/rails/rails/pull/30016.
-
- 09 8月, 2017 2 次提交
-
-
由 Yoshiyuki Hirano 提交于
-
由 Yoshiyuki Hirano 提交于
-
- 06 8月, 2017 2 次提交
-
-
由 Yoshiyuki Hirano 提交于
-
由 Yoshiyuki Hirano 提交于
-