1. 16 11月, 2017 1 次提交
    • W
      Add CLI to manage encrypted files/configs. · 7a8728a0
      Wojciech Wnętrzak 提交于
      To edit/show encrypted file:
      
      ```
      bin/rails encrypted:edit config/staging_tokens.yml.enc
      bin/rails encrypted:edit config/staging_tokens.yml.enc --key config/staging.key
      bin/rails encrypted:show config/staging_tokens.yml.enc
      ```
      
      Also provides a backing Rails.application.encrypted API for Ruby access:
      
      ```ruby
      Rails.application.encrypted("config/staging_tokens.yml.enc").read
      Rails.application.encrypted("config/staging_tokens.yml.enc").config
      Rails.application.encrypted("config/staging_tokens.yml.enc", key: "config/staging.key")
      ```
      7a8728a0
  2. 14 11月, 2017 3 次提交
  3. 13 11月, 2017 1 次提交
  4. 09 11月, 2017 2 次提交
  5. 08 11月, 2017 2 次提交
  6. 07 11月, 2017 4 次提交
    • B
      Fix `bin/rails db:migrate` with specified `VERSION` · 90fe2a42
      bogdanvlviv 提交于
      Ensure that `bin/rails db:migrate` with specified `VERSION` reverts
      all migrations only if `VERSION` is `0`.
      Raise error if target migration doesn't exist.
      90fe2a42
    • B
      f4af77ab
    • B
      `rails new` runs `rails active_storage:install` · 0835527d
      bogdanvlviv 提交于
      Omit `rails activestorage:install` for jdbcmysql, jdbc and shebang tests
      
      AppGeneratorTest#test_config_jdbcmysql_database
      
        rails aborted!
        LoadError: Could not load 'active_record/connection_adapters/mysql_adapter'.
        Make sure that the adapter in config/database.yml is valid.
        If you use an adapter other than 'mysql2', 'postgresql' or 'sqlite3' add
        the necessary adapter gem to the Gemfile.
        (compressed)
        bin/rails:4:in `<main>'
        Tasks: TOP => activestorage:install => environment
        (See full trace by running task with --trace)
      
      AppGeneratorTest#test_config_jdbc_database
      
        rails aborted!
        LoadError: Could not load 'active_record/connection_adapters/jdbc_adapter'.
        Make sure that the adapter in config/database.yml is valid.
        If you use an adapter other than 'mysql2', 'postgresql' or 'sqlite3' add
        the necessary adapter gem to the Gemfile.
        (compressed)
        bin/rails:4:in `<main>'
        Tasks: TOP => activestorage:install => environment
        (See full trace by running task with --trace)
      
      AppGeneratorTest#test_shebang_is_added_to_rails_file
      
        /home/ubuntu/.rbenv/versions/2.4.1/bin/ruby: no Ruby script found in input (LoadError)
      
      Prevent PendingMigrationError in tests
      
       * Run `bin/rails db:migrate RAILS_ENV=test` in test_cases before start tests to prevent PendingMigrationError
       * FileUtils.rm_r("db/migrate")
       * --skip-active-storage
      
      Fix failed tests in `railties/test/railties/engine_test.rb`
      
      Related to #30111
      
      Imporve `SharedGeneratorTests#test_default_frameworks_are_required_when_others_are_removed`
      
       - Explicitly skip active_storage
       - Ensure that skipped frameworks are commented
       - Ensure that default frameworks are not commented
      
      Fix error `Errno::ENOSPC: No space left on device - sendfile`
      
      Since `rails new` runs `rails active_storage:install`
      that boots an app.
      
      Since adding Bootsnap 0312a5c6
      during booting an app, it creates the cache:
      
         264K    tmp/cache/bootsnap-load-path-cache
         27M     tmp/cache/bootsnap-compile-cache
      
      * teardown_app must remove app
      0835527d
    • B
      Add --skip-active-storage and do so automatically when --skip-active-record is used · 4a835aa3
      bogdanvlviv 提交于
      Closes #30102
      
      Revert part 787fe90d
      
      --skip-active-storage pass throughs `rails plugin new`
      
      Add changelog entry about default initialization of Active Storage
      4a835aa3
  7. 05 11月, 2017 1 次提交
    • Y
      Generate the correct path in nested scaffold generator · 4dcb630c
      yuuji.yaginuma 提交于
      Currently, namespaced scaffold generator will generate an incorrect path
      and the generated file will not work properly.
      
      ```
      $ ./bin/rails g scaffold admin/user
      $ ./bin/rails db:migrate
      $  ./bin/rails t test/controllers
      # Running:
      
      E
      
      Error:
      Admin::UsersControllerTest#test_should_create_admin_user:
      NameError: undefined local variable or method `admin_admin_users_url' for #<Admin::UsersControllerTest:0x000055a59f25ff68>
      Did you mean?  admin_users
          test/controllers/admin/users_controller_test.rb:20:in `block (2 levels) in <class:UsersControllerTest>'
          test/controllers/admin/users_controller_test.rb:19:in `block in <class:UsersControllerTest>'
      
      bin/rails test test/controllers/admin/users_controller_test.rb:18
      ```
      
      This is because combine `controller_class_path` and `singular_table_name`
      to generate route.
      https://github.com/rails/rails/blob/360698aa245b45349d1d1b12e1afb34759515e69/railties/lib/rails/generators/named_base.rb#L172
      
      Normally, if using namspaced generator, table name already contains
      namespace. Therefore, adding `controller_class_path` adds extra namespace.
      Since it is special only when explicitly specifying `model-name`, it is
      modified to change the value only when `model-name`is specified.
      
      Follow up of #30729
      4dcb630c
  8. 04 11月, 2017 1 次提交
  9. 18 10月, 2017 3 次提交
  10. 16 10月, 2017 2 次提交
    • B
      `ActiveRecord::Tasks::DatabaseTasks.load_schema` has always to establish database connection · 678e563d
      bogdanvlviv 提交于
        When load schema from `structure.sql`, database connection isn't
        established. `ActiveRecord::Tasks::DatabaseTasks.load_schema` has to
        establish database connection since it executes
        ```
        ActiveRecord::InternalMetadata.create_table
        ActiveRecord::InternalMetadata[:environment] = environment
        ```
      678e563d
    • B
      Fix `bin/rails db:setup` and `bin/rails db:test:prepare` create wrong... · 99b2bf8d
      bogdanvlviv 提交于
      Fix `bin/rails db:setup` and `bin/rails db:test:prepare` create  wrong ar_internal_metadata's data for a test database.
      
        Before:
        ```
        $ RAILS_ENV=test rails dbconsole
        > SELECT * FROM ar_internal_metadata;
        key|value|created_at|updated_at
        environment|development|2017-09-11 23:14:10.815679|2017-09-11 23:14:10.815679
        ```
      
        After:
        ```
        $ RAILS_ENV=test rails dbconsole
        > SELECT * FROM ar_internal_metadata;
        key|value|created_at|updated_at
        environment|test|2017-09-11 23:14:10.815679|2017-09-11 23:14:10.815679
        ```
      
        Fixes #26731.
      99b2bf8d
  11. 14 10月, 2017 1 次提交
    • Y
      Fix test name for daemon option test · 6a755941
      yuuji.yaginuma 提交于
      In this test file, "server option" refers to the server used to start
      Rails(e.g. `puma`, `thin`).
      But this test, "server option" is not specified. Therefore, I think that
      it is incorrect that `server_option` is included in the test name.
      6a755941
  12. 13 10月, 2017 1 次提交
  13. 12 10月, 2017 1 次提交
  14. 09 10月, 2017 3 次提交
  15. 08 10月, 2017 1 次提交
  16. 07 10月, 2017 1 次提交
  17. 04 10月, 2017 1 次提交
    • E
      Implement H2 Early Hints for Rails · 59a02fb7
      eileencodes 提交于
      When puma/puma#1403 is merged Puma will support the Early Hints status
      code for sending assets before a request has finished.
      
      While the Early Hints spec is still in draft, this PR prepares Rails to
      allowing this status code.
      
      If the proxy server supports Early Hints, it will send H2 pushes to the
      client.
      
      This PR adds a method for setting Early Hints Link headers via Rails,
      and also automatically sends Early Hints if supported from the
      `stylesheet_link_tag` and the `javascript_include_tag`.
      
      Once puma supports Early Hints the `--early-hints` argument can be
      passed to the server to enable this or set in the puma config with
      `early_hints(true)`. Note that for Early Hints to work
      in the browser the requirements are 1) a proxy that can handle H2,
      and 2) HTTPS.
      
      To start the server with Early Hints enabled pass `--early-hints` to
      `rails s`.
      
      This has been verified to work with h2o, Puma, and Rails with Chrome.
      
      The commit adds a new option to the rails server to enable early hints
      for Puma.
      
      Early Hints spec:
      https://tools.ietf.org/html/draft-ietf-httpbis-early-hints-04
      
      [Eileen M. Uchitelle, Aaron Patterson]
      59a02fb7
  18. 02 10月, 2017 2 次提交
  19. 30 9月, 2017 1 次提交
    • Y
      Fix "warning: method redefined; discarding old test_scaffold_plural_names" · 8154c348
      yuuji.yaginuma 提交于
      Since warning was issued due to duplication of test names, fix the test
      name to a meaningful name.
      
      This fixes following warnings:
      
      ```
      railties/test/generators/named_base_test.rb:141: warning: method redefined; discarding old test_scaffold_plural_names
      railties/test/generators/named_base_test.rb:62: warning: previous definition of test_scaffold_plural_names was here
      ```
      8154c348
  20. 29 9月, 2017 1 次提交
  21. 27 9月, 2017 1 次提交
  22. 26 9月, 2017 2 次提交
  23. 25 9月, 2017 2 次提交
  24. 24 9月, 2017 1 次提交
  25. 22 9月, 2017 1 次提交
    • Y
      Use `TOPLEVEL_BINDING` in rails runner command · daa59229
      yuuji.yaginuma 提交于
      Binding to capture the local scope. This means that if a constant with same
      name as constant specified by the user exists in local scope, constant
      defined in local will use. This is different from what the user expects.
      Therefore, fixed to use top-level binding instead of local scope.
      
      Fixes #30644
      daa59229