- 26 2月, 2019 6 次提交
-
-
由 Aaron Patterson 提交于
This means we can eliminate nil checks and remove some mutations from the `decorate` method.
-
由 Rafael Mendonça França 提交于
-
由 Aaron Patterson 提交于
Support read queries with leading characters while preventing writes
-
由 Rafael Mendonça França 提交于
This is needed to fix #35278.
-
由 Ryuta Kamizono 提交于
Also, improving an argument error message for `limit`, extracting around `type_to_sql` code into schema statements, and more exercise tests.
-
由 Ryuta Kamizono 提交于
Fix prepared statements caching to be enabled even when query caching is enabled
-
- 25 2月, 2019 8 次提交
-
-
由 Ryuta Kamizono 提交于
Related cbcdecd2, 2a56b2d9. This is a regression caused by cbcdecd2. If query caching is enabled, prepared statement handles are never re-used, since we missed that a query is preprocessed when query caching is enabled, but doesn't keep the `preparable` flag. We should care about that case.
-
由 Ali Ibrahim 提交于
* The READ_QUERY regex would consider reads to be writes if they started with spaces or parens. For example, a UNION query might have parens around each SELECT - (SELECT ...) UNION (SELECT ...). * It will now correctly treat these queries as reads.
-
由 Ryuta Kamizono 提交于
activemodel typo fixes.
-
由 Ryuta Kamizono 提交于
Ensure `update_all` series doesn't care optimistic locking
-
由 alkesh26 提交于
-
由 Ryuta Kamizono 提交于
Incrementing the lock version invalidates any other process's optimistic lock, which is the desired outcome: the record no longer looks the same as it did when they loaded it.
-
由 Ryuta Kamizono 提交于
[ci skip] activejob typo fix.
-
由 alkesh26 提交于
-
- 24 2月, 2019 15 次提交
-
-
由 Ryuta Kamizono 提交于
Use "support/stubs/strong_parameters" instead.
-
由 Ryuta Kamizono 提交于
-
由 Ryuta Kamizono 提交于
-
由 Ryuta Kamizono 提交于
How to use `select` is updated [ci skip]
-
由 yuuji.yaginuma 提交于
Without this change, `store_translations` silently fails when available locales already initialized. Ref: https://travis-ci.org/rails/rails/jobs/497615616#L6846 https://travis-ci.org/rails/rails/jobs/497605027#L6856
-
由 soartec-lab 提交于
-
由 George Claghorn 提交于
Restore ActionDispatch::Http::UploadedFile compatibility with IO.copy_stream
-
由 Xavier Noria 提交于
We test the inflections for both autoloaders, but we can also autoload the constant as a sort of integration test.
-
由 Ryuta Kamizono 提交于
-
由 Ryuta Kamizono 提交于
-
由 Xavier Noria 提交于
[Harry Brundage & Xavier Noria]
-
由 Janko Marohnić 提交于
In https://github.com/rails/rails/pull/28676 the `#to_path` method was added to `ActionDispatch::Http::UploadedFile`. This broke usage with `IO.copy_stream`: source = ActionDispatch::Http::UploadedFile.new(...) IO.copy_stream(source, destination) # ~> TypeError: can't convert ActionDispatch::Http::UploadedFile to IO (ActionDispatch::Http::UploadedFile#to_io gives Tempfile) Normally `IO.copy_stream` just calls `#read` on the source object. However, when `#to_path` is defined, `IO.copy_stream` calls `#to_io` in order to retrieve the raw `File` object. In that case it trips up, because `ActionDispatch::Http::UploadedFile#to_io` returned a `Tempfile` object, which is not an `IO` subclass. We fix this by having `#to_io` return an actual `File` object.
-
由 Janko Marohnić 提交于
-
由 Ryuta Kamizono 提交于
minor grammar fix [ci skip]
-
由 Shivam Jain 提交于
-
- 23 2月, 2019 11 次提交
-
-
由 Xavier Noria 提交于
-
由 Aaron Patterson 提交于
Add a finalizer to inline templates
-
由 Yuji Yaginuma 提交于
Merge pull request #35375 from y-yagi/fix_test_select_with_subquery_in_from_uses_original_table_name Make `test_select_with_subquery_in_from_uses_original_table_name` work with old SQLite3
-
由 yuuji.yaginuma 提交于
It seems that the reason why the `test_select_with_subquery_in_from_uses_original_table_name` does not pass is that the return value of `sqlite3_column_name()` is wrong due to subquery flattening. This seems to have been fixed with SQLite 3.20.0(https://sqlite.org/changes.html#version_3_20_0). But CI uses the old version(maybe 3.11.0), I added `DISTINCT` to avoid optimization by subquery flattening. Ref: https://sqlite.org/optoverview.html#flattening
-
由 Aaron Patterson 提交于
This commit adds a finalizer just to inline templates. We can't cache compilation of inline templates because it's possible that people could have render calls that look like this: ```ruby loop do render inline: "#{rand}" end ``` and we would cache every one of these different inline templates. That would cause a memory leak. OTOH, we don't need finalizers on regular templates because we can cache, control, and detect changes to the template source. Fixes: #35372
-
由 Rafael França 提交于
Merge pull request #35367 from abhaynikam/update-getting-started-doc-for-migration-version-in-rails-6 Update migration version to 6.0 in the getting started doc [ci skip]
-
由 Ryuta Kamizono 提交于
Update callbacks skipping methods in guide. [ci skip]
-
由 Aaron Patterson 提交于
Ensure that rendered templates always have a format
-
由 Ryuta Kamizono 提交于
Somehow `ENV["BUILDKITE"]` didn't work as expected.
-
由 Aaron Patterson 提交于
This removes one call to `lookup_context` and also eliminates a conditional in `_render_template`.
-
由 Shivam Jain 提交于
-